In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000915 [In-Portal CMS] Data Management bug report always 2010-11-02 11:16 2010-11-30 12:48
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.1-RC1
Status closed Product Version 5.1.1-B2 Target Version 5.1.1
Time EstimateNo estimate
Summary 0000915: Link Comments are not Showing up in Admin
Description Link Comments are not Showing up in Admin.

To Replicate - submitted a Comment (old review) on the Front-end for a Link and it's perfectly fine except I do NOT see it in the Admin -> Comments grid.

Here is the SQL and looks like we get FALSE in WHERE which fails to
return the list.

SELECT inp_ItemReview.* ,(IF( ISNULL(pu.Login), IF
(inp_ItemReview.CreatedById = -1, 'root', IF
(inp_ItemReview.CreatedById = -2, 'Guest', 'n/a')), pu.Login )) AS
`ReviewedBy`,(item_table.l1_Name) AS `CatalogItemName`,
(item_table.LinkId) AS `CatalogItemId`,(ci.CategoryId) AS
`CatalogItemCategory`,(inp_ItemReview.CreatedOn) AS `CreatedOn_date`,
(inp_ItemReview.CreatedOn) AS `CreatedOn_time`
   FROM inp_ItemReview
   LEFT JOIN inp_PortalUser pu ON pu.PortalUserId =
   LEFT JOIN inp_Link item_table ON item_table.ResourceId =
   LEFT JOIN inp_CategoryItems ci ON item_table.ResourceId =
ci.ItemResourceId AND ci.PrimaryCat = 1
   WHERE ((FALSE) AND (inp_ItemReview.ItemType = 4))
   ORDER BY `inp_ItemReview`.`Priority`
desc,`inp_ItemReview`.`CreatedOn` desc,`inp_ItemReview`.`ReviewText`
   LIMIT 0,11
Additional Information Comments by Alex:

I've got those notices on link review list:

Notice (#1): Requested ID for prefix l not passed in ...\core\kernel\db\db_event_handler.php on line 327
Notice (#2): Parent ID not found (prefix: "l"; sub-prefix: "l-rev") in ...\core\kernel\db\dblist.php on line 1017

2nd notice is shown due changes in 0000771 task.

After all it seams, that review/comments section was working normally because of the bug, that was fixed.

Prefix "l-rev" (which is used here) is a "l" prefix subitem and therefore requires it's id for data filtering.

To solve this quickly we need to remove filter called "parent_filter" from list based on special used on "reviews_tab" template. Notices still will be displaying in this case.

Other way is to create another review prefix, that won't be a child for any of category item prefixes, as for now.
Tags No tags attached.
Change Log Message Fixed list of Comments in Admin
Estimate Points 0
Attached Files patch file icon Link-Comments-are-not-Showing.patch [^] (713 bytes) 2010-11-02 11:16 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
child of 0000771closed (5.1.1)alex Script eats up all memory during sub-item list printing 

-  Notes
User avatar (0002949)
Dmitry (manager)
2010-11-02 11:17

Please test and review.
User avatar (0002959)
alex (manager)
2010-11-03 04:37


However I wasn't able to edit any review, when logged-in by admin user (saw No Permission error).

This is not related to this task and as I recall such a bug is there for quite some time.
User avatar (0002960)
alex (manager)
2010-11-03 04:38

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000915: Link Comments are not Showing up in Admin
User avatar (0003001)
Dmitry (manager)
2010-11-30 12:48

Closing released 5.1.1 task.

- Related Changesets
In-Portal CMS: 5.1.x r14032
Timestamp: 2010-11-03 04:38:30
Author: alex
Details ] Diff ]
Fixes 0000915: Link Comments are not Showing up in Admin
mod - /in-portal/branches/5.1.x/core/units/reviews/reviews_event_handler.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-11-30 12:48 Dmitry Note Added: 0003001
2010-11-30 12:48 Dmitry Status resolved => closed
2010-11-03 04:38 alex Note Added: 0002960
2010-11-03 04:38 alex Status reviewed and tested => resolved
2010-11-03 04:38 alex Fixed in Version => 5.1.1-RC1
2010-11-03 04:38 alex Resolution open => fixed
2010-11-03 04:38 alex Assigned To !COMMUNITY => alex
2010-11-03 04:38 alex Changeset attached 5.1.x r14032
2010-11-03 04:37 alex Note Added: 0002959
2010-11-03 04:37 alex Status needs testing => reviewed and tested
2010-11-02 11:18 Dmitry Relationship added child of 0000771
2010-11-02 11:18 Dmitry Additional Information Updated View Revisions
2010-11-02 11:17 Dmitry Note Added: 0002949
2010-11-02 11:17 Dmitry Assigned To => !COMMUNITY
2010-11-02 11:17 Dmitry Developer => Dmitry
2010-11-02 11:17 Dmitry Status active => needs testing
2010-11-02 11:16 Dmitry New Issue
2010-11-02 11:16 Dmitry File Added: Link-Comments-are-not-Showing.patch
2010-11-02 11:16 Dmitry Reference =>
2010-11-02 11:16 Dmitry Change Log Message => Fixed list of Comments in Admin

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker