In-Portal Issue Tracker - In-Portal CMS
|
||||||||||
Viewing Issue Advanced Details | ||||||||||
|
||||||||||
ID: | Category: | Type: | Reproducibility: | Date Submitted: | Last Update: | |||||
915 | [In-Portal CMS] Data Management | bug report | always | 2010-11-02 11:16 | 2010-11-30 12:48 | |||||
|
||||||||||
Reporter: | Dmitry | Platform: | ||||||||
Assigned To: | alex | OS: | ||||||||
Priority: | normal | OS Version: | ||||||||
Status: | closed | Product Version: | 5.1.1-B2 | |||||||
Product Build: | Resolution: | fixed | ||||||||
ETA: | none | Fixed in Version: | 5.1.1-RC1 | |||||||
Reference: | http://groups.google.com/group/in-portal-bugs/browse_thread/thread/1f8419085ca8ca76 | |||||||||
Change Log Message: | Fixed list of Comments in Admin | |||||||||
Estimate Points: | 0 | |||||||||
|
||||||||||
Summary: | 0000915: Link Comments are not Showing up in Admin | |||||||||
Description: |
Link Comments are not Showing up in Admin. To Replicate - submitted a Comment (old review) on the Front-end for a Link and it's perfectly fine except I do NOT see it in the Admin -> Comments grid. Here is the SQL and looks like we get FALSE in WHERE which fails to return the list. SELECT inp_ItemReview.* ,(IF( ISNULL(pu.Login), IF (inp_ItemReview.CreatedById = -1, 'root', IF (inp_ItemReview.CreatedById = -2, 'Guest', 'n/a')), pu.Login )) AS `ReviewedBy`,(item_table.l1_Name) AS `CatalogItemName`, (item_table.LinkId) AS `CatalogItemId`,(ci.CategoryId) AS `CatalogItemCategory`,(inp_ItemReview.CreatedOn) AS `CreatedOn_date`, (inp_ItemReview.CreatedOn) AS `CreatedOn_time` FROM inp_ItemReview LEFT JOIN inp_PortalUser pu ON pu.PortalUserId = inp_ItemReview.CreatedById LEFT JOIN inp_Link item_table ON item_table.ResourceId = inp_ItemReview.ItemId LEFT JOIN inp_CategoryItems ci ON item_table.ResourceId = ci.ItemResourceId AND ci.PrimaryCat = 1 WHERE ((FALSE) AND (inp_ItemReview.ItemType = 4)) ORDER BY `inp_ItemReview`.`Priority` desc,`inp_ItemReview`.`CreatedOn` desc,`inp_ItemReview`.`ReviewText` asc LIMIT 0,11 |
|||||||||
Steps To Reproduce: | ||||||||||
Additional Information: |
Comments by Alex: I've got those notices on link review list: Notice (#1): Requested ID for prefix l not passed in ...\core\kernel\db\db_event_handler.php on line 327 Notice (#2): Parent ID not found (prefix: "l"; sub-prefix: "l-rev") in ...\core\kernel\db\dblist.php on line 1017 2nd notice is shown due changes in 0000771 task. After all it seams, that review/comments section was working normally because of the bug, that was fixed. Prefix "l-rev" (which is used here) is a "l" prefix subitem and therefore requires it's id for data filtering. To solve this quickly we need to remove filter called "parent_filter" from list based on special used on "reviews_tab" template. Notices still will be displaying in this case. Other way is to create another review prefix, that won't be a child for any of category item prefixes, as for now. |
|||||||||
Relationships |
| |||||||||
Attached Files: |
Link-Comments-are-not-Showing.patch (713) 2010-11-02 11:16 http://tracker.in-portal.org/file_download.php?file_id=832&type=bug |
|||||||||
|
||||||||||
Issue History | ||||||||||
Date Modified | Username | Field | Change | |||||||
2010-11-30 12:48 | Dmitry | Note Added: 0003001 | ||||||||
2010-11-30 12:48 | Dmitry | Status | resolved => closed | |||||||
2010-11-03 04:38 | alex | Note Added: 0002960 | ||||||||
2010-11-03 04:38 | alex | Status | reviewed and tested => resolved | |||||||
2010-11-03 04:38 | alex | Fixed in Version | => 5.1.1-RC1 | |||||||
2010-11-03 04:38 | alex | Resolution | open => fixed | |||||||
2010-11-03 04:38 | alex | Assigned To | !COMMUNITY => alex | |||||||
2010-11-03 04:38 | alex | Changeset attached | 5.1.x r14032 | |||||||
2010-11-03 04:37 | alex | Note Added: 0002959 | ||||||||
2010-11-03 04:37 | alex | Status | needs testing => reviewed and tested | |||||||
2010-11-02 11:18 | Dmitry | Relationship added | child of 0000771 | |||||||
2010-11-02 11:18 | Dmitry | Additional Information Updated | bug_revision_view_page.php?rev_id=604#r604 | |||||||
2010-11-02 11:17 | Dmitry | Note Added: 0002949 | ||||||||
2010-11-02 11:17 | Dmitry | Assigned To | => !COMMUNITY | |||||||
2010-11-02 11:17 | Dmitry | Developer | => Dmitry | |||||||
2010-11-02 11:17 | Dmitry | Status | active => needs testing | |||||||
2010-11-02 11:16 | Dmitry | New Issue | ||||||||
2010-11-02 11:16 | Dmitry | File Added: Link-Comments-are-not-Showing.patch | ||||||||
2010-11-02 11:16 | Dmitry | Reference | => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/1f8419085ca8ca76 | |||||||
2010-11-02 11:16 | Dmitry | Change Log Message | => Fixed list of Comments in Admin |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|