In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/f9b46b692ff68bf2

Change Log Message

Estimate Points

Attached Files

always_set_sub_item_list_parent_filter.patch [^] (3,132 bytes) 2010-06-10 14:12 [Show Content]

Index: kernel/db/dblist.php
===================================================================
--- kernel/db/dblist.php	(revision 13681)
+++ kernel/db/dblist.php	(working copy)
@@ -925,14 +925,22 @@
 			$foreign_key_field = $this->Application->getUnitOption($this->Prefix, 'ForeignKey');
 			if (is_array($foreign_key_field)) $foreign_key_field = getArrayValue($foreign_key_field, $parent_prefix);
 
-			if (!$parent_table_key || !$foreign_key_field) return ;
+			if (!$parent_table_key || !$foreign_key_field) {
+				return ;
+			}
 
-			$parent_object =& $this->Application->recallObject($parent_prefix.'.'.$special);
-			$parent_id = $parent_object->GetDBField($parent_table_key);
+			$parent_object =& $this->Application->recallObject($parent_prefix.'.'.$special, null, Array ('raise_warnings' => 0));
+			/* @var $parent_object kDBItem */
 
-			if (!$parent_id) return ;
+			if (!$parent_object->isLoaded()) {
+				$this->addFilter('parent_filter', 'FALSE');
+				trigger_error('Parent ID not found (prefix: "<strong>' . rtrim($parent_prefix.'.'.$special, '.') . '</strong>"; sub-prefix: "<strong>' . $this->getPrefixSpecial() . '</strong>")', E_USER_NOTICE);
+				return ;
+			}
 
-			$this->addFilter('parent_filter', '`'.$this->TableName.'`.`'.$foreign_key_field.'` = '.$parent_id);	// only for list in this case
+			// only for list in this case
+			$parent_id = $parent_object->GetDBField($parent_table_key);
+			$this->addFilter('parent_filter', '`' . $this->TableName . '`.`' . $foreign_key_field . '` = ' . $this->Conn->qstr($parent_id));
 		}
 	}
 
Index: units/email_messages/email_messages_event_handler.php
===================================================================
--- units/email_messages/email_messages_event_handler.php	(revision 13681)
+++ units/email_messages/email_messages_event_handler.php	(working copy)
@@ -65,8 +65,12 @@
 				$object->addFilter('module_filter', 'Module = ' . $this->Conn->qstr($module));
 			}
 
-			if (($event->Special == 'st') && !$this->Application->isDebugMode()) {
-				$object->addFilter('enabled_filter', TABLE_PREFIX . 'Events.Enabled <> ' . STATUS_DISABLED);
+			if ($event->Special == 'st') {
+				if (!$this->Application->isDebugMode()) {
+					$object->addFilter('enabled_filter', TABLE_PREFIX . 'Events.Enabled <> ' . STATUS_DISABLED);
+				}
+
+				$object->removeFilter('parent_filter');
 			}
 		}
 
Index: units/phrases/phrases_event_handler.php
===================================================================
--- units/phrases/phrases_event_handler.php	(revision 13681)
+++ units/phrases/phrases_event_handler.php	(working copy)
@@ -73,6 +73,25 @@
 		}
 
 		/**
+		 * Apply any custom changes to list's sql query
+		 *
+		 * @param kEvent $event
+		 * @access protected
+		 * @see OnListBuild
+		 */
+		function SetCustomQuery(&$event)
+		{
+			parent::SetCustomQuery($event);
+
+			if ($event->Special == 'st') {
+				$object =& $event->getObject();
+				/* @var $object kDBList */
+
+				$object->removeFilter('parent_filter');
+			}
+		}
+
+		/**
 		 * Forces new label in case if issued from get link
 		 *
 		 * @param kEvent $event

always_set_sub_item_list_parent_filter_v2_(for_510).patch [^] (1,447 bytes) 2010-07-31 09:03 [Show Content]

Index: kernel/db/dblist.php
===================================================================
--- kernel/db/dblist.php	(revision 13756)
+++ kernel/db/dblist.php	(working copy)
@@ -933,14 +933,22 @@
 			$foreign_key_field = $this->Application->getUnitOption($this->Prefix, 'ForeignKey');
 			if (is_array($foreign_key_field)) $foreign_key_field = getArrayValue($foreign_key_field, $parent_prefix);
 
-			if (!$parent_table_key || !$foreign_key_field) return ;
+			if (!$parent_table_key || !$foreign_key_field) {
+				return ;
+			}
 
 			$parent_object =& $this->Application->recallObject($parent_prefix.'.'.$special);
-			$parent_id = $parent_object->GetDBField($parent_table_key);
+			/* @var $parent_object kDBItem */
 
-			if (!$parent_id) return ;
+			if (!$parent_object->isLoaded()) {
+				$this->addFilter('parent_filter', 'FALSE');
+				trigger_error('Parent ID not found (prefix: "<strong>' . rtrim($parent_prefix.'.'.$special, '.') . '</strong>"; sub-prefix: "<strong>' . $this->getPrefixSpecial() . '</strong>")', E_USER_NOTICE);
+				return ;
+			}
 
-			$this->addFilter('parent_filter', '`'.$this->TableName.'`.`'.$foreign_key_field.'` = '.$parent_id);	// only for list in this case
+			// only for list in this case
+			$parent_id = $parent_object->GetDBField($parent_table_key);
+			$this->addFilter('parent_filter', '`' . $this->TableName . '`.`' . $foreign_key_field . '` = ' . $this->Conn->qstr($parent_id));
 		}
 	}

Relationships [ Relation Graph ] [ Dependency Graph ]

parent of

0000915

closed (5.1.1)

alex

Link Comments are not Showing up in Admin

Notes
(0002626) Dmitry (manager) 2010-07-30 18:57	Please re-assemble the patch for 5.1.0.

(0002633) alex (manager) 2010-07-31 09:03	Re-assembled.

(0002641) Dmitry (manager) 2010-08-02 10:56	2nd patch tested good, please commit into 5.1.1

(0002714) alex (manager) 2010-08-28 16:14	Fix committed to 5.1.x branch. Commit Message: Fixes 0000771: Script eats up all memory during sub-item list printing

(0003070) Dmitry (manager) 2010-11-30 12:48	Closing released 5.1.1 task.

Related Changesets
In-Portal CMS: 5.1.x r13882 Timestamp: 2010-08-28 16:14:43 Author: alex [ Details ] [ Diff ]	Fixes 0000771: Script eats up all memory during sub-item list printing
	mod - /in-portal/branches/5.1.x/core/kernel/db/dblist.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-11-30 12:48	Dmitry	Note Added: 0003070
2010-11-30 12:48	Dmitry	Status	resolved => closed
2010-11-02 11:18	Dmitry	Relationship added	parent of 0000915
2010-08-28 16:14	alex	Note Added: 0002714
2010-08-28 16:14	alex	Status	reviewed and tested => resolved
2010-08-28 16:14	alex	Fixed in Version	=> 5.1.1-B1
2010-08-28 16:14	alex	Resolution	open => fixed
2010-08-28 16:14	alex	Assigned To	!COMMUNITY => alex
2010-08-28 16:14	alex	Changeset attached	5.1.x r13882
2010-08-02 10:56	Dmitry	Note Added: 0002641
2010-08-02 10:56	Dmitry	Status	needs testing => reviewed and tested
2010-07-31 13:19	Dmitry	Target Version	Icebox => 5.1.1
2010-07-31 09:03	alex	Note Added: 0002633
2010-07-31 09:03	alex	Assigned To	alex => !COMMUNITY
2010-07-31 09:03	alex	Status	needs work => needs testing
2010-07-31 09:03	alex	File Added: always_set_sub_item_list_parent_filter_v2_(for_510).patch
2010-07-30 18:57	Dmitry	Note Added: 0002626
2010-07-30 18:57	Dmitry	Assigned To	!COMMUNITY => alex
2010-07-30 18:57	Dmitry	Status	needs testing => needs work
2010-06-10 14:12	alex	Assigned To	=> !COMMUNITY
2010-06-10 14:12	alex	Developer	=> alex
2010-06-10 14:12	alex	Status	active => needs testing
2010-06-10 14:12	alex	New Issue
2010-06-10 14:12	alex	File Added: always_set_sub_item_list_parent_filter.patch
2010-06-10 14:12	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/f9b46b692ff68bf2

Web Development by Intechnic

In-Portal Open Source CMS