Anonymous | Login | Signup for a new account | 2024-09-13 14:54 CDT |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0000566 | [In-Portal CMS] Front End | bug report | always | 2010-02-03 13:29 | 2010-05-11 02:59 | ||
Reporter | alex | View Status | public | Project Name | In-Portal CMS | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Fixed in Version | 5.0.3-B1 | ||
Status | closed | Product Version | 5.0.2 | Target Version | 5.0.3 | ||
Time Estimate | No estimate | ||||||
Summary | 0000566: Don't include tracking code during site content editing in browse modes | ||||||
Description | Don't include any kind of page tracking code (e.g. google analytics), when admin is editing site contents (front-end in a frame) so page tracker won't count any fake visits. | ||||||
Additional Information | |||||||
Tags | No tags attached. | ||||||
Reference | http://groups.google.com/group/in-portal-dev/browse_thread/thread/4657b3af9de8f9d8 | ||||||
Change Log Message | |||||||
Estimate Points | 0 | ||||||
Attached Files |
566-Dont_include_tracking_code_during_site_content -Dmitry-20100203-v1.patch [^] (1,101 bytes) 2010-02-03 16:01
[Show Content]
569-Different_Tag_for_Analytics_Tracking_code-Dmitry-20100315-v2.patch [^] (3,082 bytes) 2010-03-15 16:13 [Show Content] analytics_tag_fix.patch [^] (460 bytes) 2010-03-22 15:03 [Show Content] |
||||||
|
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||||||||||||||||||||||||
|
Notes | |
(0001464) Dmitry (manager) 2010-02-03 16:44 |
Can't seem to find "cms_DefaultIndextoolsCode_SSL" and "cms_DefaultIndextoolsCode" variables anywhere in install_data.sqls or in my local DB install. We are referring to them in function PageInfo($params) method. Did you every saw these things? |
(0001491) Dmitry (manager) 2010-02-26 16:58 |
Reminder sent to: alex Can you please check on this? |
(0001551) alex (manager) 2010-03-11 05:52 |
It seems that you don't follow discussion in google groups related to this task. I have posted answer there, because original question is also there and it's just copied as task note. In any case here is my answer (copied from discussion): ======================================================= You were right. I've searched through our repository and there never were such configuration variables like *cms_DefaultIndextoolsCode_SSL* and * cms_DefaultIndextoolsCode* in any of our projects. Looks like we need to create them in proper place and maybe rename to match global naming ideas of configuration variables. Also there is no need to for two separate configuration variables, since most of page tracking code is javascript and it can determine itself (like google analytics code) if page has been viewed in http:// or https://. Maybe name "cms_DefaultIndexTools" will work out, because we have "IndexTools" field for categories. |
(0001612) Dmitry (manager) 2010-03-15 16:14 |
New patch uploaded and needs testing. Also, will need to add "LA_CONFIG_DEFAULTTRACKINGCODE" new phrase. (Tracking Code) |
(0001677) alex (manager) 2010-03-17 12:32 |
ok |
(0001678) alex (manager) 2010-03-17 12:38 |
Fix committed to 5.0.x branch. Commit Message: 1. Fixes 0000566: Don't include tracking code during site content editing in browse modes 2. Commit on behalf of Dmitry. |
(0001721) alex (manager) 2010-03-22 15:04 |
Patch "analytics_tag_fix.patch" fixes notice about undefined $db_field in PageInfo tag. Before applying Dmitry's patch I changed it a little bit and not completely tested an outcome. Given patch fixes that. |
(0002115) alex (manager) 2010-05-11 02:59 |
Closing all tasks from released versions. |
Related Changesets | |||
In-Portal CMS: 5.0.x r13278 Timestamp: 2010-03-22 15:04:45 Author: alex [ Details ] [ Diff ] |
1. Bug 0000566: Don't include tracking code during site content editing in browse modes 2. Fixed notice about missing $db_field variable. |
||
mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php | [ Diff ] [ File ] | ||
In-Portal CMS: 5.0.x r13261 Timestamp: 2010-03-17 12:38:32 Author: alex [ Details ] [ Diff ] |
1. Fixes 0000566: Don't include tracking code during site content editing in browse modes 2. Commit on behalf of Dmitry. |
||
mod - /in-portal/branches/5.0.x/core/install/install_data.sql | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.0.x/core/install/upgrades.sql | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php | [ Diff ] [ File ] | ||
Issue History | |||
Date Modified | Username | Field | Change |
2010-05-11 02:59 | alex | Note Added: 0002115 | |
2010-05-11 02:59 | alex | Status | resolved => closed |
2010-03-22 15:04 | alex | Changeset attached | 5.0.x r13278 |
2010-03-22 15:04 | alex | Note Added: 0001721 | |
2010-03-22 15:03 | alex | File Added: analytics_tag_fix.patch | |
2010-03-17 12:38 | alex | Note Added: 0001678 | |
2010-03-17 12:38 | alex | Status | reviewed and tested => resolved |
2010-03-17 12:38 | alex | Fixed in Version | => 5.0.3-B1 |
2010-03-17 12:38 | alex | Resolution | open => fixed |
2010-03-17 12:38 | alex | Assigned To | !COMMUNITY => alex |
2010-03-17 12:38 | alex | Changeset attached | 5.0.x r13261 |
2010-03-17 12:32 | alex | Note Added: 0001677 | |
2010-03-17 12:32 | alex | Status | needs testing => reviewed and tested |
2010-03-15 16:14 | Dmitry | Note Added: 0001612 | |
2010-03-15 16:14 | Dmitry | Assigned To | Dmitry => !COMMUNITY |
2010-03-15 16:14 | Dmitry | Status | needs work => needs testing |
2010-03-15 16:13 | Dmitry | File Added: 569-Different_Tag_for_Analytics_Tracking_code-Dmitry-20100315-v2.patch | |
2010-03-15 10:26 | Dmitry | Relationship added | related to 0000049 |
2010-03-11 05:52 | alex | Note Added: 0001551 | |
2010-03-11 05:52 | alex | Assigned To | alex => Dmitry |
2010-03-11 05:52 | alex | Status | needs feedback => needs work |
2010-02-26 16:58 | Dmitry | Note Added: 0001491 | |
2010-02-26 16:58 | Dmitry | Developer | => Dmitry |
2010-02-03 17:14 | Dmitry | Relationship added | related to 0000568 |
2010-02-03 16:46 | Dmitry | Relationship added | related to 0000570 |
2010-02-03 16:44 | Dmitry | Relationship added | related to 0000569 |
2010-02-03 16:44 | Dmitry | Note Added: 0001464 | |
2010-02-03 16:44 | Dmitry | Assigned To | Dmitry => alex |
2010-02-03 16:44 | Dmitry | Status | needs work => needs feedback |
2010-02-03 16:33 | Dmitry | Relationship added | related to 0000567 |
2010-02-03 16:01 | Dmitry | File Added: 566-Dont_include_tracking_code_during_site_content -Dmitry-20100203-v1.patch | |
2010-02-03 16:01 | Dmitry | Assigned To | => Dmitry |
2010-02-03 16:01 | Dmitry | Status | active => needs work |
2010-02-03 13:30 | alex | Reference | http://groups.google.com/group/in-portal-dev/browse_thread/thread/4657b3af9de8f9d8 => http://groups.google.com/group/in-portal-dev/browse_thread/thread/4657b3af9de8f9d8 |
2010-02-03 13:30 | alex | Target Version | => 5.0.3 |
2010-02-03 13:29 | alex | New Issue | |
2010-02-03 13:29 | alex | Reference | => http://groups.google.com/group/in-portal-dev/browse_thread/thread/4657b3af9de8f9d8 |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic In-Portal Open Source CMS |