In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
566 [In-Portal CMS] Front End bug report always 2010-02-03 13:29 2010-05-11 02:59
alex  
alex  
normal  
closed 5.0.2  
fixed  
 
none 5.0.3-B1  
http://groups.google.com/group/in-portal-dev/browse_thread/thread/4657b3af9de8f9d8
0
0000566: Don't include tracking code during site content editing in browse modes
Don't include any kind of page tracking code (e.g. google analytics), when admin is editing site contents (front-end in a frame) so page tracker won't count any fake visits.
related to 0000567closed  (1.0.1)Dmitry Advanced Analytics Tracking code Tag is Missing 
related to 0000568closed  (1.0.1)Dmitry Onlinestore Analytics Tracking code Tag is Missing 
related to 0000049closed  (5.1.0)alex In-Portal CMS Merge ConfigurationAdmin and ConfigurationValues table 
related to 0000569closed  (5.0.1)Dmitry Default Different Tag for Analytics Tracking code 
related to 0000570closed  (1.0.1)Dmitry Simple Different Tag for Analytics Tracking code 
patch 566-Dont_include_tracking_code_during_site_content -Dmitry-20100203-v1.patch (1,101) 2010-02-03 16:01
http://tracker.in-portal.org/file_download.php?file_id=274&type=bug
patch 569-Different_Tag_for_Analytics_Tracking_code-Dmitry-20100315-v2.patch (3,082) 2010-03-15 16:13
http://tracker.in-portal.org/file_download.php?file_id=372&type=bug
patch analytics_tag_fix.patch (460) 2010-03-22 15:03
http://tracker.in-portal.org/file_download.php?file_id=393&type=bug
Issue History
2010-05-11 02:59 alex Note Added: 0002115
2010-05-11 02:59 alex Status resolved => closed
2010-03-22 15:04 alex Changeset attached 5.0.x r13278
2010-03-22 15:04 alex Note Added: 0001721
2010-03-22 15:03 alex File Added: analytics_tag_fix.patch
2010-03-17 12:38 alex Note Added: 0001678
2010-03-17 12:38 alex Status reviewed and tested => resolved
2010-03-17 12:38 alex Fixed in Version => 5.0.3-B1
2010-03-17 12:38 alex Resolution open => fixed
2010-03-17 12:38 alex Assigned To !COMMUNITY => alex
2010-03-17 12:38 alex Changeset attached 5.0.x r13261
2010-03-17 12:32 alex Note Added: 0001677
2010-03-17 12:32 alex Status needs testing => reviewed and tested
2010-03-15 16:14 Dmitry Note Added: 0001612
2010-03-15 16:14 Dmitry Assigned To Dmitry => !COMMUNITY
2010-03-15 16:14 Dmitry Status needs work => needs testing
2010-03-15 16:13 Dmitry File Added: 569-Different_Tag_for_Analytics_Tracking_code-Dmitry-20100315-v2.patch
2010-03-15 10:26 Dmitry Relationship added related to 0000049
2010-03-11 05:52 alex Note Added: 0001551
2010-03-11 05:52 alex Assigned To alex => Dmitry
2010-03-11 05:52 alex Status needs feedback => needs work
2010-02-26 16:58 Dmitry Note Added: 0001491
2010-02-26 16:58 Dmitry Developer => Dmitry
2010-02-03 17:14 Dmitry Relationship added related to 0000568
2010-02-03 16:46 Dmitry Relationship added related to 0000570
2010-02-03 16:44 Dmitry Relationship added related to 0000569
2010-02-03 16:44 Dmitry Note Added: 0001464
2010-02-03 16:44 Dmitry Assigned To Dmitry => alex
2010-02-03 16:44 Dmitry Status needs work => needs feedback
2010-02-03 16:33 Dmitry Relationship added related to 0000567
2010-02-03 16:01 Dmitry File Added: 566-Dont_include_tracking_code_during_site_content -Dmitry-20100203-v1.patch
2010-02-03 16:01 Dmitry Assigned To => Dmitry
2010-02-03 16:01 Dmitry Status active => needs work
2010-02-03 13:30 alex Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/4657b3af9de8f9d8 => http://groups.google.com/group/in-portal-dev/browse_thread/thread/4657b3af9de8f9d8
2010-02-03 13:30 alex Target Version => 5.0.3
2010-02-03 13:29 alex New Issue
2010-02-03 13:29 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/4657b3af9de8f9d8

Notes
(0001464)
Dmitry   
2010-02-03 16:44   
Can't seem to find "cms_DefaultIndextoolsCode_SSL" and "cms_DefaultIndextoolsCode" variables anywhere in install_data.sqls or in my local DB install.

We are referring to them in function PageInfo($params) method.

Did you every saw these things?
(0001491)
Dmitry   
2010-02-26 16:58   
Reminder sent to: alex

Can you please check on this?
(0001551)
alex   
2010-03-11 05:52   
It seems that you don't follow discussion in google groups related to this task. I have posted answer there, because original question is also there and it's just copied as task note.

In any case here is my answer (copied from discussion):
=======================================================
You were right. I've searched through our repository and there never were
such configuration variables like *cms_DefaultIndextoolsCode_SSL* and *
cms_DefaultIndextoolsCode* in any of our projects.

Looks like we need to create them in proper place and maybe rename to match
global naming ideas of configuration variables.

Also there is no need to for two separate configuration variables, since
most of page tracking code is javascript and it can determine itself (like
google analytics code) if page has been viewed in http:// or https://. Maybe
name "cms_DefaultIndexTools" will work out, because we have "IndexTools"
field for categories.
(0001612)
Dmitry   
2010-03-15 16:14   
New patch uploaded and needs testing.

Also, will need to add "LA_CONFIG_DEFAULTTRACKINGCODE" new phrase. (Tracking Code)
(0001677)
alex   
2010-03-17 12:32   
ok
(0001678)
alex   
2010-03-17 12:38   
Fix committed to 5.0.x branch. Commit Message:

1. Fixes 0000566: Don't include tracking code during site content editing in browse modes
2. Commit on behalf of Dmitry.
(0001721)
alex   
2010-03-22 15:04   
Patch "analytics_tag_fix.patch" fixes notice about undefined $db_field in PageInfo tag. Before applying Dmitry's patch I changed it a little bit and not completely tested an outcome. Given patch fixes that.
(0002115)
alex   
2010-05-11 02:59   
Closing all tasks from released versions.