Notes |
|
(0001464)
|
Dmitry
|
2010-02-03 16:44
|
|
Can't seem to find "cms_DefaultIndextoolsCode_SSL" and "cms_DefaultIndextoolsCode" variables anywhere in install_data.sqls or in my local DB install.
We are referring to them in function PageInfo($params) method.
Did you every saw these things? |
|
|
(0001491)
|
Dmitry
|
2010-02-26 16:58
|
|
Reminder sent to: alex Can you please check on this? |
|
|
(0001551)
|
alex
|
2010-03-11 05:52
|
|
It seems that you don't follow discussion in google groups related to this task. I have posted answer there, because original question is also there and it's just copied as task note.
In any case here is my answer (copied from discussion):
=======================================================
You were right. I've searched through our repository and there never were
such configuration variables like *cms_DefaultIndextoolsCode_SSL* and *
cms_DefaultIndextoolsCode* in any of our projects.
Looks like we need to create them in proper place and maybe rename to match
global naming ideas of configuration variables.
Also there is no need to for two separate configuration variables, since
most of page tracking code is javascript and it can determine itself (like
google analytics code) if page has been viewed in http:// or https://. Maybe
name "cms_DefaultIndexTools" will work out, because we have "IndexTools"
field for categories.
|
|
|
(0001612)
|
Dmitry
|
2010-03-15 16:14
|
|
New patch uploaded and needs testing.
Also, will need to add "LA_CONFIG_DEFAULTTRACKINGCODE" new phrase. (Tracking Code) |
|
|
(0001677)
|
alex
|
2010-03-17 12:32
|
|
|
|
(0001678)
|
alex
|
2010-03-17 12:38
|
|
Fix committed to 5.0.x branch. Commit Message:
1. Fixes 0000566: Don't include tracking code during site content editing in browse modes
2. Commit on behalf of Dmitry. |
|
|
(0001721)
|
alex
|
2010-03-22 15:04
|
|
Patch "analytics_tag_fix.patch" fixes notice about undefined $db_field in PageInfo tag. Before applying Dmitry's patch I changed it a little bit and not completely tested an outcome. Given patch fixes that. |
|
|
(0002115)
|
alex
|
2010-05-11 02:59
|
|
Closing all tasks from released versions. |
|