In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000496

[In-Portal CMS] Data Management

bug report

always

2009-12-23 09:46

2010-05-11 03:00

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.0.3-B1

Status

closed

Product Version

5.0.2-B1

Target Version

5.0.3

Time Estimate

No estimate

Summary

0000496: Error in number formatting in case if thousands separator not specified

Description

It appears, that number_format function seems to use "," as thousands separator even in case if thousands separator is not entered in language properties. By inspecting closely I've discovered, that ThousandsSep field in Language table has NULL value in case if empty value is entered in language properties. When NULL is given to number_format function, then is works as "," instead.

To fix this problem I propose to force type convert (to string) both decimal and thousands separator before passing them to number_format function.

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/d056bbfd7c8f6d86#

Change Log Message

Estimate Points

0

thousands_separator_problem.patch [^] (636 bytes) 2009-12-23 09:46 [Show Content]

Index: languages_item.php
===================================================================
--- languages_item.php	(revision 12973)
+++ languages_item.php	(working copy)
@@ -53,7 +53,7 @@
 			if (is_null($precision)) {
 				$precision = preg_match('/[\.,]+/', $number) ? strlen(preg_replace('/^.*[\.,]+/', '', $number)) : 0;
 			}
-			return number_format($number, $precision, $this->GetDBField('DecimalPoint'), $this->GetDBField('ThousandSep'));
+			return number_format($number, $precision, (string)$this->GetDBField('DecimalPoint'), (string)$this->GetDBField('ThousandSep'));
 		}
 
 		function Load($id, $id_field_name=null)

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0001605) Dmitry (manager) 2010-03-15 00:12	This has been tested okay, please commit.

(0001606) alex (manager) 2010-03-15 04:35	Fix committed to 5.0.x branch. Commit Message: Fixes 0000496: Error in number formatting in case if thousands separator not specified

(0002154) alex (manager) 2010-05-11 03:00	Closing all tasks from released versions.

Related Changesets
In-Portal CMS: 5.0.x r13214 Timestamp: 2010-03-15 04:35:25 Author: alex [ Details ] [ Diff ]	Fixes 0000496: Error in number formatting in case if thousands separator not specified
	mod - /in-portal/branches/5.0.x/core/units/languages/languages_item.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-05-11 03:00	alex	Note Added: 0002154
2010-05-11 03:00	alex	Status	resolved => closed
2010-03-15 04:35	alex	Changeset attached	5.0.x r13214
2010-03-15 04:35	alex	Note Added: 0001606
2010-03-15 04:35	alex	Status	reviewed and tested => resolved
2010-03-15 04:35	alex	Fixed in Version	=> 5.0.3-B1
2010-03-15 04:35	alex	Resolution	open => fixed
2010-03-15 04:35	alex	Assigned To	!COMMUNITY => alex
2010-03-15 00:12	Dmitry	Note Added: 0001605
2010-03-15 00:12	Dmitry	Status	needs testing => reviewed and tested
2010-02-26 19:01	Dmitry	Developer	=> alex
2010-01-06 06:17	alex	Target Version	Icebox => 5.0.3
2009-12-23 10:01	alex	Assigned To	=> !COMMUNITY
2009-12-23 10:01	alex	Status	active => needs testing
2009-12-23 09:49	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/d056bbfd7c8f6d86#
2009-12-23 09:49	alex	Target Version	=> Icebox
2009-12-23 09:46	alex	New Issue
2009-12-23 09:46	alex	File Added: thousands_separator_problem.patch

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group