In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
496 [In-Portal CMS] Data Management bug report always 2009-12-23 09:46 2010-05-11 03:00
alex  
alex  
normal  
closed 5.0.2-B1  
fixed  
 
none 5.0.3-B1  
http://groups.google.com/group/in-portal-bugs/browse_thread/thread/d056bbfd7c8f6d86#
0
0000496: Error in number formatting in case if thousands separator not specified
It appears, that number_format function seems to use "," as thousands separator even in case if thousands separator is not entered in language properties. By inspecting closely I've discovered, that ThousandsSep field in Language table has NULL value in case if empty value is entered in language properties. When NULL is given to number_format function, then is works as "," instead.

To fix this problem I propose to force type convert (to string) both decimal and thousands separator before passing them to number_format function.
patch thousands_separator_problem.patch (636) 2009-12-23 09:46
http://tracker.in-portal.org/file_download.php?file_id=188&type=bug
Issue History
2010-05-11 03:00 alex Note Added: 0002154
2010-05-11 03:00 alex Status resolved => closed
2010-03-15 04:35 alex Changeset attached 5.0.x r13214
2010-03-15 04:35 alex Note Added: 0001606
2010-03-15 04:35 alex Status reviewed and tested => resolved
2010-03-15 04:35 alex Fixed in Version => 5.0.3-B1
2010-03-15 04:35 alex Resolution open => fixed
2010-03-15 04:35 alex Assigned To !COMMUNITY => alex
2010-03-15 00:12 Dmitry Note Added: 0001605
2010-03-15 00:12 Dmitry Status needs testing => reviewed and tested
2010-02-26 19:01 Dmitry Developer => alex
2010-01-06 06:17 alex Target Version Icebox => 5.0.3
2009-12-23 10:01 alex Assigned To => !COMMUNITY
2009-12-23 10:01 alex Status active => needs testing
2009-12-23 09:49 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/d056bbfd7c8f6d86#
2009-12-23 09:49 alex Target Version => Icebox
2009-12-23 09:46 alex New Issue
2009-12-23 09:46 alex File Added: thousands_separator_problem.patch

Notes
(0001605)
Dmitry   
2010-03-15 00:12   
This has been tested okay, please commit.
(0001606)
alex   
2010-03-15 04:35   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000496: Error in number formatting in case if thousands separator not specified
(0002154)
alex   
2010-05-11 03:00   
Closing all tasks from released versions.