In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]  [ Related Changesets ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000167 [In-Portal CMS] Optimization task always 2009-08-01 06:39 2010-01-11 22:05
Reporter alex View Status public Project Name In-Portal CMS
Assigned To Dmitry Developer
Priority normal Resolution fixed Fixed in Version 5.0.2-B1
Status closed Product Version 5.0.0 Target Version 5.0.2
Time EstimateNo estimate
Summary 0000167: Remove closing php tags in all files
Description PHP documentation says, that closing php tag ("?>") is not required for files, that contains only php code. Additionally not placing closing php tag at the end of php files prevent user's from accidentally adding new lines after it resulting in inability to properly send headers (like cookies, redirects etc.) during script work.
Additional Information
Tags No tags attached.
Reference
Change Log Message
Estimate Points 0
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
User avatar (0000442)
Dmitry (manager)
2009-09-15 01:14

 This is done but should be double-checked.
User avatar (0000538)
alex (manager)
2009-09-23 13:29

 Only 29 files left with ?> tags at the end, good work.
User avatar (0001025)
Dmitry (manager)
2009-10-30 17:57

 I have only found, fixed and committed 16.

Can you point me in the right direction with where you saw other 13 occurrences?


Thanks.
User avatar (0001027)
alex (manager)
2009-10-31 05:37

 There are 20 files with "?>" tag, but not all of them have it in file end. But files from this folder definitely have it:

/core/editor/editor/filemanager/connectors/php/
User avatar (0001028)
Dmitry (manager)
2009-10-31 13:16

 Are you sure we want to removed them since it's 3rd party software and I don't think we'll be changing it a lot which means it will stay unchanged until the next upgrade of FCK...

Let me know if I still should remove it there.
User avatar (0001029)
alex (manager)
2009-10-31 13:22

 I think, that we should, because when we were replacing include/require to be all with absolute paths, then we fixed fck as well.
User avatar (0001030)
Dmitry (manager)
2009-10-31 15:12

 Fix committed to 5.0.x branch. Commit Message:

Fixes 0000167: Remove closing php tags in all files
User avatar (0001342)
Dmitry (manager)
2010-01-11 22:05

 Closing completed tasks.

- Related Changesets
In-Portal CMS: 5.0.x r12859
Timestamp: 2009-10-31 15:12:31
Author: Dmitry
[ Details ] [ Diff ] 		Fixes 0000167: Remove closing php tags in all files
mod - /in-portal/branches/5.0.x/core/editor/editor/filemanager/connectors/php/basexml.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/editor/editor/filemanager/connectors/php/commands.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/editor/editor/filemanager/connectors/php/config.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/editor/editor/filemanager/connectors/php/connector.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/editor/editor/filemanager/connectors/php/io.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/editor/editor/filemanager/connectors/php/upload.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/editor/editor/filemanager/connectors/php/util.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/tools/show_cache.php [ Diff ] [ File ]
Modules :: In-Commerce: 5.0.x r12852
Timestamp: 2009-10-30 17:56:00
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000167: Remove closing php tags in all files
2. Cleaning ?> at the end of files
mod - /w/in-commerce/branches/5.0.x/in-commerce/install/prerequisites.php [ Diff ] [ File ]
mod - /w/in-commerce/branches/5.0.x/in-commerce/units/currencies/currency_rates.php [ Diff ] [ File ]
mod - /w/in-commerce/branches/5.0.x/in-commerce/units/taxes/taxes_tag_processor.php [ Diff ] [ File ]
Modules :: In-Bulletin: 5.0.x r12851
Timestamp: 2009-10-30 17:55:41
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000167: Remove closing php tags in all files
2. Cleaning ?> at the end of files
mod - /modules/in-bulletin/branches/5.0.x/in-bulletin/install/prerequisites.php [ Diff ] [ File ]
In-Portal CMS: 5.0.x r12849
Timestamp: 2009-10-30 17:54:55
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000167: Remove closing php tags in all files
2. Cleaning ?> at the end of files
mod - /in-portal/branches/5.0.x/core/install/utf.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/install.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/kernel/utility/debugger/debugger_responce.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/kernel/utility/formatters/customfield_formatter.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/general/libchart/classes/libchart.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/general/libchart/classes/view/chart/HorizontalBarChart.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/helpers/mod_rewrite_helper.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/helpers/multilanguage_helper.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/users/users_event_handler.php [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2010-01-11 22:05 Dmitry Note Added: 0001342
2010-01-11 22:05 Dmitry Status resolved => closed
2009-10-31 15:12 Dmitry Note Added: 0001030
2009-10-31 15:12 Dmitry Status needs feedback => resolved
2009-10-31 15:12 Dmitry Fixed in Version => 5.0.2-B1
2009-10-31 15:12 Dmitry Resolution open => fixed
2009-10-31 15:12 Dmitry Changeset attached 5.0.x r12859
2009-10-31 13:22 alex Note Added: 0001029
2009-10-31 13:22 alex Assigned To alex => Dmitry
2009-10-31 13:16 Dmitry Note Added: 0001028
2009-10-31 13:16 Dmitry Assigned To Dmitry => alex
2009-10-31 13:16 Dmitry Status needs work => needs feedback
2009-10-31 05:37 alex Note Added: 0001027
2009-10-31 05:37 alex Assigned To alex => Dmitry
2009-10-31 05:37 alex Status needs feedback => needs work
2009-10-30 17:57 Dmitry Time Estimate Removed 1 =>
2009-10-30 17:57 Dmitry Note Added: 0001025
2009-10-30 17:57 Dmitry Assigned To Dmitry => alex
2009-10-30 17:57 Dmitry Status active => needs feedback
2009-10-30 17:56 Dmitry Changeset attached 5.0.x r12852
2009-10-30 17:55 Dmitry Changeset attached 5.0.x r12851
2009-10-30 17:55 Dmitry Changeset attached 5.0.x r12850
2009-10-30 17:54 Dmitry Changeset attached 5.0.x r12849
2009-10-06 14:25 alex Type bug report => task
2009-10-03 07:53 administrator Status reviewed and tested => active
2009-09-23 13:29 alex Time Estimate Added 1
2009-09-23 13:29 alex Note Added: 0000538
2009-09-20 15:28 alex Target Version 5.1.0 => 5.0.2
2009-09-15 01:14 Dmitry Note Added: 0000442
2009-09-15 01:13 Dmitry Status active => reviewed and tested
2009-09-15 01:13 Dmitry Assigned To => Dmitry
2009-08-01 17:27 Dmitry Target Version => 5.1.0
2009-08-01 06:39 alex New Issue

Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker