In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
167 [In-Portal CMS] Optimization task always 2009-08-01 06:39 2010-01-11 22:05
alex  
Dmitry  
normal  
closed 5.0.0  
fixed  
 
none 5.0.2-B1  
0
0000167: Remove closing php tags in all files
PHP documentation says, that closing php tag ("?>") is not required for files, that contains only php code. Additionally not placing closing php tag at the end of php files prevent user's from accidentally adding new lines after it resulting in inability to properly send headers (like cookies, redirects etc.) during script work.
Issue History
2010-01-11 22:05 Dmitry Note Added: 0001342
2010-01-11 22:05 Dmitry Status resolved => closed
2009-10-31 15:12 Dmitry Note Added: 0001030
2009-10-31 15:12 Dmitry Status needs feedback => resolved
2009-10-31 15:12 Dmitry Fixed in Version => 5.0.2-B1
2009-10-31 15:12 Dmitry Resolution open => fixed
2009-10-31 15:12 Dmitry Changeset attached 5.0.x r12859
2009-10-31 13:22 alex Note Added: 0001029
2009-10-31 13:22 alex Assigned To alex => Dmitry
2009-10-31 13:16 Dmitry Note Added: 0001028
2009-10-31 13:16 Dmitry Assigned To Dmitry => alex
2009-10-31 13:16 Dmitry Status needs work => needs feedback
2009-10-31 05:37 alex Note Added: 0001027
2009-10-31 05:37 alex Assigned To alex => Dmitry
2009-10-31 05:37 alex Status needs feedback => needs work
2009-10-30 17:57 Dmitry Time Estimate Removed 1 =>
2009-10-30 17:57 Dmitry Note Added: 0001025
2009-10-30 17:57 Dmitry Assigned To Dmitry => alex
2009-10-30 17:57 Dmitry Status active => needs feedback
2009-10-30 17:56 Dmitry Changeset attached 5.0.x r12852
2009-10-30 17:55 Dmitry Changeset attached 5.0.x r12851
2009-10-30 17:55 Dmitry Changeset attached 5.0.x r12850
2009-10-30 17:54 Dmitry Changeset attached 5.0.x r12849
2009-10-06 14:25 alex Type bug report => task
2009-10-03 07:53 administrator Status reviewed and tested => active
2009-09-23 13:29 alex Time Estimate Added 1
2009-09-23 13:29 alex Note Added: 0000538
2009-09-20 15:28 alex Target Version 5.1.0 => 5.0.2
2009-09-15 01:14 Dmitry Note Added: 0000442
2009-09-15 01:13 Dmitry Status active => reviewed and tested
2009-09-15 01:13 Dmitry Assigned To => Dmitry
2009-08-01 17:27 Dmitry Target Version => 5.1.0
2009-08-01 06:39 alex New Issue

Notes
(0000442)
Dmitry   
2009-09-15 01:14   
This is done but should be double-checked.
(0000538)
alex   
2009-09-23 13:29   
Only 29 files left with ?> tags at the end, good work.
(0001025)
Dmitry   
2009-10-30 17:57   
I have only found, fixed and committed 16.

Can you point me in the right direction with where you saw other 13 occurrences?


Thanks.
(0001027)
alex   
2009-10-31 05:37   
There are 20 files with "?>" tag, but not all of them have it in file end. But files from this folder definitely have it:

/core/editor/editor/filemanager/connectors/php/
(0001028)
Dmitry   
2009-10-31 13:16   
Are you sure we want to removed them since it's 3rd party software and I don't think we'll be changing it a lot which means it will stay unchanged until the next upgrade of FCK...

Let me know if I still should remove it there.
(0001029)
alex   
2009-10-31 13:22   
I think, that we should, because when we were replacing include/require to be all with absolute paths, then we fixed fck as well.
(0001030)
Dmitry   
2009-10-31 15:12   
Fix committed to 5.0.x branch. Commit Message:

Fixes 0000167: Remove closing php tags in all files
(0001342)
Dmitry   
2010-01-11 22:05   
Closing completed tasks.