Anonymous | Login | Signup for a new account | 2023-06-03 06:14 CDT | ![]() |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0001334 | [In-Portal CMS] Template System | bug report | sometimes | 2012-06-28 05:16 | 2012-07-25 05:29 | ||
Reporter | alex | View Status | public | Project Name | In-Portal CMS | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Fixed in Version | 5.2.0 | ||
Status | closed | Product Version | 5.2.0-B1 | Target Version | 5.2.0 | ||
Time Estimate | No estimate | ||||||
Summary | 0001334: Complete template recompilation fails, when not all modules are installed | ||||||
Description |
In-Portal uses templates (*.tpl files) to separate business logic from website design. When first time accesses a TPL file is compiled into PHP file and then only PHP file is used. This gives amazing performance boost. We are all humans and we can use undefined In-Portal tag or just use In-Portal block tag in wrong way in a template. Under normal conditions the error will only be visible, when template is accessed by end user. But if multiple changes are made and developer haven't property tested them this could result in blank page on customer website, which isn't good. To solve this problem we've added "Recompile Templates" functionality in "System Tools" section in Admin Console. This function basically gathers all templates from Admin Console plus all templates from enabled Front-End themes and runs syntax check on them. If errors were found, then they are displayed all together in a nice report table at the end of a process. This worked nicely from time, when it was developed (before In-Portal 5.0.0 version release), but in 5.2.0-RC1 we've made some changes related to error handling and this affected "Recompile Templates" functionality badly. Now if you have tags in theme, that belongs to a module, that you haven't installed (e.g. download all, but In-Commerce module + "advanced" theme, which has In-Commerce tags in it) then you'll get Fatal Error in the middle of the recompile process. |
||||||
Additional Information | |||||||
Tags | No tags attached. | ||||||
Reference | https://groups.google.com/d/topic/in-portal-bugs/fLypTBBSAfg/discussion | ||||||
Change Log Message | Fixes fatal error on template recompilation | ||||||
Estimate Points | 1 | ||||||
Attached Files |
![]() |
||||||
|
![]() |
||||||
|
![]() |
|
![]() alex (manager) 2012-06-28 05:17 |
Will test all together later. |
![]() alex (manager) 2012-06-28 05:18 |
Fix committed to 5.2.x branch. Commit Message: Fixes 0001334: Complete template recompilation fails, when not all modules are installed |
![]() alex (manager) 2012-07-25 05:29 |
Since 5.2.0 version was released. |
![]() |
|||
In-Portal CMS: 5.2.x r15420 Timestamp: 2012-06-28 05:18:07 Author: alex [ Details ] [ Diff ] |
Fixes 0001334: Complete template recompilation fails, when not all modules are installed | ||
mod - /in-portal/branches/5.2.x/core/admin_templates/tools/compile_complete.tpl | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.2.x/core/kernel/nparser/compiler.php | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.2.x/core/kernel/utility/factory.php | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.2.x/core/units/admin/admin_tag_processor.php | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
2012-07-25 05:29 | alex | Note Added: 0004852 | |
2012-07-25 05:29 | alex | Status | resolved => closed |
2012-07-20 10:30 | alex | Relationship added | related to 0001360 |
2012-06-28 05:18 | alex | Note Added: 0004746 | |
2012-06-28 05:18 | alex | Status | reviewed and tested => resolved |
2012-06-28 05:18 | alex | Fixed in Version | => 5.2.0 |
2012-06-28 05:18 | alex | Resolution | open => fixed |
2012-06-28 05:18 | alex | Assigned To | !COMMUNITY => alex |
2012-06-28 05:18 | alex | Changeset attached | 5.2.x r15420 |
2012-06-28 05:17 | alex | Note Added: 0004745 | |
2012-06-28 05:17 | alex | Status | needs testing => reviewed and tested |
2012-06-28 05:17 | alex | Assigned To | => !COMMUNITY |
2012-06-28 05:17 | alex | Developer | => alex |
2012-06-28 05:17 | alex | Status | active => needs testing |
2012-06-28 05:17 | alex | Reference | => https://groups.google.com/d/topic/in-portal-bugs/fLypTBBSAfg/discussion |
2012-06-28 05:16 | alex | New Issue | |
2012-06-28 05:16 | alex | File Added: error_no_template_recompile_fix.patch | |
2012-06-28 05:16 | alex | Change Log Message | => Fixes fatal error on template recompilation |
2012-06-28 05:16 | alex | Estimate Points | => 1 |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic![]() In-Portal Open Source CMS |