In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1334 [In-Portal CMS] Template System bug report sometimes 2012-06-28 05:16 2012-07-25 05:29
closed 5.2.0-B1  
none 5.2.0
Fixes fatal error on template recompilation
0001334: Complete template recompilation fails, when not all modules are installed
In-Portal uses templates (*.tpl files) to separate business logic from website design.
When first time accesses a TPL file is compiled into PHP file and then only PHP file is used. This gives amazing performance boost.

We are all humans and we can use undefined In-Portal tag or just use In-Portal block tag in wrong way in a template. Under normal conditions the error will only be visible, when template is accessed by end user.
But if multiple changes are made and developer haven't property tested them this could result in blank page on customer website, which isn't good.

To solve this problem we've added "Recompile Templates" functionality in "System Tools" section in Admin Console. This function basically gathers all templates from Admin Console plus all templates from enabled Front-End themes and runs syntax check on them.
If errors were found, then they are displayed all together in a nice report table at the end of a process.

This worked nicely from time, when it was developed (before In-Portal 5.0.0 version release), but in 5.2.0-RC1 we've made some changes related to error handling and this affected "Recompile Templates" functionality badly.
Now if you have tags in theme, that belongs to a module, that you haven't installed (e.g. download all, but In-Commerce module + "advanced" theme, which has In-Commerce tags in it) then you'll get Fatal Error in the middle of the recompile process.
related to 0001360closed  (5.2.0)alex Languages labels & e-mail events of disabled module are visible 
patch error_no_template_recompile_fix.patch (4,274) 2012-06-28 05:16
Issue History
2012-07-25 05:29 alex Note Added: 0004852
2012-07-25 05:29 alex Status resolved => closed
2012-07-20 10:30 alex Relationship added related to 0001360
2012-06-28 05:18 alex Note Added: 0004746
2012-06-28 05:18 alex Status reviewed and tested => resolved
2012-06-28 05:18 alex Fixed in Version => 5.2.0
2012-06-28 05:18 alex Resolution open => fixed
2012-06-28 05:18 alex Assigned To !COMMUNITY => alex
2012-06-28 05:18 alex Changeset attached 5.2.x r15420
2012-06-28 05:17 alex Note Added: 0004745
2012-06-28 05:17 alex Status needs testing => reviewed and tested
2012-06-28 05:17 alex Assigned To => !COMMUNITY
2012-06-28 05:17 alex Developer => alex
2012-06-28 05:17 alex Status active => needs testing
2012-06-28 05:17 alex Reference =>
2012-06-28 05:16 alex New Issue
2012-06-28 05:16 alex File Added: error_no_template_recompile_fix.patch
2012-06-28 05:16 alex Change Log Message => Fixes fatal error on template recompilation
2012-06-28 05:16 alex Estimate Points => 1

2012-06-28 05:17   
Will test all together later.
2012-06-28 05:18   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001334: Complete template recompilation fails, when not all modules are installed
2012-07-25 05:29   
Since 5.2.0 version was released.