Anonymous | Login | Signup for a new account | 2023-09-29 06:04 CDT | ![]() |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0001271 | [In-Portal CMS] Refactoring | task | always | 2012-05-06 06:17 | 2012-07-25 05:30 | ||
Reporter | alex | View Status | public | Project Name | In-Portal CMS | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Fixed in Version | 5.2.0-RC1 | ||
Status | closed | Product Version | 5.2.0-B3 | Target Version | 5.2.0 | ||
Time Estimate | No estimate | ||||||
Summary | 0001271: Sharing code for automatic quantity based phrase label detection | ||||||
Description |
In In-Portal 5.2.0 we introduced page content revision control (see 0001117 task). One of a goals in this task was to display number of other users, who are also editing current page alongside with current user. Warning message would be different based on user count: * 1 user is editing * 2 users are editing * 5 users are editing In English language text (not including number) is the same for 2 and 5 users, but in Russian and most other languages they differ. To display correct words near user count we crated PageHelper::getPluralPhrase method. I think that this method deserve better visibility for developer and I'm proposing to move it (and related methods) to kMultiLanguageHelper class. |
||||||
Additional Information | |||||||
Tags | No tags attached. | ||||||
Reference | https://groups.google.com/d/topic/in-portal-dev/um95YqoqW8c/discussion | ||||||
Change Log Message | Moving getPluralPhrase method to another class for increased visibility | ||||||
Estimate Points | 1 | ||||||
Attached Files |
![]() |
||||||
|
![]() |
|
![]() |
|
![]() alex (manager) 2012-05-06 06:20 |
Will test all later together. |
![]() alex (manager) 2012-05-06 06:21 |
Fix committed to 5.2.x branch. Commit Message: Fixes 0001271: Sharing code for automatic quantity based phrase label detection |
![]() alex (manager) 2012-07-25 05:30 |
Since 5.2.0/1.2.0 versions was released. |
![]() |
|||
In-Portal CMS: 5.2.x r15328 Timestamp: 2012-05-06 06:21:07 Author: alex [ Details ] [ Diff ] |
Fixes 0001271: Sharing code for automatic quantity based phrase label detection | ||
mod - /in-portal/branches/5.2.x/core/units/helpers/multilanguage_helper.php | [ Diff ] [ File ] | ||
mod - /in-portal/branches/5.2.x/core/units/helpers/page_helper.php | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
2012-07-25 05:30 | alex | Note Added: 0004914 | |
2012-07-25 05:30 | alex | Status | resolved => closed |
2012-05-06 06:21 | alex | Note Added: 0004618 | |
2012-05-06 06:21 | alex | Status | reviewed and tested => resolved |
2012-05-06 06:21 | alex | Fixed in Version | => 5.2.0-RC1 |
2012-05-06 06:21 | alex | Resolution | open => fixed |
2012-05-06 06:21 | alex | Assigned To | !COMMUNITY => alex |
2012-05-06 06:21 | alex | Changeset attached | 5.2.x r15328 |
2012-05-06 06:20 | alex | Note Added: 0004617 | |
2012-05-06 06:20 | alex | Status | needs testing => reviewed and tested |
2012-05-06 06:20 | alex | Assigned To | => !COMMUNITY |
2012-05-06 06:20 | alex | Developer | => alex |
2012-05-06 06:20 | alex | Status | active => needs testing |
2012-05-06 06:20 | alex | Reference | => https://groups.google.com/d/topic/in-portal-dev/um95YqoqW8c/discussion |
2012-05-06 06:17 | alex | New Issue | |
2012-05-06 06:17 | alex | File Added: getpluralphrase_method_visibility.patch | |
2012-05-06 06:17 | alex | Change Log Message | => Moving getPluralPhrase method to another class for increased visibility |
2012-05-06 06:17 | alex | Estimate Points | => 1 |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic![]() In-Portal Open Source CMS |