|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
1271 |
[In-Portal CMS] Refactoring |
task |
always |
2012-05-06 06:17 |
2012-07-25 05:30 |
|
|
Reporter:
|
alex |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.2.0-B3 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.2.0-RC1 |
|
|
Reference:
|
https://groups.google.com/d/topic/in-portal-dev/um95YqoqW8c/discussion |
|
Change Log Message:
|
Moving getPluralPhrase method to another class for increased visibility |
|
Estimate Points:
|
1 |
|
|
Summary:
|
0001271: Sharing code for automatic quantity based phrase label detection |
|
Description:
|
In In-Portal 5.2.0 we introduced page content revision control (see 0001117 task).
One of a goals in this task was to display number of other users, who are also editing current page alongside with current user.
Warning message would be different based on user count:
* 1 user is editing
* 2 users are editing
* 5 users are editing
In English language text (not including number) is the same for 2 and 5 users, but in Russian and most other languages they differ.
To display correct words near user count we crated PageHelper::getPluralPhrase method.
I think that this method deserve better visibility for developer and I'm proposing to move it (and related methods) to kMultiLanguageHelper class. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | |
|
Attached Files:
|
 getpluralphrase_method_visibility.patch (3,188) 2012-05-06 06:17
http://tracker.in-portal.org/file_download.php?file_id=1643&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2012-07-25 05:30 |
alex |
Note Added: 0004914 |
|
|
2012-07-25 05:30 |
alex |
Status |
resolved => closed |
|
2012-05-06 06:21 |
alex |
Note Added: 0004618 |
|
|
2012-05-06 06:21 |
alex |
Status |
reviewed and tested => resolved |
|
2012-05-06 06:21 |
alex |
Fixed in Version |
=> 5.2.0-RC1 |
|
2012-05-06 06:21 |
alex |
Resolution |
open => fixed |
|
2012-05-06 06:21 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2012-05-06 06:21 |
alex |
Changeset attached |
5.2.x r15328 |
|
2012-05-06 06:20 |
alex |
Note Added: 0004617 |
|
|
2012-05-06 06:20 |
alex |
Status |
needs testing => reviewed and tested |
|
2012-05-06 06:20 |
alex |
Assigned To |
=> !COMMUNITY |
|
2012-05-06 06:20 |
alex |
Developer |
=> alex |
|
2012-05-06 06:20 |
alex |
Status |
active => needs testing |
|
2012-05-06 06:20 |
alex |
Reference |
=> https://groups.google.com/d/topic/in-portal-dev/um95YqoqW8c/discussion |
|
2012-05-06 06:17 |
alex |
New Issue |
|
|
2012-05-06 06:17 |
alex |
File Added: getpluralphrase_method_visibility.patch |
|
|
2012-05-06 06:17 |
alex |
Change Log Message |
=> Moving getPluralPhrase method to another class for increased visibility |
|
2012-05-06 06:17 |
alex |
Estimate Points |
=> 1 |