In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001093 [In-Portal CMS] Admin Interfaces bug report always 2011-08-08 11:50 2011-09-19 16:08
Reporter erik View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.3
Status closed Product Version 5.1.3-RC1 Target Version 5.1.3
Time EstimateNo estimate
Summary 0001093: Long text are cut in the middle in page content blocks
Description In one project recently revealed the problem - the administrator has entered into CMS-block too long HTML. As a result, HTML was cut up to ~65000 characters, cutted up incorrectly, with a broken tag. Because of this the next time admin try to to open a CMS-block for editing - occurred js-error and the admin could not fix anything.

I propose either
1) change the field type, which stores the text of CMS-block in the database, so there may be placed a longer text (mediumtext or longtext)
or
2) make validation for add/edit CMS-block form, so that in case of field overflow, the validation error prevents incorrect data saving.
Additional Information
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-dev/lQEJy3AGF54/discussion
Change Log Message Fixed error reporting in page content block editing page
Estimate Points 0
Attached Files patch file icon content_block_data_lost.patch [^] (3,866 bytes) 2011-08-08 11:50 [Show Content]
patch file icon content_block_data_lost_v2.patch [^] (3,849 bytes) 2011-08-08 11:56 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0003646)
alex (manager)
2011-08-08 11:51

I've chosen to display proper error message when content is too long.
User avatar (0003647)
alex (manager)
2011-08-08 11:57

Patch "content_block_data_lost_v2.patch" removes required mark set to Content field by accident. Of course content blocks could be empty.
User avatar (0003672)
Dmitry (manager)
2011-08-20 16:26

Moving to 5.1.3 release as per latest conversion in Google gods.
User avatar (0003680)
Dmitry (manager)
2011-08-23 17:38

Any particular reason for "choosing to display proper error message when content is too long."?

I think we might want to have DB change.
User avatar (0003686)
alex (manager)
2011-08-24 02:21

User count, who have their content block content exceed 65K symbols is extremely low and what's why I've helped other users, who create long page content by accident.

I can of course enlarge field in DB if it's needed.
User avatar (0003699)
Dmitry (manager)
2011-08-24 08:11

Thanks explanation. Patch tested successfully - please commit.
User avatar (0003749)
alex (manager)
2011-09-16 09:55

Fix committed to 5.1.x branch. Commit Message:

Fixes 0001093: Long text are cut in the middle in page content blocks
User avatar (0003775)
alex (manager)
2011-09-19 16:08

Closing, since 5.1.3 release has been released.

- Related Changesets
In-Portal CMS: 5.1.x r14526
Timestamp: 2011-09-16 09:55:36
Author: alex
Details ] Diff ]
Fixes 0001093: Long text are cut in the middle in page content blocks
mod - /in-portal/branches/5.1.x/core/admin_templates/categories/edit_content.tpl Diff ] File ]
mod - /in-portal/branches/5.1.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.1.x/core/kernel/db/dbitem.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/content/content_config.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2011-09-19 16:08 alex Note Added: 0003775
2011-09-19 16:08 alex Status resolved => closed
2011-09-16 09:55 alex Note Added: 0003749
2011-09-16 09:55 alex Status reviewed and tested => resolved
2011-09-16 09:55 alex Fixed in Version => 5.1.3
2011-09-16 09:55 alex Resolution open => fixed
2011-09-16 09:55 alex Assigned To !COMMUNITY => alex
2011-09-16 09:55 alex Changeset attached 5.1.x r14526
2011-08-24 08:11 Dmitry Note Added: 0003699
2011-08-24 08:11 Dmitry Status needs testing => reviewed and tested
2011-08-24 02:21 alex Note Added: 0003686
2011-08-24 02:21 alex Assigned To alex => !COMMUNITY
2011-08-24 02:21 alex Status needs feedback => needs testing
2011-08-23 17:38 Dmitry Note Added: 0003680
2011-08-23 17:38 Dmitry Assigned To !COMMUNITY => alex
2011-08-23 17:38 Dmitry Status needs testing => needs feedback
2011-08-20 16:26 Dmitry Note Added: 0003672
2011-08-20 16:26 Dmitry Target Version Icebox => 5.1.3
2011-08-20 16:26 Dmitry Summary Long text are silently cut in the middle in page content blocks => Long text are cut in the middle in page content blocks
2011-08-08 11:57 alex Note Added: 0003647
2011-08-08 11:56 alex File Added: content_block_data_lost_v2.patch
2011-08-08 11:51 alex Note Added: 0003646
2011-08-08 11:51 alex Assigned To => !COMMUNITY
2011-08-08 11:51 alex Developer => alex
2011-08-08 11:51 alex Status active => needs testing
2011-08-08 11:50 alex File Added: content_block_data_lost.patch
2011-08-08 11:50 alex Reporter alex => erik
2011-08-08 11:50 alex New Issue
2011-08-08 11:50 alex Reference => https://groups.google.com/d/topic/in-portal-dev/lQEJy3AGF54/discussion
2011-08-08 11:50 alex Change Log Message => Fixed error reporting in page content block editing page



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker