In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-dev/lQEJy3AGF54/discussion

Change Log Message

Fixed error reporting in page content block editing page

Estimate Points

Attached Files

content_block_data_lost.patch [^] (3,866 bytes) 2011-08-08 11:50 [Show Content]

Index: admin_templates/categories/edit_content.tpl
===================================================================
--- admin_templates/categories/edit_content.tpl	(revision 14472)
+++ admin_templates/categories/edit_content.tpl	(working copy)
@@ -51,6 +51,9 @@
 </tbody>
 </table>
 
+<inp2:content_SaveWarning name="grid_save_warning"/>
+<inp2:content_ErrorWarning name="form_error_warning"/>
+
 <div id="scroll_container">
 	<table class="edit-form" style="border-collapse: separate;">
 		<tr>
@@ -62,8 +65,15 @@
 				</inp2:m_if>
 
 				<script type="text/javascript">
+					if (typeof(fields['content']) == 'undefined') {
+						fields['content'] = new Object();
+					}
+					fields['content']['Content'] = '<inp2:m_phrase label="la_fld_ContentBlock" js_escape="1"/>';
+
 					Form.addControl('<inp2:content_InputName field="Content"/>___Frame');
 				</script>
+
+				<inp2:m_RenderElement name="inp_edit_error" prefix="content" field="Content"/>
 			</td>
 		</tr>
 	</table>
Index: install/english.lang
===================================================================
--- install/english.lang	(revision 14472)
+++ install/english.lang	(working copy)
@@ -422,6 +422,7 @@
 			<PHRASE Label="la_fld_Comments" Module="Core" Type="1">Q29tbWVudHM=</PHRASE>
 			<PHRASE Label="la_fld_Company" Module="Core" Type="1">Q29tcGFueQ==</PHRASE>
 			<PHRASE Label="la_fld_ConfigHeader" Module="Core" Type="1">Q29uZmlndXJhdGlvbiBIZWFkZXIgTGFiZWw=</PHRASE>
+			<PHRASE Label="la_fld_ContentBlock" Module="Core" Type="1">Q29udGVudCBCbG9jaw==</PHRASE>
 			<PHRASE Label="la_fld_CopyLabels" Module="Core" Type="1">Q29weSBMYWJlbHMgZnJvbSB0aGlzIExhbmd1YWdl</PHRASE>
 			<PHRASE Label="la_fld_Country" Module="Core" Type="1">Q291bnRyeQ==</PHRASE>
 			<PHRASE Label="la_fld_CreatedById" Module="Core" Type="1">Q3JlYXRlZCBCeQ==</PHRASE>
Index: kernel/db/dbitem.php
===================================================================
--- kernel/db/dbitem.php	(revision 14472)
+++ kernel/db/dbitem.php	(working copy)
@@ -722,7 +722,7 @@
 				$res = $f($val) && ($val == $this->FieldValues[$field]);
 			}
 			if (!$res) {
-				$this->SetError($field, 'bad_type', null, $params['type']);
+				$this->SetError($field, 'bad_type', null, Array ($params['type']));
 			}
 		}
 		return $res;
@@ -846,7 +846,7 @@
 			$res = $res && mb_strlen($val) >= $params['min_len'];
 		}
 		if (!$res) {
-			$error_params = Array (getArrayValue($params, 'min_len'), getArrayValue($params, 'max_len'));
+			$error_params = Array (getArrayValue($params, 'min_len'), getArrayValue($params, 'max_len'), mb_strlen($val));
 			$this->SetError($field, 'length_out_of_range', null, $error_params);
 			return $res;
 		}
Index: units/content/content_config.php
===================================================================
--- units/content/content_config.php	(revision 14472)
+++ units/content/content_config.php	(working copy)
@@ -36,8 +36,8 @@
 		'AutoDelete' => true,
 		'AutoClone' => true,
 
-		'TitleField' => 'ContentNum',		// field, used in bluebar when editing existing item		
-		
+		'TitleField' => 'ContentNum',		// field, used in bluebar when editing existing item
+
 		'TitlePresets' => Array (
 			'default' => Array (
 				'new_status_labels' => Array ('content' => '!la_title_Adding_Content!'),
@@ -59,7 +59,11 @@
 			'PageContentId' => Array ('type' => 'int', 'not_null' => 1, 'default' => 0),
 			'ContentNum' => Array ('type' => 'int', 'not_null' => 1, 'default' => 0),
 			'PageId' => Array ('type' => 'int', 'not_null' => 1, 'default' => 0),
-			'Content' => Array ('type' => 'string', 'formatter' => 'kMultiLanguage', 'using_fck' => 1, 'default' => ''),
+			'Content' => Array (
+				'type' => 'string', 'min_len' => 0, 'max_len' => 65536,
+				'formatter' => 'kMultiLanguage', 'using_fck' => 1,
+				'required' => 1, 'default' => ''
+			),
 		),
 
 	);

content_block_data_lost_v2.patch [^] (3,849 bytes) 2011-08-08 11:56 [Show Content]

Index: admin_templates/categories/edit_content.tpl
===================================================================
--- admin_templates/categories/edit_content.tpl	(revision 14472)
+++ admin_templates/categories/edit_content.tpl	(working copy)
@@ -51,6 +51,9 @@
 </tbody>
 </table>
 
+<inp2:content_SaveWarning name="grid_save_warning"/>
+<inp2:content_ErrorWarning name="form_error_warning"/>
+
 <div id="scroll_container">
 	<table class="edit-form" style="border-collapse: separate;">
 		<tr>
@@ -62,8 +65,15 @@
 				</inp2:m_if>
 
 				<script type="text/javascript">
+					if (typeof(fields['content']) == 'undefined') {
+						fields['content'] = new Object();
+					}
+					fields['content']['Content'] = '<inp2:m_phrase label="la_fld_ContentBlock" js_escape="1"/>';
+
 					Form.addControl('<inp2:content_InputName field="Content"/>___Frame');
 				</script>
+
+				<inp2:m_RenderElement name="inp_edit_error" prefix="content" field="Content"/>
 			</td>
 		</tr>
 	</table>
Index: install/english.lang
===================================================================
--- install/english.lang	(revision 14472)
+++ install/english.lang	(working copy)
@@ -422,6 +422,7 @@
 			<PHRASE Label="la_fld_Comments" Module="Core" Type="1">Q29tbWVudHM=</PHRASE>
 			<PHRASE Label="la_fld_Company" Module="Core" Type="1">Q29tcGFueQ==</PHRASE>
 			<PHRASE Label="la_fld_ConfigHeader" Module="Core" Type="1">Q29uZmlndXJhdGlvbiBIZWFkZXIgTGFiZWw=</PHRASE>
+			<PHRASE Label="la_fld_ContentBlock" Module="Core" Type="1">Q29udGVudCBCbG9jaw==</PHRASE>
 			<PHRASE Label="la_fld_CopyLabels" Module="Core" Type="1">Q29weSBMYWJlbHMgZnJvbSB0aGlzIExhbmd1YWdl</PHRASE>
 			<PHRASE Label="la_fld_Country" Module="Core" Type="1">Q291bnRyeQ==</PHRASE>
 			<PHRASE Label="la_fld_CreatedById" Module="Core" Type="1">Q3JlYXRlZCBCeQ==</PHRASE>
Index: kernel/db/dbitem.php
===================================================================
--- kernel/db/dbitem.php	(revision 14472)
+++ kernel/db/dbitem.php	(working copy)
@@ -722,7 +722,7 @@
 				$res = $f($val) && ($val == $this->FieldValues[$field]);
 			}
 			if (!$res) {
-				$this->SetError($field, 'bad_type', null, $params['type']);
+				$this->SetError($field, 'bad_type', null, Array ($params['type']));
 			}
 		}
 		return $res;
@@ -846,7 +846,7 @@
 			$res = $res && mb_strlen($val) >= $params['min_len'];
 		}
 		if (!$res) {
-			$error_params = Array (getArrayValue($params, 'min_len'), getArrayValue($params, 'max_len'));
+			$error_params = Array (getArrayValue($params, 'min_len'), getArrayValue($params, 'max_len'), mb_strlen($val));
 			$this->SetError($field, 'length_out_of_range', null, $error_params);
 			return $res;
 		}
Index: units/content/content_config.php
===================================================================
--- units/content/content_config.php	(revision 14472)
+++ units/content/content_config.php	(working copy)
@@ -36,8 +36,8 @@
 		'AutoDelete' => true,
 		'AutoClone' => true,
 
-		'TitleField' => 'ContentNum',		// field, used in bluebar when editing existing item		
-		
+		'TitleField' => 'ContentNum',		// field, used in bluebar when editing existing item
+
 		'TitlePresets' => Array (
 			'default' => Array (
 				'new_status_labels' => Array ('content' => '!la_title_Adding_Content!'),
@@ -59,7 +59,11 @@
 			'PageContentId' => Array ('type' => 'int', 'not_null' => 1, 'default' => 0),
 			'ContentNum' => Array ('type' => 'int', 'not_null' => 1, 'default' => 0),
 			'PageId' => Array ('type' => 'int', 'not_null' => 1, 'default' => 0),
-			'Content' => Array ('type' => 'string', 'formatter' => 'kMultiLanguage', 'using_fck' => 1, 'default' => ''),
+			'Content' => Array (
+				'type' => 'string', 'min_len' => 0, 'max_len' => 65536,
+				'formatter' => 'kMultiLanguage', 'using_fck' => 1,
+				'default' => ''
+			),
 		),
 
 	);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003646) alex (manager) 2011-08-08 11:51	I've chosen to display proper error message when content is too long.

(0003647) alex (manager) 2011-08-08 11:57	Patch "content_block_data_lost_v2.patch" removes required mark set to Content field by accident. Of course content blocks could be empty.

(0003672) Dmitry (manager) 2011-08-20 16:26	Moving to 5.1.3 release as per latest conversion in Google gods.

(0003680) Dmitry (manager) 2011-08-23 17:38	Any particular reason for "choosing to display proper error message when content is too long."? I think we might want to have DB change.

(0003686) alex (manager) 2011-08-24 02:21	User count, who have their content block content exceed 65K symbols is extremely low and what's why I've helped other users, who create long page content by accident. I can of course enlarge field in DB if it's needed.

(0003699) Dmitry (manager) 2011-08-24 08:11	Thanks explanation. Patch tested successfully - please commit.

(0003749) alex (manager) 2011-09-16 09:55	Fix committed to 5.1.x branch. Commit Message: Fixes 0001093: Long text are cut in the middle in page content blocks

(0003775) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14526 Timestamp: 2011-09-16 09:55:36 Author: alex [ Details ] [ Diff ]	Fixes 0001093: Long text are cut in the middle in page content blocks
	mod - /in-portal/branches/5.1.x/core/admin_templates/categories/edit_content.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/install/english.lang	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/kernel/db/dbitem.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/units/content/content_config.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003775
2011-09-19 16:08	alex	Status	resolved => closed
2011-09-16 09:55	alex	Note Added: 0003749
2011-09-16 09:55	alex	Status	reviewed and tested => resolved
2011-09-16 09:55	alex	Fixed in Version	=> 5.1.3
2011-09-16 09:55	alex	Resolution	open => fixed
2011-09-16 09:55	alex	Assigned To	!COMMUNITY => alex
2011-09-16 09:55	alex	Changeset attached	5.1.x r14526
2011-08-24 08:11	Dmitry	Note Added: 0003699
2011-08-24 08:11	Dmitry	Status	needs testing => reviewed and tested
2011-08-24 02:21	alex	Note Added: 0003686
2011-08-24 02:21	alex	Assigned To	alex => !COMMUNITY
2011-08-24 02:21	alex	Status	needs feedback => needs testing
2011-08-23 17:38	Dmitry	Note Added: 0003680
2011-08-23 17:38	Dmitry	Assigned To	!COMMUNITY => alex
2011-08-23 17:38	Dmitry	Status	needs testing => needs feedback
2011-08-20 16:26	Dmitry	Note Added: 0003672
2011-08-20 16:26	Dmitry	Target Version	Icebox => 5.1.3
2011-08-20 16:26	Dmitry	Summary	Long text are silently cut in the middle in page content blocks => Long text are cut in the middle in page content blocks
2011-08-08 11:57	alex	Note Added: 0003647
2011-08-08 11:56	alex	File Added: content_block_data_lost_v2.patch
2011-08-08 11:51	alex	Note Added: 0003646
2011-08-08 11:51	alex	Assigned To	=> !COMMUNITY
2011-08-08 11:51	alex	Developer	=> alex
2011-08-08 11:51	alex	Status	active => needs testing
2011-08-08 11:50	alex	File Added: content_block_data_lost.patch
2011-08-08 11:50	alex	Reporter	alex => erik
2011-08-08 11:50	alex	New Issue
2011-08-08 11:50	alex	Reference	=> https://groups.google.com/d/topic/in-portal-dev/lQEJy3AGF54/discussion
2011-08-08 11:50	alex	Change Log Message	=> Fixed error reporting in page content block editing page

Web Development by Intechnic

In-Portal Open Source CMS