|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
1093 |
[In-Portal CMS] Admin Interfaces |
bug report |
always |
2011-08-08 11:50 |
2011-09-19 16:08 |
|
|
Reporter:
|
erik |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.1.3-RC1 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.1.3 |
|
|
Reference:
|
https://groups.google.com/d/topic/in-portal-dev/lQEJy3AGF54/discussion |
|
Change Log Message:
|
Fixed error reporting in page content block editing page |
|
Estimate Points:
|
0 |
|
|
Summary:
|
0001093: Long text are cut in the middle in page content blocks |
|
Description:
|
In one project recently revealed the problem - the administrator has entered into CMS-block too long HTML. As a result, HTML was cut up to ~65000 characters, cutted up incorrectly, with a broken tag. Because of this the next time admin try to to open a CMS-block for editing - occurred js-error and the admin could not fix anything.
I propose either
1) change the field type, which stores the text of CMS-block in the database, so there may be placed a longer text (mediumtext or longtext)
or
2) make validation for add/edit CMS-block form, so that in case of field overflow, the validation error prevents incorrect data saving. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | |
|
Attached Files:
|
 content_block_data_lost.patch (3,866) 2011-08-08 11:50
http://tracker.in-portal.org/file_download.php?file_id=1093&type=bug
content_block_data_lost_v2.patch (3,849) 2011-08-08 11:56
http://tracker.in-portal.org/file_download.php?file_id=1094&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2011-09-19 16:08 |
alex |
Note Added: 0003775 |
|
|
2011-09-19 16:08 |
alex |
Status |
resolved => closed |
|
2011-09-16 09:55 |
alex |
Note Added: 0003749 |
|
|
2011-09-16 09:55 |
alex |
Status |
reviewed and tested => resolved |
|
2011-09-16 09:55 |
alex |
Fixed in Version |
=> 5.1.3 |
|
2011-09-16 09:55 |
alex |
Resolution |
open => fixed |
|
2011-09-16 09:55 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2011-09-16 09:55 |
alex |
Changeset attached |
5.1.x r14526 |
|
2011-08-24 08:11 |
Dmitry |
Note Added: 0003699 |
|
|
2011-08-24 08:11 |
Dmitry |
Status |
needs testing => reviewed and tested |
|
2011-08-24 02:21 |
alex |
Note Added: 0003686 |
|
|
2011-08-24 02:21 |
alex |
Assigned To |
alex => !COMMUNITY |
|
2011-08-24 02:21 |
alex |
Status |
needs feedback => needs testing |
|
2011-08-23 17:38 |
Dmitry |
Note Added: 0003680 |
|
|
2011-08-23 17:38 |
Dmitry |
Assigned To |
!COMMUNITY => alex |
|
2011-08-23 17:38 |
Dmitry |
Status |
needs testing => needs feedback |
|
2011-08-20 16:26 |
Dmitry |
Note Added: 0003672 |
|
|
2011-08-20 16:26 |
Dmitry |
Target Version |
Icebox => 5.1.3 |
|
2011-08-20 16:26 |
Dmitry |
Summary |
Long text are silently cut in the middle in page content blocks => Long text are cut in the middle in page content blocks |
|
2011-08-08 11:57 |
alex |
Note Added: 0003647 |
|
|
2011-08-08 11:56 |
alex |
File Added: content_block_data_lost_v2.patch |
|
|
2011-08-08 11:51 |
alex |
Note Added: 0003646 |
|
|
2011-08-08 11:51 |
alex |
Assigned To |
=> !COMMUNITY |
|
2011-08-08 11:51 |
alex |
Developer |
=> alex |
|
2011-08-08 11:51 |
alex |
Status |
active => needs testing |
|
2011-08-08 11:50 |
alex |
File Added: content_block_data_lost.patch |
|
|
2011-08-08 11:50 |
alex |
Reporter |
alex => erik |
|
2011-08-08 11:50 |
alex |
New Issue |
|
|
2011-08-08 11:50 |
alex |
Reference |
=> https://groups.google.com/d/topic/in-portal-dev/lQEJy3AGF54/discussion |
|
2011-08-08 11:50 |
alex |
Change Log Message |
=> Fixed error reporting in page content block editing page |
|
Notes |
|
|
(0003646)
|
|
alex
|
|
2011-08-08 11:51
|
|
|
I've chosen to display proper error message when content is too long. |
|
|
|
(0003647)
|
|
alex
|
|
2011-08-08 11:57
|
|
|
Patch "content_block_data_lost_v2.patch" removes required mark set to Content field by accident. Of course content blocks could be empty. |
|
|
|
(0003672)
|
|
Dmitry
|
|
2011-08-20 16:26
|
|
|
Moving to 5.1.3 release as per latest conversion in Google gods. |
|
|
|
(0003680)
|
|
Dmitry
|
|
2011-08-23 17:38
|
|
Any particular reason for "choosing to display proper error message when content is too long."?
I think we might want to have DB change. |
|
|
|
(0003686)
|
|
alex
|
|
2011-08-24 02:21
|
|
User count, who have their content block content exceed 65K symbols is extremely low and what's why I've helped other users, who create long page content by accident.
I can of course enlarge field in DB if it's needed. |
|
|
|
(0003699)
|
|
Dmitry
|
|
2011-08-24 08:11
|
|
|
Thanks explanation. Patch tested successfully - please commit. |
|
|
|
(0003749)
|
|
alex
|
|
2011-09-16 09:55
|
|
Fix committed to 5.1.x branch. Commit Message:
Fixes 0001093: Long text are cut in the middle in page content blocks |
|
|
|
(0003775)
|
|
alex
|
|
2011-09-19 16:08
|
|
|
Closing, since 5.1.3 release has been released. |
|