In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

View Revisions: Issue #69 [ All Revisions ] [ Back to Issue ]
Summary 0000069: Issues with "MoreLink" tag and "Data_Exists" param
Revision 2009-06-12 13:07:33 by Dmitry
Additional Information Need to Review ALL other places potentially affected by data_exists="1" parameter passed when NOT needed.


Proposed fix (diff):

function MoreLink($params)
    {
        $per_page = $this->SelectParam($params, 'per_page,max_items');
        if ($per_page !== false) $params['per_page'] = $per_page;
        $list =& $this->GetList($params);

        if ($list->PerPage < $list->RecordsCount) {
            $block_params = array();
            $block_params['name'] = $this->SelectParam($params, 'render_as,block');
            - return $this->Application->ParseBlock($block_params, 1);
            + return $this->Application->ParseBlock($block_params);
        }
    }
Revision 2009-06-12 13:06:49 by Dmitry
Additional Information Need to Review ALL other places potentially affected by data_exists="1" parameter passed when NOT needed.


Proposed fix (diff):

function MoreLink($params)
    {
        $per_page = $this->SelectParam($params, 'per_page,max_items');
        if ($per_page !== false) $params['per_page'] = $per_page;
        $list =& $this->GetList($params);

        if ($list->PerPage < $list->RecordsCount) {
            $block_params = array();
            $block_params['name'] = $this->SelectParam($params, 'render_as,block');
            - return $this->Application->ParseBlock($block_params, 1);
            + return $this->Application->ParseBlock($block_params);
        }
    }
Revision 2009-06-12 12:58:47 by Dmitry
Additional Information Need to Review ALL other places potentially affected by data_exists="1" parameter passed when NOT needed.


Proposed fix (diff):

[CODE]
function MoreLink($params)
    {
        $per_page = $this->SelectParam($params, 'per_page,max_items');
        if ($per_page !== false) $params['per_page'] = $per_page;
        $list =& $this->GetList($params);

        if ($list->PerPage < $list->RecordsCount) {
            $block_params = array();
            $block_params['name'] = $this->SelectParam($params, 'render_as,block');
            - return $this->Application->ParseBlock($block_params, 1);
            + return $this->Application->ParseBlock($block_params);
        }
    }
[/CODE]
Revision 2009-06-12 12:58:18 by Dmitry
Additional Information Need to Review ALL other places potentially affected by data_exists="1" parameter passed when NOT needed.


Proposed fix (diff):

[CODE]
function MoreLink($params)
    {
        $per_page = $this->SelectParam($params, 'per_page,max_items');
        if ($per_page !== false) $params['per_page'] = $per_page;
        $list =& $this->GetList($params);

        if ($list->PerPage < $list->RecordsCount) {
            $block_params = array();
            $block_params['name'] = $this->SelectParam($params, 'render_as,block');
            - return $this->Application->ParseBlock($block_params, 1);
            + return $this->Application->ParseBlock($block_params);
        }
    }
[/CODE]

Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker