Anonymous | Login | Signup for a new account | 2024-05-14 03:49 CDT |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
View Revisions: Issue #69 | [ Back to Issue ] | ||
Summary | 0000069: Issues with "MoreLink" tag and "Data_Exists" param | ||
Revision | 2009-06-12 13:07:33 by Dmitry | ||
Additional Information | Need to Review ALL other places potentially affected by data_exists="1" parameter passed when NOT needed. Proposed fix (diff): function MoreLink($params) { $per_page = $this->SelectParam($params, 'per_page,max_items'); if ($per_page !== false) $params['per_page'] = $per_page; $list =& $this->GetList($params); if ($list->PerPage < $list->RecordsCount) { $block_params = array(); $block_params['name'] = $this->SelectParam($params, 'render_as,block'); - return $this->Application->ParseBlock($block_params, 1); + return $this->Application->ParseBlock($block_params); } } |
||
Revision | 2009-06-12 13:07:06 by Dmitry | ||
Description | MoreLink tag is NOT displayed when needed. Came across this problem in Default2007 and Default2009 themes where <inp2:l_MoreLink render_as="more_link"/> tag (in Short Search Results template) is used inside of RenderElement with data_exists="1" parameter which gets passed through to MoreLink parameters. Due to specifics of Template Parser the output is getting excluded when NO "field" tag used in the actual RenderElement (in our case "more_link"). All this leads to More Link not to be shown when needed. |
||
Revision | 2009-06-12 13:06:49 by Dmitry | ||
Additional Information | Need to Review ALL other places potentially affected by data_exists="1" parameter passed when NOT needed. Proposed fix (diff): function MoreLink($params) { $per_page = $this->SelectParam($params, 'per_page,max_items'); if ($per_page !== false) $params['per_page'] = $per_page; $list =& $this->GetList($params); if ($list->PerPage < $list->RecordsCount) { $block_params = array(); $block_params['name'] = $this->SelectParam($params, 'render_as,block'); - return $this->Application->ParseBlock($block_params, 1); + return $this->Application->ParseBlock($block_params); } } |
||
Revision | 2009-06-12 13:06:49 by Dmitry | ||
Description | MoreLink tag is NOT displayed when needed. Came across this problem in Default2007 and Default2009 themes where <inp2:l_MoreLink render_as="more_link"/> tag (in Short Search Results template) is used inside of RenderElement with data_exists="1" parameter which gets passed through to MoreLink parameters. Due to specifics of Template Parser the output is getting excluded when NO "field" tag used in the actual RenderElement (in our case "more_link"). All this leads to More Link not to be shown when needed. |
||
Revision | 2009-06-12 12:58:47 by Dmitry | ||
Description | MoreLink tag is NOT displayed when needed. Came across this problem in Default2007 and Default2009 themes where [CODE]<inp2:l_MoreLink render_as="more_link"/>[/CODE] tag (in Short Search Results template) is used inside of RenderElement with data_exists="1" parameter which gets passed through to MoreLink parameters. Due to specifics of Template Parser the output is getting excluded when NO "field" tag used in the actual RenderElement (in our case "more_link"). All this leads to More Link not to be shown when needed. |
||
Revision | 2009-06-12 12:58:47 by Dmitry | ||
Additional Information | Need to Review ALL other places potentially affected by data_exists="1" parameter passed when NOT needed. Proposed fix (diff): [CODE] function MoreLink($params) { $per_page = $this->SelectParam($params, 'per_page,max_items'); if ($per_page !== false) $params['per_page'] = $per_page; $list =& $this->GetList($params); if ($list->PerPage < $list->RecordsCount) { $block_params = array(); $block_params['name'] = $this->SelectParam($params, 'render_as,block'); - return $this->Application->ParseBlock($block_params, 1); + return $this->Application->ParseBlock($block_params); } } [/CODE] |
||
Revision | 2009-06-12 12:58:18 by Dmitry | ||
Additional Information | Need to Review ALL other places potentially affected by data_exists="1" parameter passed when NOT needed. Proposed fix (diff): [CODE] function MoreLink($params) { $per_page = $this->SelectParam($params, 'per_page,max_items'); if ($per_page !== false) $params['per_page'] = $per_page; $list =& $this->GetList($params); if ($list->PerPage < $list->RecordsCount) { $block_params = array(); $block_params['name'] = $this->SelectParam($params, 'render_as,block'); - return $this->Application->ParseBlock($block_params, 1); + return $this->Application->ParseBlock($block_params); } } [/CODE] |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic In-Portal Open Source CMS |