In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

Change Log Message

Estimate Points

Attached Files

parse_block_fix.patch [^] (10,746 bytes) 2010-03-11 10:24 [Show Content]

Index: core/kernel/db/cat_tag_processor.php
===================================================================
--- core/kernel/db/cat_tag_processor.php	(revision 13203)
+++ core/kernel/db/cat_tag_processor.php	(working copy)
@@ -226,7 +226,7 @@
 				$params['grid_name'] .= 'ShowAll';
 			}
 
-			return $this->Application->ParseBlock($params, 1);
+			return $this->Application->ParseBlock($params);
 		}
 
 		/**
Index: core/kernel/db/db_tag_processor.php
===================================================================
--- core/kernel/db/db_tag_processor.php	(revision 13203)
+++ core/kernel/db/db_tag_processor.php	(working copy)
@@ -534,7 +534,7 @@
 				// record in this iteration is first in row, then open row
 				$column_number = 1;
 				$o.= $block_start_row_params['name'] ?
-						$this->Application->ParseBlock($block_start_row_params, 1) :
+						$this->Application->ParseBlock($block_start_row_params) :
 						(!isset($params['no_table']) ? '<tr>' : '');
 			}
 			else {
@@ -548,19 +548,19 @@
 			$block_params['num'] = ($i+1);
 
 			$this->PrepareListElementParams($list, $block_params); // new, no need to rewrite PrintList
-			$o.= $this->Application->ParseBlock($block_params, 1);
+			$o.= $this->Application->ParseBlock($block_params);
 			array_push($displayed, $list->GetDBField($id_field));
 
 			if($direction == 'V' && $list->SelectedCount % $columns > 0 && $column_number == ($columns - 1) && ceil(($i + 1) / $columns) > $list->SelectedCount % ceil($list->SelectedCount / $columns)) {
 				// if vertical output, then draw empty cells vertically, not horizontally
-				$o .= $block_empty_cell_params['name'] ? $this->Application->ParseBlock($block_empty_cell_params, 1) : '<td>&nbsp;</td>';
+				$o .= $block_empty_cell_params['name'] ? $this->Application->ParseBlock($block_empty_cell_params) : '<td>&nbsp;</td>';
 				$i++;
 			}
 
 			if (($i + 1) % $columns == 0) {
 				// record in next iteration is first in row too, then close this row
 				$o.= $block_end_row_params['name'] ?
-						$this->Application->ParseBlock($block_end_row_params, 1) :
+						$this->Application->ParseBlock($block_end_row_params) :
 						(!isset($params['no_table']) ? '</tr>' : '');
 			}
 
@@ -571,11 +571,11 @@
 		// append empty cells in place of missing cells in last row
 		while ($i % $columns != 0) {
 			// until next cell will be in new row append empty cells
-			$o .= $block_empty_cell_params['name'] ? $this->Application->ParseBlock($block_empty_cell_params, 1) : '<td>&nbsp;</td>';
+			$o .= $block_empty_cell_params['name'] ? $this->Application->ParseBlock($block_empty_cell_params) : '<td>&nbsp;</td>';
 
 			if (($i+1) % $columns == 0) {
 				// record in next iteration is first in row too, then close this row
-				$o .= $block_end_row_params['name'] ? $this->Application->ParseBlock($block_end_row_params, 1) : '</tr>';
+				$o .= $block_end_row_params['name'] ? $this->Application->ParseBlock($block_end_row_params) : '</tr>';
 			}
 			$i++;
 		}
@@ -948,7 +948,7 @@
 				$block_params['key'] = $key;
 				$block_params['option'] = $val;
 				$block_params[$selected_param_name] = ( in_array($key, $value) ? ' '.$selected : '');
-				$o .= $this->Application->ParseBlock($block_params, 1);
+				$o .= $this->Application->ParseBlock($block_params);
 			}
 		}
 		else {
@@ -957,7 +957,7 @@
 				$block_params['key'] = $key;
 				$block_params['option'] = $val;
 				$block_params[$selected_param_name] = (strlen($key) == strlen($value) && ($key == $value) ? ' '.$selected : '');
-				$o .= $this->Application->ParseBlock($block_params, 1);
+				$o .= $this->Application->ParseBlock($block_params);
 			}
 		}
 		return $o;
@@ -1093,7 +1093,7 @@
 				$prev_block_params['page'] = max($current_page-$split, 1);
 				$prev_block_params['name'] = $this->SelectParam($params, 'prev_page_split_render_as,prev_page_split_block');
 				if ($prev_block_params['name']){
-					$o .= $this->Application->ParseBlock($prev_block_params, 1);
+					$o .= $this->Application->ParseBlock($prev_block_params);
 				}
 			}
 
@@ -1102,13 +1102,13 @@
 			$prev_block_params['name'] = $this->SelectParam($params, 'prev_page_render_as,block_prev_page,prev_page_block');
 			if ($prev_block_params['name']) {
 				$this->Application->SetVar($this->getPrefixSpecial().'_Page', $current_page-1);
-				$o .= $this->Application->ParseBlock($prev_block_params, 1);
+				$o .= $this->Application->ParseBlock($prev_block_params);
 			}
 		}
 		else {
 			if ( $no_prev_page_block = $this->SelectParam($params, 'no_prev_page_render_as,block_no_prev_page') ) {
 				$block_params['name'] = $no_prev_page_block;
-				$o .= $this->Application->ParseBlock($block_params, 1);
+				$o .= $this->Application->ParseBlock($block_params);
 			}
 		}
 
@@ -1125,12 +1125,12 @@
 			$block_params['name'] = $block;
 			$block_params['page'] = $i;
 			$this->Application->SetVar($this->getPrefixSpecial().'_Page', $i);
-			$o .= $this->Application->ParseBlock($block_params, 1);
+			$o .= $this->Application->ParseBlock($block_params);
 
 			if ($this->SelectParam($params, 'separator_render_as,block_separator')
 				&& $i < $split_end)
 			{
-				$o .= $this->Application->ParseBlock($separator_params, 1);
+				$o .= $this->Application->ParseBlock($separator_params);
 			}
 		}
 
@@ -1140,20 +1140,20 @@
 			$next_block_params['name'] = $this->SelectParam($params, 'next_page_render_as,block_next_page,next_page_block');
 			if ($next_block_params['name']){
 				$this->Application->SetVar($this->getPrefixSpecial().'_Page', $current_page+1);
-				$o .= $this->Application->ParseBlock($next_block_params, 1);
+				$o .= $this->Application->ParseBlock($next_block_params);
 			}
 			if ($total_pages > $split){
 				$next_block_params['page']=min($current_page+$split, $total_pages);
 				$next_block_params['name'] = $this->SelectParam($params, 'next_page_split_render_as,next_page_split_block');
 				if ($next_block_params['name']){
-					$o .= $this->Application->ParseBlock($next_block_params, 1);
+					$o .= $this->Application->ParseBlock($next_block_params);
 				}
 			}
 		}
 		else {
 			if ( $no_next_page_block = $this->SelectParam($params, 'no_next_page_render_as,block_no_next_page') ) {
 				$block_params['name'] = $no_next_page_block;
-				$o .= $this->Application->ParseBlock($block_params, 1);
+				$o .= $this->Application->ParseBlock($block_params);
 			}
 		}
 
@@ -1781,7 +1781,8 @@
 			default:
 				break;
 		}
-		return $this->Application->ParseBlock($params, 1);
+
+		return $this->Application->ParseBlock($params);
 	}
 
 	/**
Index: core/kernel/processors/main_processor.php
===================================================================
--- core/kernel/processors/main_processor.php	(revision 13203)
+++ core/kernel/processors/main_processor.php	(working copy)
@@ -685,7 +685,7 @@
 			$block_params['passed'] = $params['passed'];
 			$block_params['prefix'] = 'm';
 
-			$o.= $this->Application->ParseBlock($block_params, 1);
+			$o.= $this->Application->ParseBlock($block_params);
 		}
 		return $o;
 	}*/
Index: core/units/categories/categories_tag_processor.php
===================================================================
--- core/units/categories/categories_tag_processor.php	(revision 13203)
+++ core/units/categories/categories_tag_processor.php	(working copy)
@@ -655,7 +655,7 @@
 
 		$params['name'] = $params['render_as'];
 		$params['skip_prefixes'] = implode(',', $skip_prefixes);
-		return $this->Application->ParseBlock($params, 1);
+		return $this->Application->ParseBlock($params);
 	}
 
 	/**
@@ -1002,7 +1002,7 @@
 			$params['grid_name'] .= 'ShowAll';
 		}
 
-		return $this->Application->ParseBlock($params, 1);
+		return $this->Application->ParseBlock($params);
 	}
 
 	/**
@@ -1596,7 +1596,7 @@
 
 		while (!$list->EOL()) {
 			$block_params['path'] = $list->GetDBField('Path');
-			$o .= $this->Application->ParseBlock($block_params, 1);
+			$o .= $this->Application->ParseBlock($block_params);
 
 			$list->GoNext();
 		}
Index: core/units/config_search/config_search_tag_processor.php
===================================================================
--- core/units/config_search/config_search_tag_processor.php	(revision 13203)
+++ core/units/config_search/config_search_tag_processor.php	(working copy)
@@ -44,7 +44,7 @@
 				$this->Application->SetVar( $this->getPrefixSpecial().'_id', $list->GetDBField($id_field) ); // for edit/delete links using GET
 				$block_params['show_heading'] = ($prev_heading != $list->GetDBField('ConfigHeader') ) ? 1 : 0;
 
-				$o.= $this->Application->ParseBlock($block_params, 1);
+				$o.= $this->Application->ParseBlock($block_params);
 				$prev_heading = $list->GetDBField('ConfigHeader');
 				$list->GoNext();
 			}
Index: core/units/configuration/configuration_tag_processor.php
===================================================================
--- core/units/configuration/configuration_tag_processor.php	(revision 13203)
+++ core/units/configuration/configuration_tag_processor.php	(working copy)
@@ -75,7 +75,7 @@
 			}
 			$list->SetDBField('DirectOptions', '');
 
-			$o.= $this->Application->ParseBlock($block_params, 1);
+			$o.= $this->Application->ParseBlock($block_params);
 			$prev_heading = $list->GetDBField('heading');
 			$list->GoNext();
 		}
@@ -123,7 +123,7 @@
 		$block_params['module_item'] = $this->getModuleItemName();
 		$list->GoFirst();
 
-		return $this->Application->ParseBlock($block_params, 1);
+		return $this->Application->ParseBlock($block_params);
 
 	}
 
Index: core/units/custom_fields/custom_fields_tag_processor.php
===================================================================
--- core/units/custom_fields/custom_fields_tag_processor.php	(revision 13203)
+++ core/units/custom_fields/custom_fields_tag_processor.php	(working copy)
@@ -123,7 +123,7 @@
 					$list->SetDBField('DirectOptions', isset($options['options']) ? $options['options'] : false);
 				}
 
-				$o.= $this->Application->ParseBlock($block_params, 1);
+				$o.= $this->Application->ParseBlock($block_params);
 				$prev_heading = $list->GetDBField('Heading');
 				$list->GoNext();
 				$i++;
Index: core/units/reviews/reviews_tag_processor.php
===================================================================
--- core/units/reviews/reviews_tag_processor.php	(revision 13203)
+++ core/units/reviews/reviews_tag_processor.php	(working copy)
@@ -132,7 +132,7 @@
 		$params['show_category'] = $tab_params['special'] == 'showall' ? 1 : 0; // this is advanced view -> show category name
 		$params['tab_name'] = $this->Application->GetVar('tab_name');
 
-		return $this->Application->ParseBlock($params, 1);
+		return $this->Application->ParseBlock($params);
 	}
 
 	/**

parse_block_fix_v2.patch [^] (11,106 bytes) 2010-03-17 06:16 [Show Content]

Index: core/kernel/db/cat_tag_processor.php
===================================================================
--- core/kernel/db/cat_tag_processor.php	(revision 13241)
+++ core/kernel/db/cat_tag_processor.php	(working copy)
@@ -226,6 +226,7 @@
 				$params['grid_name'] .= 'ShowAll';
 			}
 
+			// use $pass_params to be able to pass 'tab_init' parameter from m_ModuleInclude tag
 			return $this->Application->ParseBlock($params, 1);
 		}
 
Index: core/kernel/db/db_tag_processor.php
===================================================================
--- core/kernel/db/db_tag_processor.php	(revision 13243)
+++ core/kernel/db/db_tag_processor.php	(working copy)
@@ -534,7 +534,7 @@
 				// record in this iteration is first in row, then open row
 				$column_number = 1;
 				$o.= $block_start_row_params['name'] ?
-						$this->Application->ParseBlock($block_start_row_params, 1) :
+						$this->Application->ParseBlock($block_start_row_params) :
 						(!isset($params['no_table']) ? '<tr>' : '');
 			}
 			else {
@@ -548,19 +548,19 @@
 			$block_params['num'] = ($i+1);
 
 			$this->PrepareListElementParams($list, $block_params); // new, no need to rewrite PrintList
-			$o.= $this->Application->ParseBlock($block_params, 1);
+			$o.= $this->Application->ParseBlock($block_params);
 			array_push($displayed, $list->GetDBField($id_field));
 
 			if($direction == 'V' && $list->SelectedCount % $columns > 0 && $column_number == ($columns - 1) && ceil(($i + 1) / $columns) > $list->SelectedCount % ceil($list->SelectedCount / $columns)) {
 				// if vertical output, then draw empty cells vertically, not horizontally
-				$o .= $block_empty_cell_params['name'] ? $this->Application->ParseBlock($block_empty_cell_params, 1) : '<td>&nbsp;</td>';
+				$o .= $block_empty_cell_params['name'] ? $this->Application->ParseBlock($block_empty_cell_params) : '<td>&nbsp;</td>';
 				$i++;
 			}
 
 			if (($i + 1) % $columns == 0) {
 				// record in next iteration is first in row too, then close this row
 				$o.= $block_end_row_params['name'] ?
-						$this->Application->ParseBlock($block_end_row_params, 1) :
+						$this->Application->ParseBlock($block_end_row_params) :
 						(!isset($params['no_table']) ? '</tr>' : '');
 			}
 
@@ -571,11 +571,11 @@
 		// append empty cells in place of missing cells in last row
 		while ($i % $columns != 0) {
 			// until next cell will be in new row append empty cells
-			$o .= $block_empty_cell_params['name'] ? $this->Application->ParseBlock($block_empty_cell_params, 1) : '<td>&nbsp;</td>';
+			$o .= $block_empty_cell_params['name'] ? $this->Application->ParseBlock($block_empty_cell_params) : '<td>&nbsp;</td>';
 
 			if (($i+1) % $columns == 0) {
 				// record in next iteration is first in row too, then close this row
-				$o .= $block_end_row_params['name'] ? $this->Application->ParseBlock($block_end_row_params, 1) : '</tr>';
+				$o .= $block_end_row_params['name'] ? $this->Application->ParseBlock($block_end_row_params) : '</tr>';
 			}
 			$i++;
 		}
@@ -961,7 +961,7 @@
 				$block_params['key'] = $key;
 				$block_params['option'] = $val;
 				$block_params[$selected_param_name] = ( in_array($key, $value) ? ' '.$selected : '');
-				$o .= $this->Application->ParseBlock($block_params, 1);
+				$o .= $this->Application->ParseBlock($block_params);
 			}
 		}
 		else {
@@ -970,7 +970,7 @@
 				$block_params['key'] = $key;
 				$block_params['option'] = $val;
 				$block_params[$selected_param_name] = (strlen($key) == strlen($value) && ($key == $value) ? ' '.$selected : '');
-				$o .= $this->Application->ParseBlock($block_params, 1);
+				$o .= $this->Application->ParseBlock($block_params);
 			}
 		}
 		return $o;
@@ -1106,7 +1106,7 @@
 				$prev_block_params['page'] = max($current_page-$split, 1);
 				$prev_block_params['name'] = $this->SelectParam($params, 'prev_page_split_render_as,prev_page_split_block');
 				if ($prev_block_params['name']){
-					$o .= $this->Application->ParseBlock($prev_block_params, 1);
+					$o .= $this->Application->ParseBlock($prev_block_params);
 				}
 			}
 
@@ -1115,13 +1115,13 @@
 			$prev_block_params['name'] = $this->SelectParam($params, 'prev_page_render_as,block_prev_page,prev_page_block');
 			if ($prev_block_params['name']) {
 				$this->Application->SetVar($this->getPrefixSpecial().'_Page', $current_page-1);
-				$o .= $this->Application->ParseBlock($prev_block_params, 1);
+				$o .= $this->Application->ParseBlock($prev_block_params);
 			}
 		}
 		else {
 			if ( $no_prev_page_block = $this->SelectParam($params, 'no_prev_page_render_as,block_no_prev_page') ) {
 				$block_params['name'] = $no_prev_page_block;
-				$o .= $this->Application->ParseBlock($block_params, 1);
+				$o .= $this->Application->ParseBlock($block_params);
 			}
 		}
 
@@ -1138,12 +1138,12 @@
 			$block_params['name'] = $block;
 			$block_params['page'] = $i;
 			$this->Application->SetVar($this->getPrefixSpecial().'_Page', $i);
-			$o .= $this->Application->ParseBlock($block_params, 1);
+			$o .= $this->Application->ParseBlock($block_params);
 
 			if ($this->SelectParam($params, 'separator_render_as,block_separator')
 				&& $i < $split_end)
 			{
-				$o .= $this->Application->ParseBlock($separator_params, 1);
+				$o .= $this->Application->ParseBlock($separator_params);
 			}
 		}
 
@@ -1153,20 +1153,20 @@
 			$next_block_params['name'] = $this->SelectParam($params, 'next_page_render_as,block_next_page,next_page_block');
 			if ($next_block_params['name']){
 				$this->Application->SetVar($this->getPrefixSpecial().'_Page', $current_page+1);
-				$o .= $this->Application->ParseBlock($next_block_params, 1);
+				$o .= $this->Application->ParseBlock($next_block_params);
 			}
 			if ($total_pages > $split){
 				$next_block_params['page']=min($current_page+$split, $total_pages);
 				$next_block_params['name'] = $this->SelectParam($params, 'next_page_split_render_as,next_page_split_block');
 				if ($next_block_params['name']){
-					$o .= $this->Application->ParseBlock($next_block_params, 1);
+					$o .= $this->Application->ParseBlock($next_block_params);
 				}
 			}
 		}
 		else {
 			if ( $no_next_page_block = $this->SelectParam($params, 'no_next_page_render_as,block_no_next_page') ) {
 				$block_params['name'] = $no_next_page_block;
-				$o .= $this->Application->ParseBlock($block_params, 1);
+				$o .= $this->Application->ParseBlock($block_params);
 			}
 		}
 
@@ -1794,6 +1794,8 @@
 			default:
 				break;
 		}
+
+		// use $pass_params to pass 'SourcePrefix' parameter from PrintList to CustomInputName tag
 		return $this->Application->ParseBlock($params, 1);
 	}
 
@@ -2141,7 +2143,7 @@
 		if (array_key_exists('as_url', $params) && $params['as_url']) {
 			$path = str_replace( FULL_PATH . '/', $this->Application->BaseURL(), $path);
 		}
-			
+
 		return $path . $filename;
 	}
 
Index: core/kernel/processors/main_processor.php
===================================================================
--- core/kernel/processors/main_processor.php	(revision 13241)
+++ core/kernel/processors/main_processor.php	(working copy)
@@ -685,7 +685,7 @@
 			$block_params['passed'] = $params['passed'];
 			$block_params['prefix'] = 'm';
 
-			$o.= $this->Application->ParseBlock($block_params, 1);
+			$o.= $this->Application->ParseBlock($block_params);
 		}
 		return $o;
 	}*/
Index: core/units/categories/categories_tag_processor.php
===================================================================
--- core/units/categories/categories_tag_processor.php	(revision 13241)
+++ core/units/categories/categories_tag_processor.php	(working copy)
@@ -655,7 +655,7 @@
 
 		$params['name'] = $params['render_as'];
 		$params['skip_prefixes'] = implode(',', $skip_prefixes);
-		return $this->Application->ParseBlock($params, 1);
+		return $this->Application->ParseBlock($params);
 	}
 
 	/**
@@ -1002,6 +1002,7 @@
 			$params['grid_name'] .= 'ShowAll';
 		}
 
+		// use $pass_params to be able to pass 'tab_init' parameter from m_ModuleInclude tag
 		return $this->Application->ParseBlock($params, 1);
 	}
 
@@ -1596,7 +1597,7 @@
 
 		while (!$list->EOL()) {
 			$block_params['path'] = $list->GetDBField('Path');
-			$o .= $this->Application->ParseBlock($block_params, 1);
+			$o .= $this->Application->ParseBlock($block_params);
 
 			$list->GoNext();
 		}
Index: core/units/config_search/config_search_tag_processor.php
===================================================================
--- core/units/config_search/config_search_tag_processor.php	(revision 13241)
+++ core/units/config_search/config_search_tag_processor.php	(working copy)
@@ -44,7 +44,7 @@
 				$this->Application->SetVar( $this->getPrefixSpecial().'_id', $list->GetDBField($id_field) ); // for edit/delete links using GET
 				$block_params['show_heading'] = ($prev_heading != $list->GetDBField('ConfigHeader') ) ? 1 : 0;
 
-				$o.= $this->Application->ParseBlock($block_params, 1);
+				$o.= $this->Application->ParseBlock($block_params);
 				$prev_heading = $list->GetDBField('ConfigHeader');
 				$list->GoNext();
 			}
Index: core/units/configuration/configuration_tag_processor.php
===================================================================
--- core/units/configuration/configuration_tag_processor.php	(revision 13241)
+++ core/units/configuration/configuration_tag_processor.php	(working copy)
@@ -75,7 +75,7 @@
 			}
 			$list->SetDBField('DirectOptions', '');
 
-			$o.= $this->Application->ParseBlock($block_params, 1);
+			$o.= $this->Application->ParseBlock($block_params);
 			$prev_heading = $list->GetDBField('heading');
 			$list->GoNext();
 		}
@@ -123,7 +123,7 @@
 		$block_params['module_item'] = $this->getModuleItemName();
 		$list->GoFirst();
 
-		return $this->Application->ParseBlock($block_params, 1);
+		return $this->Application->ParseBlock($block_params);
 
 	}
 
Index: core/units/custom_fields/custom_fields_tag_processor.php
===================================================================
--- core/units/custom_fields/custom_fields_tag_processor.php	(revision 13241)
+++ core/units/custom_fields/custom_fields_tag_processor.php	(working copy)
@@ -123,7 +123,7 @@
 					$list->SetDBField('DirectOptions', isset($options['options']) ? $options['options'] : false);
 				}
 
-				$o.= $this->Application->ParseBlock($block_params, 1);
+				$o.= $this->Application->ParseBlock($block_params);
 				$prev_heading = $list->GetDBField('Heading');
 				$list->GoNext();
 				$i++;
Index: in-commerce/units/orders/orders_tag_processor.php
===================================================================
--- in-commerce/units/orders/orders_tag_processor.php	(revision 13241)
+++ in-commerce/units/orders/orders_tag_processor.php	(working copy)
@@ -1393,6 +1393,7 @@
 			$params['tab_dependant'] = $tab_params['dependant'];
 			$params['show_category'] = $tab_params['special'] == 'showall' ? 1 : 0; // this is advanced view -> show category name
 
+			// use $pass_params to be able to pass 'tab_init' parameter from m_ModuleInclude tag
 			return $this->Application->ParseBlock($params, 1);
 		}

broken_pagination_fix.patch [^] (859 bytes) 2010-03-27 18:37 [Show Content]

Index: kernel/db/db_tag_processor.php
===================================================================
--- kernel/db/db_tag_processor.php	(revision 13311)
+++ kernel/db/db_tag_processor.php	(working copy)
@@ -1100,7 +1100,7 @@
 		}
 
 		if ($current_page > 1){
-			$prev_block_params = $this->prepareTagParams();
+			$prev_block_params = $this->prepareTagParams($params);
 
 			if ($total_pages > $split){
 				$prev_block_params['page'] = max($current_page-$split, 1);
@@ -1148,7 +1148,7 @@
 		}
 
 		if ($current_page < $total_pages){
-			$next_block_params = $this->prepareTagParams();
+			$next_block_params = $this->prepareTagParams($params);
 			$next_block_params['page']=$current_page+1;
 			$next_block_params['name'] = $this->SelectParam($params, 'next_page_render_as,block_next_page,next_page_block');
 			if ($next_block_params['name']){

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0000220) Dmitry (manager) 2009-08-03 15:38	Moved to 5.1.x releases.

(0000529) alex (manager) 2009-09-23 13:13	Plan: 1. search for all calls of kApplication::ParseBlock method with second parameter passed. 2. for each found case try to remove 2-nd parameter and see how related functionality will react. Usually $pass_params (2nd parameter) is not required because $block_params (1st parameter) already contains $params (main tag params, who called ParseBlock) added via $block_params = $this->prepareTagParams($params); call.

(0000825) alex (manager) 2009-10-06 13:49	Moving to 5.0.3 because of too much work.

(0001562) alex (manager) 2010-03-11 09:56 edited on: 2010-03-11 10:04	1. Method kTagProcessor::processTagParams is used to pass, parameters given to the tag to kApplication::ParseBlock it calls from inside (like kDBTagProcessor::PrintList2 tag does). 2. $pass_params parameter of ParseBlock passes all parameters, from current deep level, like all parameters on current template or all parameters given to DefineElement, where our tag is located. Our problem is with data_exists parameter, which is not passed directly to sub tags, but which is available globally, when $pass_params parameter of ParseBlock method is used.

(0001563) alex (manager) 2010-03-11 10:26	Here is the patch, but it seems to have strange effect on "Comments" (Reviews) grid in admin - shows plain template from ajax response. Please test all changed tags. On non-ajax grids and even in catalog all seems to work, but comments section seems to be broken.

(0001566) Dmitry (manager) 2010-03-11 23:37	Reminder sent to: alex Are we talking about regular Comments of Category Items? I also have Comments for Polls... Thanks will test soon.

(0001577) alex (manager) 2010-03-12 02:58	I specifically wrote that it's comments, that are former reviews section. Please read carefully next time.

(0001652) Dmitry (manager) 2010-03-15 19:13	Tested Okay everywhere but Comments as you pointed out.

(0001674) alex (manager) 2010-03-17 06:17	Several more issues found, that you haven't discovered during testing: 1. comments (reviews) grid was not working 2. catalog/advanced view was not working also 3. user editing (general tab) also gives fatal error Please test all cases this time. Also descriptive comments added to places, where $pass_params are used, so we don't accidentally remove them later.

(0001685) Dmitry (manager) 2010-03-18 14:36	Tested okay! Review all places and basic others.

(0001711) alex (manager) 2010-03-20 14:41	Fix committed to 5.0.x branch. Commit Message: Fixes 0000069: Issues with "MoreLink" tag and "Data_Exists" param

(0001752) alex (manager) 2010-03-27 18:22	When editing a language, previous/next/last/first buttons (in pagination bar) doesn't work, because they miss 1 parameter in the JS: example for going to page number 2 buttons uses javascript:go_to_page('phrases', 2, ) page numbers uses javascript:go_to_page('phrases', 2, 0)

(0001753) alex (manager) 2010-03-27 18:23	Time to fix

(0001754) alex (manager) 2010-03-27 18:37	Need to test "broken_pagination_fix.patch" patch only. See previous comment to understand what to test.

(0001798) Dmitry (manager) 2010-04-05 21:50	Tested good!

(0001801) alex (manager) 2010-04-06 02:58	Fix committed to 5.0.x branch. Commit Message: Fixes 0000069: Issues with "MoreLink" tag and "Data_Exists" param

(0002105) alex (manager) 2010-05-11 02:59	Closing all tasks from released versions.

Related Changesets
In-Portal CMS: 5.0.x r13332 Timestamp: 2010-04-06 02:58:55 Author: alex [ Details ] [ Diff ]	Fixes 0000069: Issues with "MoreLink" tag and "Data_Exists" param
	mod - /in-portal/branches/5.0.x/core/kernel/db/db_tag_processor.php	[ Diff ] [ File ]

Modules :: In-Commerce: 5.0.x r13273 Timestamp: 2010-03-21 04:00:28 Author: alex [ Details ] [ Diff ]	Bug 0000069: Issues with "MoreLink" tag and "Data_Exists" param
	mod - /w/in-commerce/branches/5.0.x/units/orders/orders_tag_processor.php	[ Diff ] [ File ]

In-Portal CMS: 5.0.x r13272 Timestamp: 2010-03-20 14:41:06 Author: alex [ Details ] [ Diff ]	Fixes 0000069: Issues with "MoreLink" tag and "Data_Exists" param
	mod - /in-portal/branches/5.0.x/core/kernel/db/cat_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/kernel/db/db_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/kernel/processors/main_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/units/categories/categories_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/units/config_search/config_search_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/units/configuration/configuration_tag_processor.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.0.x/core/units/custom_fields/custom_fields_tag_processor.php	[ Diff ] [ File ]

In-Portal CMS: RC r11851 Timestamp: 2009-06-12 13:32:44 Author: alex [ Details ] [ Diff ]	Bug 0000069: Issues with "MoreLink" tag and "Data_Exists" param
	mod - /in-portal/branches/RC/core/kernel/db/db_tag_processor.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-05-11 02:59	alex	Note Added: 0002105
2010-05-11 02:59	alex	Status	resolved => closed
2010-04-06 02:58	alex	Note Added: 0001801
2010-04-06 02:58	alex	Status	reviewed and tested => resolved
2010-04-06 02:58	alex	Fixed in Version	5.0.3-B1 => 5.0.3-B2
2010-04-06 02:58	alex	Resolution	reopened => fixed
2010-04-06 02:58	alex	Assigned To	!COMMUNITY => alex
2010-04-06 02:58	alex	Changeset attached	5.0.x r13332
2010-04-05 21:50	Dmitry	Note Added: 0001798
2010-04-05 21:50	Dmitry	Status	needs testing => reviewed and tested
2010-03-27 18:37	alex	Note Added: 0001754
2010-03-27 18:37	alex	Assigned To	alex => !COMMUNITY
2010-03-27 18:37	alex	Status	needs work => needs testing
2010-03-27 18:37	alex	File Added: broken_pagination_fix.patch
2010-03-27 18:23	alex	Note Added: 0001753
2010-03-27 18:23	alex	Status	needs feedback => needs work
2010-03-27 18:22	alex	Note Added: 0001752
2010-03-27 18:22	alex	Status	resolved => needs feedback
2010-03-27 18:22	alex	Resolution	fixed => reopened
2010-03-21 04:00	alex	Changeset attached	5.0.x r13273
2010-03-20 14:41	alex	Changeset attached	5.0.x r13272
2010-03-20 14:41	alex	Note Added: 0001711
2010-03-20 14:41	alex	Status	reviewed and tested => resolved
2010-03-20 14:41	alex	Fixed in Version	=> 5.0.3-B1
2010-03-20 14:41	alex	Resolution	open => fixed
2010-03-20 14:41	alex	Assigned To	!COMMUNITY => alex
2010-03-18 14:36	Dmitry	Note Added: 0001685
2010-03-18 14:36	Dmitry	Status	needs testing => reviewed and tested
2010-03-17 06:17	alex	Note Added: 0001674
2010-03-17 06:17	alex	Assigned To	alex => !COMMUNITY
2010-03-17 06:17	alex	Status	needs work => needs testing
2010-03-17 06:16	alex	File Added: parse_block_fix_v2.patch
2010-03-15 19:13	Dmitry	Note Added: 0001652
2010-03-15 19:13	Dmitry	Assigned To	!COMMUNITY => alex
2010-03-15 19:13	Dmitry	Status	needs testing => needs work
2010-03-12 02:58	alex	Note Added: 0001577
2010-03-11 23:37	Dmitry	Issue Monitored: alex
2010-03-11 23:37	Dmitry	Note Added: 0001566
2010-03-11 10:26	alex	Time Estimate Removed	4 =>
2010-03-11 10:26	alex	Note Added: 0001563
2010-03-11 10:26	alex	Assigned To	alex => !COMMUNITY
2010-03-11 10:26	alex	Developer	=> alex
2010-03-11 10:26	alex	Status	active => needs testing
2010-03-11 10:24	alex	File Added: parse_block_fix.patch
2010-03-11 10:04	alex	Note Edited: 0001562	View Revisions
2010-03-11 09:56	alex	Note Added: 0001562
2009-10-06 13:49	alex	Note Added: 0000825
2009-10-06 13:49	alex	Target Version	5.0.2 => 5.0.3
2009-10-05 16:28	Dmitry	Assigned To	Dmitry => alex
2009-10-03 07:53	administrator	Status	reviewed and tested => active
2009-09-23 13:13	alex	Time Estimate Added	4
2009-09-23 13:13	alex	Note Added: 0000529
2009-09-20 15:11	alex	Target Version	5.1.0 => 5.0.2
2009-08-03 15:38	Dmitry	Note Added: 0000220
2009-08-03 15:38	Dmitry	Assigned To	=> Dmitry
2009-08-03 15:38	Dmitry	Status	active => reviewed and tested
2009-08-03 15:38	Dmitry	Target Version	5.0.1 => 5.1.0
2009-06-12 13:33	alex	Changeset attached	RC r11851
2009-06-12 13:07	Dmitry	Additional Information Updated	View Revisions
2009-06-12 13:07	Dmitry	Description Updated	View Revisions
2009-06-12 13:06	Dmitry	Description Updated	View Revisions
2009-06-12 13:06	Dmitry	Additional Information Updated	View Revisions
2009-06-12 12:58	Dmitry	Additional Information Updated	View Revisions
2009-06-12 12:56	Dmitry	Summary	Issues with "MoreLink" tag => Issues with "MoreLink" tag and "Data_Exists" param
2009-06-12 12:55	Dmitry	New Issue

Web Development by Intechnic

In-Portal Open Source CMS