In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000976

[In-Portal CMS] Admin Interfaces

bug report

always

2011-01-25 04:55

2011-03-30 09:53

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.2-B2

Status

closed

Product Version

5.1.2-B1

Target Version

5.1.2

Time Estimate

No estimate

Summary

0000976: Block "grid_picker_filter" incorrectly defines filter type resulting warning, when in use

Description

In-Portal uses advanced data filtering system, where developer can define filter type that will be used for each field being displayed in grid.

For example "grid_options_filter" block will produce SQL like FieldName = ID1, when in used. On the other hand block "grid_picker_filter" will produce SQL like FieldName LIKE '%|ID1|%' when used.

I've noticed, that when "grid_picker_filter" block is used, then I've got warning what it 'options' type filter is undefined for that field. That's obviously is a copy-paste error, since that filter was copied from "grid_options_filter" at some point of development.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/yOaMpeVAUXk/discussion

Change Log Message

Fixed warning, when "grid_picker_filter" is used

Estimate Points

0

warning_when_picker_filter_is_in_use.patch [^] (738 bytes) 2011-01-25 04:55 [Show Content]

Index: grid_blocks.tpl
===================================================================
--- grid_blocks.tpl	(revision 14184)
+++ grid_blocks.tpl	(working copy)
@@ -321,7 +321,7 @@
 
 <inp2:m_DefineElement name="grid_picker_filter" use_phrases="0" filter_width="90%">
 		<select
-			class="filter <inp2:m_ifnot check='SearchField' field='$filter_field' filter_type='options' grid='$grid' equals_to=''>filter-active</inp2:m_ifnot>"
+			class="filter <inp2:m_ifnot check='SearchField' field='$filter_field' filter_type='picker' grid='$grid' equals_to=''>filter-active</inp2:m_ifnot>"
 			name="<inp2:SearchInputName field="$filter_field" filter_type="picker" grid="$grid"/>"
 			style="width: <inp2:m_Param name="filter_width"/>">

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003213) Dmitry (manager) 2011-01-25 22:22	Reviewed and tested okay.

(0003251) Dmitry (manager) 2011-02-15 09:44	Moved to 5.1.2.

(0003260) alex (manager) 2011-02-15 10:56	Fix committed to 5.1.x branch. Commit Message: Fixes 0000976: Block "grid_picker_filter" incorrectly defines filter type resulting warning, when in use

(0003329) Dmitry (manager) 2011-03-30 09:53	Closing, since 5.1.2 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14200 Timestamp: 2011-02-15 10:56:58 Author: alex [ Details ] [ Diff ]	Fixes 0000976: Block "grid_picker_filter" incorrectly defines filter type resulting warning, when in use
	mod - /in-portal/branches/5.1.x/core/admin_templates/incs/grid_blocks.tpl		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-03-30 09:53	Dmitry	Note Added: 0003329
2011-03-30 09:53	Dmitry	Status	resolved => closed
2011-02-15 10:56	alex	Note Added: 0003260
2011-02-15 10:56	alex	Status	reviewed and tested => resolved
2011-02-15 10:56	alex	Fixed in Version	=> 5.1.2-B2
2011-02-15 10:56	alex	Resolution	open => fixed
2011-02-15 10:56	alex	Assigned To	!COMMUNITY => alex
2011-02-15 10:56	alex	Changeset attached	5.1.x r14200
2011-02-15 09:44	Dmitry	Note Added: 0003251
2011-02-15 09:44	Dmitry	Target Version	Icebox => 5.1.2
2011-01-25 22:22	Dmitry	Note Added: 0003213
2011-01-25 22:22	Dmitry	Status	needs testing => reviewed and tested
2011-01-25 04:56	alex	Assigned To	=> !COMMUNITY
2011-01-25 04:56	alex	Developer	=> alex
2011-01-25 04:56	alex	Status	active => needs testing
2011-01-25 04:56	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/yOaMpeVAUXk/discussion
2011-01-25 04:55	alex	New Issue
2011-01-25 04:55	alex	File Added: warning_when_picker_filter_is_in_use.patch
2011-01-25 04:55	alex	Change Log Message	=> Fixed warning, when "grid_picker_filter" is used

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group