In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000737

[In-Portal CMS] Data Management

bug report

always

2010-05-18 07:51

2010-06-10 13:44

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.0.4-B1

Status

closed

Product Version

5.0.3

Target Version

5.0.4

Time Estimate

No estimate

Summary

0000737: Hardcoded group ids in group selector

Description

I've found, that we have hardcoded 14 (guest) and 15 (everyone) group ids in select query for group selector.

Usually we don't change that groups, but such ability exists by using proper configuration variables. I think, that we need to fix that just in case.

Additional Information

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-bugs/browse_thread/thread/1abe5e43676d172e

Change Log Message

Estimate Points

0

hardcoded_group_ids.patch [^] (779 bytes) 2010-05-18 07:51 [Show Content]

Index: groups_event_handler.php
===================================================================
--- groups_event_handler.php	(revision 13557)
+++ groups_event_handler.php	(working copy)
@@ -38,8 +38,11 @@
 								FROM ' . $table_name . '
 								WHERE PortalUserId = ' . (int)$user_id;
 						$group_ids = $this->Conn->GetCol($sql);
-						array_push($group_ids, 14, 15); // Guest & Everyone groups are set dynamically
 
+						// add system groups
+						array_push($group_ids, $this->Application->ConfigValue('User_GuestGroup')); // Guest
+						array_push($group_ids, $this->Application->ConfigValue('User_LoggedInGroup')); // Everyone
+
 						$object->addFilter('already_member_filter', '%1$s.GroupId NOT IN ('.implode(',', $group_ids).')');
 					}
 					break;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0002243) Dmitry (manager) 2010-05-18 22:28	Tested good.

(0002264) alex (manager) 2010-05-19 15:11	Moving to 5.0.4 since pretty easy fix.

(0002272) alex (manager) 2010-05-20 13:27	Fix committed to 5.0.x branch. Commit Message: Fixes 0000737: Hardcoded group ids in group selector

(0002410) alex (manager) 2010-06-10 13:44	Closing since version 5.0.4 is released.

Related Changesets
In-Portal CMS: 5.0.x r13593 Timestamp: 2010-05-20 13:27:15 Author: alex [ Details ] [ Diff ]	Fixes 0000737: Hardcoded group ids in group selector
	mod - /in-portal/branches/5.0.x/core/units/groups/groups_event_handler.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-06-10 13:44	alex	Note Added: 0002410
2010-06-10 13:44	alex	Status	resolved => closed
2010-05-20 13:27	alex	Note Added: 0002272
2010-05-20 13:27	alex	Status	reviewed and tested => resolved
2010-05-20 13:27	alex	Fixed in Version	=> 5.0.4-B1
2010-05-20 13:27	alex	Resolution	open => fixed
2010-05-20 13:27	alex	Assigned To	!COMMUNITY => alex
2010-05-20 13:27	alex	Changeset attached	5.0.x r13593
2010-05-19 15:11	alex	Note Added: 0002264
2010-05-19 15:11	alex	Target Version	Icebox => 5.0.4
2010-05-18 22:28	Dmitry	Note Added: 0002243
2010-05-18 22:28	Dmitry	Status	needs testing => reviewed and tested
2010-05-18 07:51	alex	Assigned To	=> !COMMUNITY
2010-05-18 07:51	alex	Developer	=> alex
2010-05-18 07:51	alex	Status	active => needs testing
2010-05-18 07:51	alex	Reference	=> http://groups.google.com/group/in-portal-bugs/browse_thread/thread/1abe5e43676d172e
2010-05-18 07:51	alex	New Issue
2010-05-18 07:51	alex	File Added: hardcoded_group_ids.patch

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group