In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000668 [In-Portal CMS] Admin Interfaces feature request N/A 2010-03-27 17:56 2012-07-25 05:33
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority minor Resolution fixed Fixed in Version 5.2.0-B1
Status closed Product Version 5.0.3-B1 Target Version 5.2.0
Time EstimateNo estimate
Summary 0000668: Add ability to hide site name from top frame in administrative console
Description I propose to add ability to hide site name from top frame in administrative console. In some cases site logo already includes it's name so two site names doesn't look too good together (even in opposite frame sides as for now).

Setting will be in Skin record, since all admin interface colors (top frame included) are defined there.
Additional Information Plan:
1. create DisplaySiteNameInHeader (tinyint) field in Skins table with "1 - yes/0 - no" options on form; 1 by default
2. place ALTER statement into install/upgrades.sql
3. update table structure in install/install_schema.sql
4. update any existing INSERT statements into Skins table in install/install_data.sql
5. there is a tag, that allows you to check any active skin field (see in head.tpl file); use it in m_if tag's check attribute to hide site name in admin console header
6. translate new field label as "Display site name in Header"
7. export language pack and merge only your changes to install/english.lang
8. test install/upgrade
---
Hours:
1. new field + install stuff - 1 h
2. template changes: 0.5 h
----
1.5 h
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/f9c1f9da560bd279
Change Log Message
Estimate Points 1
Attached Files png file icon site_name_in_top_frame.png [^] (29,732 bytes) 2010-03-27 17:56


patch file icon hide_site_name_668.patch [^] (40,034 bytes) 2011-09-30 08:27 [Show Content]
patch file icon hide_site_name_668.2.patch [^] (40,193 bytes) 2011-10-04 09:45 [Show Content]
patch file icon sitename_hiding_in_header_v3.patch [^] (42,786 bytes) 2011-10-05 07:32 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
User avatar (0003944)
erik (manager)
2011-09-30 08:28

 Patch attached - needs testing
User avatar (0003979)
alex (manager)
2011-10-03 12:18

 1. I see no reason to use single quotes in DisplaySiteNameInHeader field value checking in "head.tpl" template. Please use double quotes instead. Single quotes only are to be used, when inp2 tags are used inside HTML tag attributes, e.g.
incorrect: <img src="<inp2:m_Param name="src"/>" .../>
correct: <img src="<inp2:m_Param name='src'/>" .../>
User avatar (0004004)
erik (manager)
2011-10-04 09:46

 hide_site_name_668.2.patch attached - needs testing
User avatar (0004015)
alex (manager)
2011-10-05 07:32

 Tested, but few things that were fixed:
1. Phrases/events should be added to language pack (install/english.lang file) via Export/Merge operation. This way they will be sorted aphabetically.
2. HTML with site name in head.tpl file tabulated properly, to be related to IF statement around it.
3. Attibute "title" from "inp_edit_radio" block removed, since in 5.2.0 there is no need for them when field label is in format "la_fld_FieldName".
User avatar (0004016)
alex (manager)
2011-10-05 07:33

 Fix committed to 5.2.x branch. Commit Message:

Fixes 0000668: Add ability to hide site name from top frame in administrative console
Commit on behalf of Erik
User avatar (0005102)
alex (manager)
2012-07-25 05:33

 Since 5.2.0 version was released.

- Related Changesets
In-Portal CMS: 5.2.x r14635
Timestamp: 2011-10-05 07:33:29
Author: alex
[ Details ] [ Diff ] 		Fixes 0000668: Add ability to hide site name from top frame in administrative console
Commit on behalf of Erik
mod - /in-portal/branches/5.2.x/core/admin_templates/head.tpl [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/admin_templates/skins/skin_edit.tpl [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/install/english.lang [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/install/install_data.sql [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/install/install_schema.sql [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/install/upgrades.sql [ Diff ] [ File ]
mod - /in-portal/branches/5.2.x/core/units/skins/skins_config.php [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005102
2012-07-25 05:33 alex Status resolved => closed
2011-10-22 05:31 alex Estimate Points => 1
2011-10-05 07:33 alex Note Added: 0004016
2011-10-05 07:33 alex Status reviewed and tested => resolved
2011-10-05 07:33 alex Fixed in Version => 5.2.0-B1
2011-10-05 07:33 alex Resolution open => fixed
2011-10-05 07:33 alex Assigned To !COMMUNITY => alex
2011-10-05 07:33 alex Changeset attached 5.2.x r14635
2011-10-05 07:32 alex Note Added: 0004015
2011-10-05 07:32 alex Assigned To alex => !COMMUNITY
2011-10-05 07:32 alex Status needs testing => reviewed and tested
2011-10-05 07:32 alex File Added: sitename_hiding_in_header_v3.patch
2011-10-04 09:46 erik Note Added: 0004004
2011-10-04 09:46 erik Assigned To erik => alex
2011-10-04 09:46 erik Status needs work => needs testing
2011-10-04 09:45 erik File Added: hide_site_name_668.2.patch
2011-10-03 12:18 alex Note Added: 0003979
2011-10-03 12:18 alex Assigned To alex => erik
2011-10-03 12:18 alex Status needs testing => needs work
2011-09-30 08:28 erik Time Estimate Removed 2 =>
2011-09-30 08:28 erik Note Added: 0003944
2011-09-30 08:28 erik Assigned To erik => alex
2011-09-30 08:28 erik Developer => erik
2011-09-30 08:28 erik Status needs work => needs testing
2011-09-30 08:27 erik File Added: hide_site_name_668.patch
2011-09-26 04:17 alex Time Estimate Added 2
2011-09-26 04:17 alex Additional Information Updated View Revisions
2011-09-24 22:42 Dmitry Assigned To => erik
2011-09-24 22:42 Dmitry Priority normal => minor
2011-09-24 22:42 Dmitry Status active => needs work
2011-09-24 22:42 Dmitry Target Version Icebox => 5.2.0
2010-03-27 17:56 alex New Issue
2010-03-27 17:56 alex File Added: site_name_in_top_frame.png
2010-03-27 17:56 alex Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/f9c1f9da560bd279

Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker