Anonymous | Login | Signup for a new account | 2024-09-07 18:51 CDT | ![]() |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0000274 | [In-Portal CMS] Admin Interfaces | bug report | always | 2009-09-07 12:43 | 2009-10-03 07:56 | ||
Reporter | Dmitry | View Status | public | Project Name | In-Portal CMS | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Fixed in Version | 5.0.1 | ||
Status | closed | Product Version | 5.0.1 | Target Version | 5.0.1 | ||
Time Estimate | No estimate | ||||||
Summary | 0000274: Missing "Section Template" and "Section Properties" buttons in Content & Design Modes | ||||||
Description |
Missing "Section Template" and "Section Properties" buttons in Content & Design Modes. Tested on 2 separate installs. |
||||||
Additional Information | |||||||
Tags | No tags attached. | ||||||
Reference | |||||||
Change Log Message | |||||||
Estimate Points | 0 | ||||||
Attached Files | |||||||
|
![]() |
|
![]() |
|
![]() alex (manager) 2009-09-08 03:55 |
Fix committed to 5.0.x branch. Commit Message: 1. Fixes 0000274: Missing "Section Template" and "Section Properties" buttons in Content & Design Modes. 2. I bet, that these installs were having "default2009" theme before. 3. Problem was, that when auto-creating theme structure for given theme, then ThemeId were not taken into account when searching already created pages in Category table. This was perfectly visible for two themes with identical structure (like "default2009" and "advanced") - corresponding records in Category table just were not created at all. |
![]() alex (manager) 2009-09-18 07:17 |
These buttons are missing again. Also content block on home page is missing (unable to edit it's contents in content mode). |
![]() Dmitry (manager) 2009-09-18 10:16 |
It's working on my dev. Copy - all files are committed on my end. Can you Debug this issue? |
![]() alex (manager) 2009-09-18 16:48 |
I figured out, that this happens only, when section is not created for current template. In my case this was "index" template in theme root folder. Can't really reproduce on my install, but here is one possible test case: 1. perform clean install; 2. go to "Configuration -> Website -> Themes" section and change primary theme; 3. go to front-end in "Content Mode" and "Section Template/Properties" button is missing. |
![]() alex (manager) 2009-09-20 03:55 |
Reminder sent to: Dmitry We could do various things to improve that is future: 1. show user a note (on top of a page) in case if corresponding record in Category table is missing for page he is currently viewing. 2. when theme is enabled (directly or via primary status change) make auto-scan for it's template (auto-scan wasn't made before, because theme was disabled). We don't automatically call auto-scan on each theme save, because it takes some time to work and it's not obvious to user, that it happens right now and why theme saving processes takes so much time to run. Maybe we could solve this as following: 1. user saves theme or changes it's primary status as before and special mark is set to appear on theme list template, that will be shown. 2. on theme list template show special notice to user, that theme cache will now be rebuild and please wait for a couple of seconds and so on. 3. via ajax query (in background) call event, that will rebuild cache) and disable all screen in meantime. 4. when ajax event is finished it will enable all back and show user notice, that all is complete. Whole rebuild process consists of 2 steps: 1. find all new/deleted templates in all enabled themes and add/delete them to ThemeFiles table (this is recursive and we can't calculate any progress bar here). 2. find templates from ThemeFiles table, that don't have (but should have) corresponding record in Category table (can calculate progress). So we theoretically could show progress bar, when theme is rebuild, but only for 2nd step. During execution of 1st step progress bar (if used) won't move. Also we should keep ability to call auto-scan event without any progress bars, like during installation. |
![]() Dmitry (manager) 2009-09-20 19:34 |
Proposals sound reasonable to me. Can you clarify a bit more on this: ========= 1. show user a note (on top of a page) in case if corresponding record in Category table is missing for page he is currently viewing. ========= Where do we show the message. |
![]() alex (manager) 2009-09-21 01:35 |
To minimize implementation time we could show same button as "Section Template" but, with warning text. Or create div with border and background (100% width) and show message there. You can draw design and I implement it. Also we could show link/button to manually auto-scan theme right now. |
![]() Dmitry (manager) 2009-09-21 11:56 |
All this brings additional elements and request for action from the user - in my opinions it only complicates the process. What if we simply do what we do - rescan/rebuild whenever we Enable/Disable theme even if it take a bit long which is not always the case I think it will lead to less confusion for everyone? |
![]() alex (manager) 2009-09-22 07:22 |
Fix committed to 5.0.x branch. Commit Message: Fixes 0000274: Missing "Section Template" and "Section Properties" buttons in Content & Design Modes |
![]() administrator (administrator) 2009-10-03 07:56 |
Closing issues from 5.0.1 version, because version was already released. |
![]() |
|||
In-Portal CMS: 5.0.x r12588 Timestamp: 2009-09-22 07:22:23 Author: alex [ Details ] [ Diff ] |
Fixes 0000274: Missing "Section Template" and "Section Properties" buttons in Content & Design Modes | ||
mod - /in-portal/branches/5.0.x/core/units/themes/themes_eh.php | [ Diff ] [ File ] | ||
In-Portal CMS: 5.0.x r12458 Timestamp: 2009-09-08 03:55:05 Author: alex [ Details ] [ Diff ] |
1. Fixes 0000274: Missing "Section Template" and "Section Properties" buttons in Content & Design Modes. 2. I bet, that these installs were having "default2009" theme before. 3. Problem was, that when auto-creating theme structure for given theme, then ThemeId were not taken into account when searching already created pages in Category table. This was perfectly visible for two themes with identical structure (like "default2009" and "advanced") - corresponding records in Category table just were not created at all. |
||
mod - /in-portal/branches/5.0.x/core/units/categories/categories_event_handler.php | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
2009-10-03 07:56 | administrator | Note Added: 0000716 | |
2009-10-03 07:56 | administrator | Status | resolved => closed |
2009-10-03 07:26 | administrator | Priority | @50@ => normal |
2009-10-03 07:26 | administrator | Type | @60@ => bug report |
2009-09-22 07:22 | alex | Fixed in Version | => 5.0.1 |
2009-09-22 07:22 | alex | Note Added: 0000509 | |
2009-09-22 07:22 | alex | Status | needs feedback => resolved |
2009-09-22 07:22 | alex | Fixed in Version | 5.0.1 => |
2009-09-22 07:22 | alex | Resolution | reopened => fixed |
2009-09-22 07:22 | alex | Changeset attached | 5.0.x r12588 |
2009-09-22 01:35 | Dmitry | Priority | normal => @50@ |
2009-09-21 11:56 | Dmitry | Note Added: 0000501 | |
2009-09-21 11:56 | Dmitry | Assigned To | Dmitry => alex |
2009-09-21 11:56 | Dmitry | Status | needs work => needs feedback |
2009-09-21 01:35 | alex | Note Added: 0000495 | |
2009-09-21 01:35 | alex | Assigned To | alex => Dmitry |
2009-09-21 01:35 | alex | Status | needs feedback => needs work |
2009-09-20 19:34 | Dmitry | Note Added: 0000489 | |
2009-09-20 19:34 | Dmitry | Assigned To | Dmitry => alex |
2009-09-20 19:34 | Dmitry | Status | needs work => needs feedback |
2009-09-20 03:55 | alex | Note Added: 0000486 | |
2009-09-18 16:48 | alex | Note Added: 0000482 | |
2009-09-18 16:48 | alex | Assigned To | alex => Dmitry |
2009-09-18 16:48 | alex | Status | needs feedback => needs work |
2009-09-18 10:16 | Dmitry | Note Added: 0000479 | |
2009-09-18 10:16 | Dmitry | Assigned To | Dmitry => alex |
2009-09-18 10:16 | Dmitry | Status | needs work => needs feedback |
2009-09-18 10:15 | Dmitry | Status | needs feedback => needs work |
2009-09-18 07:17 | alex | Assigned To | alex => Dmitry |
2009-09-18 07:17 | alex | Note Added: 0000476 | |
2009-09-18 07:17 | alex | Status | resolved => needs feedback |
2009-09-18 07:17 | alex | Resolution | fixed => reopened |
2009-09-08 03:55 | alex | Fixed in Version | => 5.0.1 |
2009-09-08 03:55 | alex | Note Added: 0000410 | |
2009-09-08 03:55 | alex | Status | reviewed and tested => resolved |
2009-09-08 03:55 | alex | Resolution | open => fixed |
2009-09-08 03:55 | alex | Changeset attached | 5.0.x r12458 |
2009-09-07 12:43 | Dmitry | New Issue | |
2009-09-07 12:43 | Dmitry | Status | active => reviewed and tested |
2009-09-07 12:43 | Dmitry | Assigned To | => alex |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic![]() In-Portal Open Source CMS |