In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000252

[In-Portal CMS] Front End

feature request

N/A

2009-09-01 06:39

2010-07-22 15:06

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.0-B1

Status

closed

Product Version

Target Version

5.1.0

Time Estimate

No estimate

Summary

0000252: Add ability to specify custom HTTP response code along with redirect header

Description

Normally HTTP response code 302 (Found) is sent, when "kApplication::Redirect" method is called. However there are cases (like site migration to another software), when there is need to sent other header, like 301 (Moved Permanently).

I propose to add "response_code" parameter to url building process, to be processed by "kApplication::Redirect" method only.

Additional Information

This has been implemented in eGov project.

U core/kernel/application - revision 1.186.2.25.46.1

Tags

No tags attached.

Reference

Change Log Message

Estimate Points

0

responce_code_on_redirect.patch [^] (793 bytes) 2009-12-19 06:34 [Show Content]

Index: application.php
===================================================================
--- application.php	(revision 12950)
+++ application.php	(working copy)
@@ -1924,6 +1924,15 @@
 			unset($params['js_redirect']);
 		}
 
+		// allows to send custom responce code along with redirect header
+		if (array_key_exists('response_code', $params)) {
+			$response_code = (int)$params['response_code'];
+			unset($params['response_code']);
+		}
+		else {
+			$responce_code = 302; // Found
+		}
+
 		if (!array_key_exists('pass', $params)) {
 			$params['pass'] = 'all';
 		}
@@ -1963,7 +1972,7 @@
 					// no output before -> redirect using HTTP header
 
 //					header('HTTP/1.1 302 Found');
-					header("$location");
+					header("$location", true, $response_code);
 				}
 			}
 		}

typo_error_fix.patch [^] (364 bytes) 2010-05-05 02:12 [Show Content]

Index: application.php
===================================================================
--- application.php	(revision 13473)
+++ application.php	(working copy)
@@ -2062,7 +2062,7 @@
 			unset($params['response_code']);
 		}
 		else {
-			$responce_code = 302; // Found
+			$response_code = 302; // Found
 		}
 
 		if (!array_key_exists('pass', $params)) {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

closed (5.1.0)

Automatic mod-rewrite redirecting

Notes
(0001874) Dmitry (manager) 2010-04-12 18:58	Tested okay

(0001910) alex (manager) 2010-04-24 15:17	Fix committed to 5.1.x branch. Commit Message: Fixes 0000252: Add ability to specify custom HTTP response code along with redirect header

(0002058) alex (manager) 2010-05-05 02:13	Patch "typo_error_fix.patch" (already commited) fixes type error in kApplication::Redirect method (for cases, when custom response code wasn't specified).

(0002534) alex (manager) 2010-07-22 15:06	Closing, since 5.1.0 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r13488 Timestamp: 2010-05-05 02:12:29 Author: alex [ Details ] [ Diff ]	1. Bug 0000252: Add ability to specify custom HTTP response code along with redirect header 2. Fixing typo error.
	mod - /in-portal/branches/5.1.x/core/kernel/application.php		[ Diff ] [ File ]

In-Portal CMS: 5.1.x r13391 Timestamp: 2010-04-24 15:17:29 Author: alex [ Details ] [ Diff ]	Fixes 0000252: Add ability to specify custom HTTP response code along with redirect header
	mod - /in-portal/branches/5.1.x/core/kernel/application.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-07-22 15:06	alex	Note Added: 0002534
2010-07-22 15:06	alex	Status	resolved => closed
2010-05-05 02:13	alex	Note Added: 0002058
2010-05-05 02:12	alex	Changeset attached	5.1.x r13488
2010-05-05 02:12	alex	File Added: typo_error_fix.patch
2010-04-24 15:17	alex	Note Added: 0001910
2010-04-24 15:17	alex	Status	reviewed and tested => resolved
2010-04-24 15:17	alex	Fixed in Version	=> 5.1.0-B1
2010-04-24 15:17	alex	Resolution	open => fixed
2010-04-24 15:17	alex	Assigned To	!COMMUNITY => alex
2010-04-24 15:17	alex	Changeset attached	5.1.x r13391
2010-04-12 18:58	Dmitry	Time Estimate Removed	1 =>
2010-04-12 18:58	Dmitry	Note Added: 0001874
2010-04-12 18:58	Dmitry	Status	needs testing => reviewed and tested
2010-02-27 04:09	alex	Developer	=> alex
2010-02-03 13:34	alex	Relationship added	related to 0000548
2010-01-12 11:21	alex	Time Estimate Added	1
2009-12-19 06:34	alex	Assigned To	=> !COMMUNITY
2009-12-19 06:34	alex	Status	active => needs testing
2009-12-19 06:34	alex	File Added: responce_code_on_redirect.patch
2009-09-01 10:08	Dmitry	Additional Information Updated	View Revisions
2009-09-01 10:08	Dmitry	Target Version	=> 5.1.0
2009-09-01 06:39	alex	New Issue

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group