Anonymous | Login | Signup for a new account | 2023-12-06 15:08 CST | ![]() |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
0001429 | [In-Portal CMS] Template System | bug report | always | 2012-11-05 10:43 | 2012-11-07 06:10 | ||
Reporter | alex | View Status | public | Project Name | In-Portal CMS | ||
Assigned To | alex | Developer | |||||
Priority | normal | Resolution | fixed | Fixed in Version | 5.2.1-B1 | ||
Status | resolved | Product Version | 5.1.0 | Target Version | 5.2.1 | ||
Time Estimate | No estimate | ||||||
Summary | 0001429: Incorrectly included templates via <inp2:m_ModuleInclude tag | ||||||
Description |
In-Portal has 2 tags, that allow to use same template multiple times on other different templates: * <inp2:m_Include - includes 1 given template * <inp2:m_ModuleInclude - includes given template from each module There is a problem with m_ModuleInclude tag in Admin Console, where he uses "core/" prefix to include templates from core module (see attached image). This works of course (otherwise whole "Structure & Data" section would be dead), but when you need to replace template, that is included (e.g. "catalog_tab" from core module), then you need to write "core/" before replaced template name. What I've described might not be a bug, but because of "Sections" tab in "Structure & Data" page is loaded via ajax and is accessing "catalog_tab" (and not "core/catalog_tab", that was replaced) resulting page uses original non-replaced template. Solution: Inside m_ModuleInclude tag when we have "core/" as module path, then strip it. This way template replacement will work. |
||||||
Additional Information | We might try to risk and actually remove "core/" from Modules table and see how it will work afterwards. | ||||||
Tags | No tags attached. | ||||||
Reference | https://groups.google.com/d/topic/in-portal-bugs/kf-oMaCAmL8/discussion | ||||||
Change Log Message | Fixes misleading path being used by ModuleInclude tag | ||||||
Estimate Points | 1 | ||||||
Attached Files |
![]() ![]() |
||||||
|
![]() |
|
![]() |
|
![]() alex (manager) 2012-11-07 06:09 |
Will test all together later. |
![]() alex (manager) 2012-11-07 06:10 |
Fix committed to 5.2.x branch. Commit Message: Fixes 0001429: Incorrectly included templates via <inp2:m_ModuleInclude tag |
![]() |
|||
In-Portal CMS: 5.2.x r15615 Timestamp: 2012-11-07 06:10:28 Author: alex [ Details ] [ Diff ] |
Fixes 0001429: Incorrectly included templates via <inp2:m_ModuleInclude tag | ||
mod - /in-portal/branches/5.2.x/core/kernel/processors/main_processor.php | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
2012-11-07 06:10 | alex | Changeset attached | 5.2.x r15615 |
2012-11-07 06:10 | alex | Note Added: 0005264 | |
2012-11-07 06:10 | alex | Status | reviewed and tested => resolved |
2012-11-07 06:10 | alex | Fixed in Version | => 5.2.1-B1 |
2012-11-07 06:10 | alex | Resolution | open => fixed |
2012-11-07 06:10 | alex | Assigned To | !COMMUNITY => alex |
2012-11-07 06:09 | alex | Note Added: 0005263 | |
2012-11-07 06:09 | alex | Status | needs testing => reviewed and tested |
2012-11-07 06:09 | alex | Assigned To | => !COMMUNITY |
2012-11-07 06:09 | alex | Developer | => alex |
2012-11-07 06:09 | alex | Status | active => needs testing |
2012-11-07 06:08 | alex | File Added: moduleinclude_and_core_fix.patch | |
2012-11-07 05:54 | alex | File Added: inportal_module_include_admin.png | |
2012-11-05 10:43 | alex | New Issue | |
2012-11-05 10:43 | alex | Reference | => https://groups.google.com/d/topic/in-portal-bugs/kf-oMaCAmL8/discussion |
2012-11-05 10:43 | alex | Change Log Message | => Fixes misleading path being used by ModuleInclude tag |
2012-11-05 10:43 | alex | Estimate Points | => 1 |
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic![]() In-Portal Open Source CMS |