In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/lY-iH4s5BWs/discussion

Change Log Message

Fixed Fatal error during Installation on States import with MySQL in Strict Mode

Estimate Points

Attached Files

sql_error_on_install_520b1.patch [^] (8,104 bytes) 2012-02-06 04:15 [Show Content]

Index: install/install_schema.sql
===================================================================
--- install/install_schema.sql	(revision 15085)
+++ install/install_schema.sql	(working copy)
@@ -244,7 +244,7 @@
 
 CREATE TABLE Users (
   PortalUserId int(11) NOT NULL AUTO_INCREMENT,
-  Username varchar(255) NOT NULL,
+  Username varchar(255) NOT NULL DEFAULT '',
   `Password` varchar(255) DEFAULT 'd41d8cd98f00b204e9800998ecf8427e',
   FirstName varchar(255) NOT NULL DEFAULT '',
   LastName varchar(255) NOT NULL DEFAULT '',
@@ -266,9 +266,9 @@
   Modified int(11) DEFAULT NULL,
   dob int(11) DEFAULT NULL,
   TimeZone varchar(255) NOT NULL DEFAULT '',
-  IPAddress varchar(15) NOT NULL,
+  IPAddress varchar(15) NOT NULL DEFAULT '',
   IsBanned tinyint(1) NOT NULL DEFAULT '0',
-  PwResetConfirm varchar(255) NOT NULL,
+  PwResetConfirm varchar(255) NOT NULL DEFAULT '',
   PwRequestTime int(11) unsigned DEFAULT NULL,
   FrontLanguage int(11) DEFAULT NULL,
   AdminLanguage int(11) DEFAULT NULL,
@@ -360,7 +360,7 @@
   IpAddress varchar(20) NOT NULL DEFAULT '0.0.0.0',
   `Status` int(11) NOT NULL DEFAULT '1',
   GroupList varchar(255) DEFAULT NULL,
-  TimeZone varchar(255) NOT NULL,
+  TimeZone varchar(255) NOT NULL DEFAULT '',
   BrowserSignature varchar(32) NOT NULL DEFAULT '',
   PRIMARY KEY (SessionKey),
   KEY UserId (PortalUserId),
@@ -393,11 +393,11 @@
   CountryStateId int(11) NOT NULL AUTO_INCREMENT,
   `Type` int(11) NOT NULL DEFAULT '1',
   StateCountryId int(11) DEFAULT NULL,
-  l1_Name varchar(255) NOT NULL,
-  l2_Name varchar(255) NOT NULL,
-  l3_Name varchar(255) NOT NULL,
-  l4_Name varchar(255) NOT NULL,
-  l5_Name varchar(255) NOT NULL,
+  l1_Name varchar(255) NOT NULL DEFAULT '',
+  l2_Name varchar(255) NOT NULL DEFAULT '',
+  l3_Name varchar(255) NOT NULL DEFAULT '',
+  l4_Name varchar(255) NOT NULL DEFAULT '',
+  l5_Name varchar(255) NOT NULL DEFAULT '',
   IsoCode char(3) NOT NULL DEFAULT '',
   ShortIsoCode char(2) DEFAULT NULL,
   PRIMARY KEY (CountryStateId),
@@ -479,7 +479,7 @@
   PageExpiration int(11) DEFAULT NULL,
   LiveRevisionNumber int(11) NOT NULL DEFAULT '1',
   DirectLinkEnabled tinyint(4) NOT NULL DEFAULT '1',
-  DirectLinkAuthKey varchar(20) NOT NULL,
+  DirectLinkAuthKey varchar(20) NOT NULL DEFAULT '',
   PromoBlockGroupId int(10) unsigned NOT NULL DEFAULT '0',
   RequireSSL tinyint(4) NOT NULL DEFAULT '0',
   RequireLogin tinyint(4) NOT NULL DEFAULT '0',
@@ -683,7 +683,7 @@
   RunTime int(10) unsigned NOT NULL DEFAULT '0',
   Timeout int(10) unsigned DEFAULT NULL,
   LastTimeoutOn int(10) unsigned DEFAULT NULL,
-  SiteDomainLimitation varchar(255) NOT NULL,
+  SiteDomainLimitation varchar(255) NOT NULL DEFAULT '',
   PRIMARY KEY (ScheduledTaskId),
   KEY `Status` (`Status`),
   KEY RunInterval (RunInterval),
@@ -823,9 +823,9 @@
 
 CREATE TABLE ItemFilters (
   FilterId int(11) NOT NULL AUTO_INCREMENT,
-  ItemPrefix varchar(255) NOT NULL,
-  FilterField varchar(255) NOT NULL,
-  FilterType varchar(100) NOT NULL,
+  ItemPrefix varchar(255) NOT NULL DEFAULT '',
+  FilterField varchar(255) NOT NULL DEFAULT '',
+  FilterType varchar(100) NOT NULL DEFAULT '',
   Enabled tinyint(4) NOT NULL DEFAULT '1',
   RangeCount int(11) DEFAULT NULL,
   PRIMARY KEY (FilterId),
@@ -835,7 +835,7 @@
 
 CREATE TABLE SpamReports (
   ReportId int(11) NOT NULL AUTO_INCREMENT,
-  ItemPrefix varchar(255) NOT NULL,
+  ItemPrefix varchar(255) NOT NULL DEFAULT '',
   ItemId int(11) NOT NULL,
   MessageText text,
   ReportedOn int(11) DEFAULT NULL,
@@ -1210,7 +1210,7 @@
   DomainId int(11) NOT NULL DEFAULT '0',
   `Hash` int(11) NOT NULL DEFAULT '0',
   Prefixes varchar(255) NOT NULL DEFAULT '',
-  ParsedVars text NOT NULL,
+  ParsedVars text,
   Cached int(10) unsigned DEFAULT NULL,
   LifeTime int(11) NOT NULL DEFAULT '-1',
   PRIMARY KEY (UrlId),
@@ -1257,9 +1257,9 @@
 
 CREATE TABLE CurlLog (
   LogId int(11) NOT NULL AUTO_INCREMENT,
-  Message varchar(255) NOT NULL,
-  PageUrl varchar(255) NOT NULL,
-  RequestUrl varchar(255) NOT NULL,
+  Message varchar(255) NOT NULL DEFAULT '',
+  PageUrl varchar(255) NOT NULL DEFAULT '',
+  RequestUrl varchar(255) NOT NULL DEFAULT '',
   PortalUserId int(11) NOT NULL,
   SessionKey int(11) NOT NULL,
   IsAdmin tinyint(4) NOT NULL,
@@ -1269,7 +1269,7 @@
   RequestDate int(11) DEFAULT NULL,
   ResponseDate int(11) DEFAULT NULL,
   ResponseHttpCode int(11) NOT NULL,
-  CurlError varchar(255) NOT NULL,
+  CurlError varchar(255) NOT NULL DEFAULT '',
   PRIMARY KEY (LogId),
   KEY Message (Message),
   KEY PageUrl (PageUrl),
Index: install/install_toolkit.php
===================================================================
--- install/install_toolkit.php	(revision 15085)
+++ install/install_toolkit.php	(working copy)
@@ -172,7 +172,9 @@
 
 			$prerequisites_file = sprintf(PREREQUISITE_FILE, $module_path);
 			if ( !file_exists($prerequisites_file) ) {
-				return false;
+				$false = false;
+
+				return $false;
 			}
 
 			if ( !isset($prerequisite_classes[$module_path]) ) {
Index: install/upgrades.sql
===================================================================
--- install/upgrades.sql	(revision 15085)
+++ install/upgrades.sql	(working copy)
@@ -2603,3 +2603,42 @@
 INSERT INTO SystemSettings VALUES(DEFAULT, 'CKFinderLicenseKey', '', 'In-Portal', 'in-portal:configure_advanced', 'la_section_Settings3rdPartyAPI', 'la_config_CKFinderLicenseKey', 'text', NULL, NULL, 80.04, 0, 0, NULL);
 
 INSERT INTO SystemSettings VALUES(DEFAULT, 'EnablePageContentRevisionControl', '0', 'In-Portal', 'in-portal:configure_advanced', 'la_section_SettingsAdmin', 'la_config_EnablePageContentRevisionControl', 'checkbox', '', '', 40.19, 0, 0, NULL);
+
+# ===== v 5.2.0-B2 =====
+ALTER TABLE Users
+	CHANGE Username Username varchar(255) NOT NULL DEFAULT '',
+	CHANGE IPAddress IPAddress varchar(15) NOT NULL DEFAULT '',
+	CHANGE PwResetConfirm PwResetConfirm varchar(255) NOT NULL DEFAULT '';
+
+ALTER TABLE UserSessions
+	CHANGE TimeZone TimeZone varchar(255) NOT NULL DEFAULT '';
+
+ALTER TABLE CountryStates
+	CHANGE l1_Name l1_Name varchar(255) NOT NULL DEFAULT '',
+	CHANGE l2_Name l2_Name varchar(255) NOT NULL DEFAULT '',
+	CHANGE l3_Name l3_Name varchar(255) NOT NULL DEFAULT '',
+	CHANGE l4_Name l4_Name varchar(255) NOT NULL DEFAULT '',
+	CHANGE l5_Name l5_Name varchar(255) NOT NULL DEFAULT '';
+
+ALTER TABLE Categories
+	CHANGE DirectLinkAuthKey DirectLinkAuthKey varchar(20) NOT NULL DEFAULT '';
+
+ALTER TABLE ScheduledTasks
+	CHANGE SiteDomainLimitation SiteDomainLimitation varchar(255) NOT NULL DEFAULT '';
+
+ALTER TABLE ItemFilters
+	CHANGE ItemPrefix ItemPrefix varchar(255) NOT NULL DEFAULT '',
+	CHANGE FilterField FilterField varchar(255) NOT NULL DEFAULT '',
+	CHANGE FilterType FilterType varchar(100) NOT NULL DEFAULT '';
+
+ALTER TABLE SpamReports
+	CHANGE ItemPrefix ItemPrefix varchar(255) NOT NULL DEFAULT '';
+
+ALTER TABLE CachedUrls
+	CHANGE ParsedVars ParsedVars text;
+
+ALTER TABLE CurlLog
+	CHANGE Message Message varchar(255) NOT NULL DEFAULT '',
+	CHANGE PageUrl PageUrl varchar(255) NOT NULL DEFAULT '',
+	CHANGE RequestUrl RequestUrl varchar(255) NOT NULL DEFAULT '',
+	CHANGE CurlError CurlError varchar(255) NOT NULL DEFAULT '';
Index: units/helpers/multilanguage_helper.php
===================================================================
--- units/helpers/multilanguage_helper.php	(revision 15085)
+++ units/helpers/multilanguage_helper.php	(working copy)
@@ -207,9 +207,9 @@
 									: $this->Conn->qstr($field_options['default']);
 							$field_mask['type'] = $field_options['db_type'];
 						}
-						$field_mask['default'] = ($field_mask['null'] == 'NOT NULL' && $default_value == 'NULL') ? ''
-								: 'DEFAULT ' . $default_value;
 
+						$field_mask['default'] = ($field_mask['null'] == 'NOT NULL' && $default_value == 'NULL') ? '' : 'DEFAULT ' . $default_value;
+
 						if ( strtoupper($field_mask['type']) == 'TEXT' ) {
 							// text fields in mysql doesn't have default value
 							$field_mask = $field_mask['name'] . ' ' . $field_mask['type'] . ' ' . $field_mask['null'];

invalid_integer_value_fix.patch [^] (452 bytes) 2012-02-07 08:32 [Show Content]

Index: units/modules/modules_config.php
===================================================================
--- units/modules/modules_config.php	(revision 15085)
+++ units/modules/modules_config.php	(working copy)
@@ -41,6 +41,8 @@
 						'tree_modules'	=>	Array('format' => '!la_section_overview!'),
 					),
 
+					'ForceDontLogChanges' => true,
+
 					'PermSection'		=>	Array('main' => 'in-portal:mod_status'),
 
 					'Sections'			=>	Array(

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	0000948	closed (5.2.0)	alex	In-Portal CMS	Change in "Forgot Password" logic
related to	0000645	closed (5.2.0)	alex	In-Portal CMS	User / Group Access restriction by IP
related to	0000964	closed (5.2.0)	alex	In-Portal CMS	Improvements to user Login field
related to	0000058	closed (5.2.0)	alex	In-Portal CMS	Add Timezone Field to User record
related to	0000279	closed (5.1.0)	alex	In-Portal CMS	Phrases of state and country names
related to	0001050	closed (5.2.0)	!COMMUNITY	In-Portal CMS	Ability to access Disabled Section with Direct Link
related to	0000883	closed (5.2.0)	alex	In-Portal CMS	Site domain-based agents
related to	0001126	closed (5.2.0)	Dmitry	In-Commerce	Implement Smart Filters
related to	0001129	closed (5.2.0)	alex	In-Portal CMS	Report Review
related to	0000107	closed (5.1.0)	alex	In-Portal CMS	Implement "MemCached" functionality
related to	0000950	closed (5.2.0)	alex	In-Portal CMS	Log CURL requests to database table instead of file

Notes
(0004445) alex (manager) 2012-02-06 04:16 edited on: 2012-02-06 04:18	As you can see majority of STRICT MODE incompatible SQLs were added in 5.2.0-B1 version, but CountryStates SQL that is mentioned in task description was there since 5.1.0 version. I've also found, that creating VARCHAR NOT NULL column without specifying DEFAULT value would result in such error (http://forums.mysql.com/read.php?10,361859,361862#msg-361862). This problem is caused by phpMyAdmin script, that we're using, since it creates VARCHAR columns by default this way.

(0004446) alex (manager) 2012-02-06 04:19	Will test all together later.

(0004447) alex (manager) 2012-02-06 04:19	Fix committed to 5.2.x branch. Commit Message: Fixes 0001201: Fatal error during Installation on States import with MySQL in Strict Mode

(0004450) alex (manager) 2012-02-07 08:36	Patch "invalid_integer_value_fix.patch" fixes SQL error on module approve/decline because ID field in Modules table is string, while MasterId field in ChangeLogs table, where it was inserted is integer.

(0004978) alex (manager) 2012-07-25 05:31	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15107 Timestamp: 2012-02-07 08:33:43 Author: alex [ Details ] [ Diff ]	Bug 0001201: Fatal error during Installation on States import with MySQL in Strict Mode 1. fixes SQL error on module approve/decline
	mod - /in-portal/branches/5.2.x/core/units/modules/modules_config.php	[ Diff ] [ File ]

In-Portal CMS: 5.2.x r15105 Timestamp: 2012-02-06 04:19:28 Author: alex [ Details ] [ Diff ]	Fixes 0001201: Fatal error during Installation on States import with MySQL in Strict Mode
	mod - /in-portal/branches/5.2.x/core/install/install_schema.sql	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/install/install_toolkit.php	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/install/upgrades.sql	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/units/helpers/multilanguage_helper.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:31	alex	Note Added: 0004978
2012-07-25 05:31	alex	Status	resolved => closed
2012-02-07 08:36	alex	Note Added: 0004450
2012-02-07 08:33	alex	Changeset attached	5.2.x r15107
2012-02-07 08:32	alex	File Added: invalid_integer_value_fix.patch
2012-02-06 04:19	alex	Note Added: 0004447
2012-02-06 04:19	alex	Status	reviewed and tested => resolved
2012-02-06 04:19	alex	Fixed in Version	=> 5.2.0-B2
2012-02-06 04:19	alex	Resolution	open => fixed
2012-02-06 04:19	alex	Assigned To	!COMMUNITY => alex
2012-02-06 04:19	alex	Changeset attached	5.2.x r15105
2012-02-06 04:19	alex	Note Added: 0004446
2012-02-06 04:19	alex	Status	needs testing => reviewed and tested
2012-02-06 04:18	alex	Note Edited: 0004445	View Revisions
2012-02-06 04:16	alex	Note Added: 0004445
2012-02-06 04:16	alex	Assigned To	=> !COMMUNITY
2012-02-06 04:16	alex	Developer	=> alex
2012-02-06 04:16	alex	Status	active => needs testing
2012-02-06 04:15	alex	File Added: sql_error_on_install_520b1.patch
2012-02-06 04:09	alex	Relationship added	related to 0000950
2012-02-06 04:09	alex	Relationship added	related to 0000107
2012-02-06 04:08	alex	Relationship added	related to 0001129
2012-02-06 04:07	alex	Relationship added	related to 0001126
2012-02-06 04:07	alex	Relationship added	related to 0000883
2012-02-06 04:06	alex	Relationship added	related to 0001050
2012-02-06 04:06	alex	Relationship added	related to 0000279
2012-02-06 04:05	alex	Relationship added	related to 0000058
2012-02-06 04:04	alex	Relationship added	related to 0000964
2012-02-06 04:03	alex	Relationship added	related to 0000645
2012-02-06 04:02	alex	Estimate Points	0 => 1
2012-02-06 04:02	alex	Description Updated	View Revisions
2012-02-06 04:02	alex	Relationship added	related to 0000948
2012-02-01 14:16	Dmitry	New Issue
2012-02-01 14:16	Dmitry	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/lY-iH4s5BWs/discussion
2012-02-01 14:16	Dmitry	Change Log Message	=> Fixed Fatal error during Installation on States import with MySQL in Strict Mode
2012-02-01 14:16	Dmitry	Estimate Points	=> 0

Web Development by Intechnic

In-Portal Open Source CMS