In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001189

[In-Portal CMS] Front End

bug report

always

2012-01-04 03:24

2012-07-25 05:32

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0-B1

Status

closed

Product Version

5.1.3

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001189: Site domain with empty "SSL Url" field is always matched as current on secure connection

Description

I've entered SSL url in configuration as "https://www.my-website.com" and created one site domain with "test.my-website.com" set as Name field (no other fields filled).

Then I've visited https://www.my-website.com and I wasn't redirected back to http://www.my-website.com because site domain was matched by mistake resulted redirect code to think, that website has no SSL url specified.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/0SbhQ2yBVzY/discussion

Change Log Message

Fixes SSL back-redirect problem

Estimate Points

1

empty_site_domain_match_fix.patch [^] (962 bytes) 2012-01-04 03:24 [Show Content]

Index: units/helpers/site_helper.php
===================================================================
--- units/helpers/site_helper.php	(revision 14975)
+++ units/helpers/site_helper.php	(working copy)
@@ -117,16 +117,16 @@
 
 			foreach ($site_domains as $id => $site_domain) {
 				if ( in_array($field, $name_fields) ) {
-					if (!$site_domain[$field . 'UsesRegExp']) {
+					if ( !$site_domain[$field . 'UsesRegExp'] ) {
 						// not regular expression -> escape manually
 						$site_domain[$field] = preg_quote($site_domain[$field], '/');
 					}
 
-					if (preg_match('/^' . $site_domain[$field] . ($field == 'DomainName' ? '$' : '') . '/', $value)) {
+					if ( $site_domain[$field] && preg_match('/^' . $site_domain[$field] . ($field == 'DomainName' ? '$' : '') . '/', $value) ) {
 						return $id;
 					}
 				}
-				elseif ($site_domain[$field] == $value) {
+				elseif ( $site_domain[$field] == $value ) {
 					return $id;
 				}
 			}

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

closed (5.2.0)

SSL + Login Required options for Sections

Notes
(0004381) alex (manager) 2012-01-04 03:25	Will test all together later.

(0004382) alex (manager) 2012-01-04 03:26	Fix committed to 5.2.x branch. Commit Message: Fixes 0001189: Site domain with empty "SSL Url" field is always matched as current on secure connection

(0005002) alex (manager) 2012-07-25 05:32	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r14976 Timestamp: 2012-01-04 03:26:13 Author: alex [ Details ] [ Diff ]	Fixes 0001189: Site domain with empty "SSL Url" field is always matched as current on secure connection
	mod - /in-portal/branches/5.2.x/core/units/helpers/site_helper.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:32	alex	Note Added: 0005002
2012-07-25 05:32	alex	Status	resolved => closed
2012-01-04 03:26	alex	Relationship added	related to 0000399
2012-01-04 03:26	alex	Relationship deleted	related to 0000339
2012-01-04 03:26	alex	Relationship added	related to 0000339
2012-01-04 03:26	alex	Note Added: 0004382
2012-01-04 03:26	alex	Status	reviewed and tested => resolved
2012-01-04 03:26	alex	Fixed in Version	=> 5.2.0-B1
2012-01-04 03:26	alex	Resolution	open => fixed
2012-01-04 03:26	alex	Assigned To	!COMMUNITY => alex
2012-01-04 03:26	alex	Changeset attached	5.2.x r14976
2012-01-04 03:25	alex	Note Added: 0004381
2012-01-04 03:25	alex	Status	needs testing => reviewed and tested
2012-01-04 03:25	alex	Assigned To	=> !COMMUNITY
2012-01-04 03:25	alex	Developer	=> alex
2012-01-04 03:25	alex	Status	active => needs testing
2012-01-04 03:25	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/0SbhQ2yBVzY/discussion
2012-01-04 03:24	alex	New Issue
2012-01-04 03:24	alex	File Added: empty_site_domain_match_fix.patch
2012-01-04 03:24	alex	Change Log Message	=> Fixes SSL back-redirect problem
2012-01-04 03:24	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group