In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001130 [In-Commerce] Payment Gateways bug report always 2011-09-27 06:50 2012-07-25 05:31
Reporter alex View Status public Project Name In-Commerce
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0-B2
Status closed Product Version Target Version 5.2.0
Time EstimateNo estimate
Summary 0001130: Price Filter
Description Price filter - get price ranges and product count in each of the range from products in a category (http://www.istockphoto.com/search/vetta/?facets={%2234%22:[%227%22]}#1927beb6)
Additional Information
Tags No tags attached.
Reference
Change Log Message
Estimate Points 2
Attached Files patch file icon range_filter_algorithm2.patch [^] (4,244 bytes) 2012-01-17 04:14 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0004295)
alex (manager)
2011-12-21 11:19

Done, but maybe we should:

1. implement another algorithm for detecting range values
2. way to display range product count since now last range is displayed incorrectly
User avatar (0004417)
Dmitry (manager)
2012-01-16 18:09
edited on: 2012-01-16 23:14

I have given it some more thoughts and these are my suggestions/ideas:


Since our ultimate goal is to create a Price Range filter with proper steps. We need to make sure steps are equal.


Option 1:


We ALWAYS should start with 0 (MIN = 0) and MAX is Calculated based on the formula:

Let's try use minimum number of steps 5.


Possible Steps Values - 1, 2, 5, 10, 20, 25, 30, 40, 50, 100, 150, 200, 250, 300, 400, 500, 1000, 1500, 2000, 2500, 3000, 5000, 10000

Actual MAX 5.24 / 5steps = 1.048 => 2 = 10 Calculated MAX
Actual MAX 105 / 5steps = 21 => 25 = 125 Calculated MAX
Actual MAX 145 / 5steps = 29 => 30 = 150 Calculated MAX
Actual MAX 175 / 5steps = 35 => 40 = 200 Calculated MAX
Actual MAX 1001 / 5steps = 200.2 => 250 = 1250 Calculated MAX
Actual MAX 4501 / 5steps = 900.2 => 1000 = 5000 Calculated MAX

This way we can always guarantee that we'll have the equal steps

Calculated MAX = Actual MAX / Number of Steps (5 default) and reach next available from Step Value (from list above).

Calculated MAX value should ALWAYS be >= then Actual MAX


NOTE: we should leave an option (so we can easy convert to this style if needed) to keep current Filter as simple as possible - when we have MIN and MAX taken from the current List with step 1 or so.

User avatar (0004421)
alex (manager)
2012-01-17 04:11

I suppose you meant, that formula is:

calculated max = closest(actual max / step count) * step count
User avatar (0004423)
Dmitry (manager)
2012-01-17 18:04
edited on: 2012-01-17 18:07

Some additional changes needed:

1. Set Slider height from PHP as Step Count * Factor (current 26)

2. Add Last Price to 1st column

3. Add Currency to Prices

4. Show Integer values in Prices (remove .00)

5. Set Filter step 10 instead of 11

6. Input Price ranges - http://priceslider.mangoextensions.com/our-products.html#dir=desc&limit=30&manufacturer=18&order=price&price=20%2C70125&size=6

NOTE: this part should be easy detachable so we can comment out/remove if needed.

a. Entered values MIN =< MAX, MIN >= 0, MAX =< Calculated MAX, MAX >= 0
b. If entered value is not matching the exact STEP (ie. 21) increase until next STEP 25 (if possible) or Decrease to MAX if not possible
c. don't forget about numbers inversion logic.
d. show it ABOVE the Scale with little Apply button next to it inputs similar to shown example.

7. Dinamically determine and use Filter Step (Max values specified in Filter setting. ie 10)

Calulated MAX =< 10, then Step 5
Calulated MAX =< , then Step 5



NOTE: Our slice-up person will update CSS to remove Provided Scale since we'll be using NO scaled version.

User avatar (0004425)
alex (manager)
2012-01-20 07:50

done
User avatar (0004428)
Dmitry (manager)
2012-01-20 12:48

Looking good - one correction:

Can we please make so we show MIN and MAX (ie. 0 to 3000) by default in the Inputs.
User avatar (0004429)
alex (manager)
2012-01-20 14:04

done
User avatar (0004987)
alex (manager)
2012-07-25 05:31

Since 5.2.0 version was released.

- Related Changesets
Themes :: Modern-Store: 1.0.x r15094
Timestamp: 2012-01-20 14:04:01
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. diplay from/to value right away after page load
mod - /themes/modern-store/branches/1.0.x/elements/filters.elm.tpl Diff ] File ]
mod - /themes/modern-store/branches/1.0.x/inc/js/list_manager.js Diff ] File ]
Themes :: Modern-Store: 1.0.x r15092
Timestamp: 2012-01-20 07:49:00
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. keep max value of range filter in url (keeps correct item counts in blue part of range)
2. dynamically adjust slider range if max price is smaller, then slider step count
3. add from/to input boxes above slider for easy use
mod - /themes/modern-store/branches/1.0.x/elements/filters.elm.tpl Diff ] File ]
mod - /themes/modern-store/branches/1.0.x/inc/js/list_manager.js Diff ] File ]
In-Portal CMS: 5.2.x r15091
Timestamp: 2012-01-20 07:48:06
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. keep max value of range filter in url (keeps correct item counts in blue part of range)
2. dynamically adjust slider range if max price is smaller, then slider step count
mod - /in-portal/branches/5.2.x/core/units/filters/item_filter_tp.php Diff ] File ]
In-Portal CMS: 5.2.x r15086
Timestamp: 2012-01-18 09:30:05
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. dynamic filter height
2. display price for last range element
mod - /in-portal/branches/5.2.x/core/units/filters/item_filter_tp.php Diff ] File ]
In-Portal CMS: 5.2.x r15085
Timestamp: 2012-01-18 09:27:59
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. dynamic filter height
2. display price for last range element
mod - /in-portal/branches/5.2.x/core/units/filters/item_filter_tp.php Diff ] File ]
Modules :: In-Commerce: 5.2.x r15070
Timestamp: 2012-01-18 08:18:27
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. dynamic filter height
2. display price for last range element
mod - /w/in-commerce/branches/5.2.x/install/install_data.sql Diff ] File ]
Themes :: Modern-Store: 1.0.x r15068
Timestamp: 2012-01-18 06:17:17
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. dynamic filter height
2. display price for last range element
mod - /themes/modern-store/branches/1.0.x/elements/filters.elm.tpl Diff ] File ]
Themes :: Modern-Store: 1.0.x r15067
Timestamp: 2012-01-18 04:12:19
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. dynamic filter height
2. display price for last range element
mod - /themes/modern-store/branches/1.0.x/elements/filters.elm.tpl Diff ] File ]
In-Portal CMS: 5.2.x r15066
Timestamp: 2012-01-18 04:10:44
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. display integer prices
2. display currency sign
mod - /in-portal/branches/5.2.x/core/units/filters/item_filter_tp.php Diff ] File ]
In-Portal CMS: 5.2.x r15057
Timestamp: 2012-01-17 04:15:13
Author: alex
Details ] Diff ]
Bug 0001130: Price Filter
1. another algorithm of calculating range filter max value
mod - /in-portal/branches/5.2.x/core/units/filters/item_filter_tp.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:31 alex Note Added: 0004987
2012-07-25 05:31 alex Status resolved => closed
2012-01-20 14:04 alex Note Added: 0004429
2012-01-20 14:04 alex Status needs feedback => resolved
2012-01-20 14:04 alex Fixed in Version 5.2.0-B1 => 5.2.0-B2
2012-01-20 14:04 alex Resolution reopened => fixed
2012-01-20 14:04 alex Changeset attached 1.0.x r15094
2012-01-20 12:48 Dmitry Note Added: 0004428
2012-01-20 12:48 Dmitry Status resolved => needs feedback
2012-01-20 12:48 Dmitry Resolution fixed => reopened
2012-01-20 07:50 alex Note Added: 0004425
2012-01-20 07:50 alex Status needs work => resolved
2012-01-20 07:50 alex Resolution reopened => fixed
2012-01-20 07:49 alex Changeset attached 1.0.x r15092
2012-01-20 07:48 alex Changeset attached 5.2.x r15091
2012-01-18 09:30 alex Changeset attached 5.2.x r15086
2012-01-18 09:27 alex Changeset attached 5.2.x r15085
2012-01-18 08:18 alex Changeset attached 5.2.x r15070
2012-01-18 06:17 alex Changeset attached 1.0.x r15068
2012-01-18 04:12 alex Changeset attached 1.0.x r15067
2012-01-18 04:10 alex Changeset attached 5.2.x r15066
2012-01-17 18:07 Dmitry Note Edited: 0004423 View Revisions
2012-01-17 18:04 Dmitry Status needs feedback => needs work
2012-01-17 18:04 Dmitry Assigned To Dmitry => alex
2012-01-17 18:04 Dmitry Note Added: 0004423
2012-01-17 18:04 Dmitry Status resolved => needs feedback
2012-01-17 18:04 Dmitry Resolution fixed => reopened
2012-01-17 04:15 alex Status reviewed and tested => resolved
2012-01-17 04:15 alex Fixed in Version => 5.2.0-B1
2012-01-17 04:15 alex Resolution open => fixed
2012-01-17 04:15 alex Status needs testing => reviewed and tested
2012-01-17 04:15 alex Changeset attached 5.2.x r15057
2012-01-17 04:14 alex File Added: range_filter_algorithm2.patch
2012-01-17 04:11 alex Note Added: 0004421
2012-01-16 23:14 Dmitry Note Edited: 0004417 View Revisions
2012-01-16 18:09 Dmitry Note Added: 0004417
2011-12-21 11:19 alex Time Estimate Removed 3 =>
2011-12-21 11:19 alex Note Added: 0004295
2011-12-21 11:19 alex Assigned To => Dmitry
2011-12-21 11:19 alex Developer => alex
2011-12-21 11:19 alex Status active => needs testing
2011-10-22 05:28 alex Estimate Points => 2
2011-10-06 12:59 Dmitry Category General => Payment Gateways
2011-10-06 12:59 Dmitry Target Version 1.0.0 => 5.2.0
2011-10-06 12:57 Dmitry Project Modern-Store => In-Commerce
2011-09-30 12:06 Dmitry Time Estimate Added 3
2011-09-27 06:50 alex New Issue



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker