| Anonymous | Login | Signup for a new account | 2024-04-19 16:15 CDT | |
| Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
| Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
| ID | Category | Type | Reproducibility | Date Submitted | Last Update | ||
| 0001399 | [In-Portal CMS] Data Management | bug report | always | 2012-09-16 06:42 | 2013-01-02 11:25 | ||
| Reporter | alex | View Status | public | Project Name | In-Portal CMS | ||
| Assigned To | alex | Developer | |||||
| Priority | normal | Resolution | fixed | Fixed in Version | 5.3.0-B1 | ||
| Status | resolved | Product Version | 5.0.0 | Target Version | 5.3.0 | ||
| Time Estimate | No estimate | ||||||
| Summary | 0001399: Remove "ItemSQLs" from unit configs | ||||||
| Description |
There are 2 (among many) settings in unit config called: * ListSQLs * ItemSQLs These are respectively database queries to select a list of items (on grid template) and one item from a list (on editing template). Both database queries are usually the same and that's why there is a fallback, which tells that when ItemSQLs setting is missing, then ListSQLs setting is used instead. This is very good, but since we still have both ItemSQLs and ListSQLs present in most of unit configs, then replacing one database query will required twice same amount of PHP code because we need to change both settings. |
||||||
| Additional Information | |||||||
| Tags | No tags attached. | ||||||
| Reference | https://groups.google.com/d/topic/in-portal-dev/6VnUdTJLhV0/discussion | ||||||
| Change Log Message | Removes redundant ItemSQLs settings from unit configs | ||||||
| Estimate Points | 1 | ||||||
| Attached Files |
 itemsqls_removed_core.patch [^] (642,644 bytes) 2013-01-02 11:21 itemsqls_removed_modules.patch [^] (942,323 bytes) 2013-01-02 11:22 |
||||||
|
|
|||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
 (0005343)alex (manager) 2013-01-02 11:23 |
Done. I've also performed automated "Find & Replace" in all unit config files to make all of them look similar (code formatting mostly). |
|
(0005344) alex (manager) 2013-01-02 11:25 |
Fix committed to 5.3.x branch. Commit Message: Fixes 0001399: Remove "ItemSQLs" from unit configs |
|
Notes |
| Related Changesets |
|||
|
In-Portal CMS: 5.3.x r15659 Timestamp: 2013-01-02 11:25:37 Author: alex [ Details ] [ Diff ] |
Fixes 0001399: Remove "ItemSQLs" from unit configs | ||
| mod - /in-portal/branches/5.3.x/core/kernel/nparser/nparser_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/kernel/utility/formatters/formatters_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/admin/admin_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/ban_rules/ban_rules_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/captcha/captcha_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/categories/categories_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/category_items/category_items_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/config_search/config_search_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/configuration/configuration_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/content/content_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/country_states/country_states_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/custom_data/custom_data_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/custom_fields/custom_fields_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/email_events/email_events_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/email_queue/email_queue_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/favorites/favorites_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/fck/fck_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/files/files_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/filters/filters_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/forms/form_fields/form_fields_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/forms/form_submissions/form_submissions_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/forms/forms/forms_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/general/general_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/groups/groups_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/helpers/controls/controls_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/images/images_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/languages/languages_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/logs/change_logs/change_logs_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/logs/email_logs/email_logs_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/logs/search_logs/search_logs_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/logs/session_logs/session_logs_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/logs/system_logs/system_logs_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/mailing_lists/mailing_lists_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/modules/modules_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/page_revisions/page_revisions_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/pdf/pdf_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/permission_types/permission_types_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/permissions/permissions_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/phrases/phrases_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/priorites/priorites_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/promo_block_groups/promo_block_groups_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/promo_blocks/promo_blocks_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/related_searches/related_searches_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/relationship/relationship_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/reviews/reviews_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/scheduled_tasks/scheduled_tasks_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/sections/sections_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/selectors/selectors_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/site_domains/site_domains_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/skins/skins_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/spam_reports/spam_reports_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/spelling_dictionary/spelling_dictionary_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/statistics/statistics_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/stop_words/stop_words_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/structure/structure_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/stylesheets/stylesheets_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/system_event_subscriptions/system_event_subscriptions_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/theme_files/theme_files_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/themes/themes_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/thesaurus/thesaurus_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/translator/translator_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/user_groups/user_groups_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/user_profile/user_profile_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/users/users_config.php | [ Diff ] [ File ] | ||
| mod - /in-portal/branches/5.3.x/core/units/visits/visits_config.php | [ Diff ] [ File ] | ||
|
Modules :: In-News: 5.3.x r15658 Timestamp: 2013-01-02 11:25:18 Author: alex [ Details ] [ Diff ] |
Bug 0001399: Remove "ItemSQLs" from unit configs | ||
| mod - /modules/in-news/branches/5.3.x/units/articles/articles_config.php | [ Diff ] [ File ] | ||
|
Modules :: In-Link: 5.3.x r15657 Timestamp: 2013-01-02 11:25:04 Author: alex [ Details ] [ Diff ] |
Bug 0001399: Remove "ItemSQLs" from unit configs | ||
| mod - /modules/in-link/branches/5.3.x/units/l-visits/l-visits_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-link/branches/5.3.x/units/link_validation/link_validation_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-link/branches/5.3.x/units/links/links_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-link/branches/5.3.x/units/listing_types/listing_types_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-link/branches/5.3.x/units/listings/listings_config.php | [ Diff ] [ File ] | ||
|
Modules :: In-Commerce: 5.3.x r15656 Timestamp: 2013-01-02 11:24:49 Author: alex [ Details ] [ Diff ] |
Bug 0001399: Remove "ItemSQLs" from unit configs | ||
| mod - /w/in-commerce/branches/5.3.x/units/addresses/addresses_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/affiliate_payment_types/affiliate_payment_types_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/affiliate_payments/affiliate_payments_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/affiliate_plans/affiliate_plans_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/affiliate_plans_brackets/affiliate_plans_brackets_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/affiliate_plans_items/affiliate_plans_items_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/affiliates/affiliates_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/brackets/brackets_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/coupon_items/coupon_items_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/coupons/coupons_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/currencies/currencies_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/destinations/destinations_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/discount_items/discount_items_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/discounts/discounts_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/downloads/downloads_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/files/files_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/gateway_field_values/gateway_field_values_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/gateways/gateways_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/gift_certificates/gift_certificates_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/helpers/helpers_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/manufacturers/manufacturers_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/order_items/order_items_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/orders/orders_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/payment_type/payment_type_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/payment_type_currencies/payment_type_currencies_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/pricing/pricing_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/product_option_combinations/product_option_combinations_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/product_options/product_options_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/products/products_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/reports/reports_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/shipping/shipping_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/shipping_costs/shipping_costs_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/shipping_quote_engines/shipping_quote_engines_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/taxes/taxes_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/taxesdestinations/taxesdestinations_config.php | [ Diff ] [ File ] | ||
| mod - /w/in-commerce/branches/5.3.x/units/zones/zones_config.php | [ Diff ] [ File ] | ||
|
Modules :: In-Bulletin: 5.3.x r15655 Timestamp: 2013-01-02 11:24:32 Author: alex [ Details ] [ Diff ] |
Bug 0001399: Remove "ItemSQLs" from unit configs | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/censorship/censorship_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/emoticons/emoticons_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/helpers/helpers_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/poll_answers/poll_answers_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/poll_comments/poll_comments_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/polls/polls_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/posts/posts_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/private_message_body/private_message_body_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/private_messages/private_messages_config.php | [ Diff ] [ File ] | ||
| mod - /modules/in-bulletin/branches/5.3.x/units/topics/topics_config.php | [ Diff ] [ File ] | ||
|
Modules :: Custom: 1.3.x r15653 Timestamp: 2013-01-02 11:23:52 Author: alex [ Details ] [ Diff ] |
Bug 0001399: Remove "ItemSQLs" from unit configs | ||
| mod - /modules/custom/branches/1.3.x/units/helpers/helpers_config.php | [ Diff ] [ File ] | ||
| mod - /modules/custom/branches/1.3.x/units/sections/sections_config.php | [ Diff ] [ File ] | ||
| mod - /modules/custom/branches/1.3.x/units/widgets/widgets_config.php | [ Diff ] [ File ] | ||
| Related Changesets |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-01-02 11:25 | alex | Note Added: 0005344 | |
| 2013-01-02 11:25 | alex | Status | needs testing => resolved |
| 2013-01-02 11:25 | alex | Fixed in Version | => 5.3.0-B1 |
| 2013-01-02 11:25 | alex | Resolution | open => fixed |
| 2013-01-02 11:25 | alex | Changeset attached | 5.3.x r15659 |
| 2013-01-02 11:25 | alex | Changeset attached | 5.3.x r15658 |
| 2013-01-02 11:25 | alex | Changeset attached | 5.3.x r15657 |
| 2013-01-02 11:24 | alex | Changeset attached | 5.3.x r15656 |
| 2013-01-02 11:24 | alex | Changeset attached | 5.3.x r15655 |
| 2013-01-02 11:24 | alex | Changeset attached | 5.3.x r15654 |
| 2013-01-02 11:23 | alex | Changeset attached | 1.3.x r15653 |
| 2013-01-02 11:23 | alex | Note Added: 0005343 | |
| 2013-01-02 11:23 | alex | Developer | => alex |
| 2013-01-02 11:23 | alex | Status | needs work => needs testing |
| 2013-01-02 11:22 | alex | File Added: itemsqls_removed_modules.patch | |
| 2013-01-02 11:21 | alex | File Added: itemsqls_removed_core.patch | |
| 2012-12-03 13:49 | alex | Assigned To | => alex |
| 2012-12-03 13:49 | alex | Status | active => needs work |
| 2012-09-16 06:42 | alex | New Issue | |
| 2012-09-16 06:42 | alex | Reference | => https://groups.google.com/d/topic/in-portal-dev/6VnUdTJLhV0/discussion |
| 2012-09-16 06:42 | alex | Change Log Message | => Removes redundant ItemSQLs settings from unit configs |
| 2012-09-16 06:42 | alex | Estimate Points | => 1 |
|
Issue History |
| Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories |
Web Development by Intechnic
In-Portal Open Source CMS |
Copyright © 2000 - 2009 MantisBT Group
 |