In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1399 [In-Portal CMS] Data Management bug report always 2012-09-16 06:42 2013-01-02 11:25
alex  
alex  
normal  
resolved 5.0.0  
fixed  
 
none 5.3.0-B1  
https://groups.google.com/d/topic/in-portal-dev/6VnUdTJLhV0/discussion
Removes redundant ItemSQLs settings from unit configs
1
0001399: Remove "ItemSQLs" from unit configs
There are 2 (among many) settings in unit config called:

* ListSQLs
* ItemSQLs

These are respectively database queries to select a list of items (on grid template) and one item from a list (on editing template).
Both database queries are usually the same and that's why there is a fallback, which tells that when ItemSQLs setting is missing, then ListSQLs setting is used instead.

This is very good, but since we still have both ItemSQLs and ListSQLs present in most of unit configs, then replacing one database query will required twice same amount of PHP code because we need to change both settings.
patch itemsqls_removed_core.patch (642,644) 2013-01-02 11:21
http://tracker.in-portal.org/file_download.php?file_id=1896&type=bug
patch itemsqls_removed_modules.patch (942,323) 2013-01-02 11:22
http://tracker.in-portal.org/file_download.php?file_id=1897&type=bug
Issue History
2013-01-02 11:25 alex Note Added: 0005344
2013-01-02 11:25 alex Status needs testing => resolved
2013-01-02 11:25 alex Fixed in Version => 5.3.0-B1
2013-01-02 11:25 alex Resolution open => fixed
2013-01-02 11:25 alex Changeset attached 5.3.x r15659
2013-01-02 11:25 alex Changeset attached 5.3.x r15658
2013-01-02 11:25 alex Changeset attached 5.3.x r15657
2013-01-02 11:24 alex Changeset attached 5.3.x r15656
2013-01-02 11:24 alex Changeset attached 5.3.x r15655
2013-01-02 11:24 alex Changeset attached 5.3.x r15654
2013-01-02 11:23 alex Changeset attached 1.3.x r15653
2013-01-02 11:23 alex Note Added: 0005343
2013-01-02 11:23 alex Developer => alex
2013-01-02 11:23 alex Status needs work => needs testing
2013-01-02 11:22 alex File Added: itemsqls_removed_modules.patch
2013-01-02 11:21 alex File Added: itemsqls_removed_core.patch
2012-12-03 13:49 alex Assigned To => alex
2012-12-03 13:49 alex Status active => needs work
2012-09-16 06:42 alex New Issue
2012-09-16 06:42 alex Reference => https://groups.google.com/d/topic/in-portal-dev/6VnUdTJLhV0/discussion
2012-09-16 06:42 alex Change Log Message => Removes redundant ItemSQLs settings from unit configs
2012-09-16 06:42 alex Estimate Points => 1

Notes
(0005343)
alex   
2013-01-02 11:23   
Done. I've also performed automated "Find & Replace" in all unit config files to make all of them look similar (code formatting mostly).
(0005344)
alex   
2013-01-02 11:25   
Fix committed to 5.3.x branch. Commit Message:

Fixes 0001399: Remove "ItemSQLs" from unit configs