In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000822 [In-Portal CMS] Template System bug report always 2010-08-09 08:49 2011-03-30 09:53
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.2-B1
Status closed Product Version 5.1.0 Target Version 5.1.2
Time EstimateNo estimate
Summary 0000822: Email event translation not being validated before saving
Description We have various (around 130) emails (email events), that could be sent throughout the system, e.g. after user registration, order submit, etc.

When administrator, during email translation editing, accidentally damages one or more In-Portal tags in it, then such email won't be sent at all.

Even more, it will raise Fatal Error and PHP code after email sending won't be executed.

For example, when error is in ORDER.SUBMIT email event translation, then user's order stays in "Incomplete" status and won't move to "Pending" status, even, when it's payment was successful.

I propose we validate email event translation before allowing it to be saved back into database (by NParser::CompileRaw method). I don't think, that we should output fancy error messages, like NParser does. We could just show, that there are a "tag syntax error" in translation.
Additional Information
Tags No tags attached.
Change Log Message
Estimate Points 0
Attached Files patch file icon Email-event-translation-Validation-CORE.patch [^] (4,904 bytes) 2011-01-04 15:02 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0001327closed (5.2.0)alex Denying e-mail event produces fatal error (only on PHP < 5.3.0) 

-  Notes
User avatar (0003132)
alex (manager)
2011-01-05 03:46

Ok, but:
1. error message definition moved from event handler to unit config
2. was a notice, when event has no replacement tags
User avatar (0003133)
alex (manager)
2011-01-05 03:48

Fix committed to 5.1.x branch. Commit Message:

Fixes 0000822: Email event translation not being validated before saving
Commit on behalf of Dmitry
User avatar (0003370)
Dmitry (manager)
2011-03-30 09:53

Closing, since 5.1.2 release has been released.

- Related Changesets
In-Portal CMS: 5.1.x r14105
Timestamp: 2011-01-05 03:48:37
Author: alex
Details ] Diff ]
Fixes 0000822: Email event translation not being validated before saving
Commit on behalf of Dmitry
mod - /in-portal/branches/5.1.x/core/install/english.lang Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/email_events/email_events_config.php Diff ] File ]
mod - /in-portal/branches/5.1.x/core/units/email_events/email_events_event_handler.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-06-19 03:53 alex Relationship added related to 0001327
2011-03-30 09:53 Dmitry Note Added: 0003370
2011-03-30 09:53 Dmitry Status resolved => closed
2011-01-05 03:48 alex Note Added: 0003133
2011-01-05 03:48 alex Status reviewed and tested => resolved
2011-01-05 03:48 alex Fixed in Version => 5.1.2-B1
2011-01-05 03:48 alex Resolution open => fixed
2011-01-05 03:48 alex Assigned To !COMMUNITY => alex
2011-01-05 03:48 alex Changeset attached 5.1.x r14105
2011-01-05 03:46 alex Note Added: 0003132
2011-01-05 03:46 alex Status needs testing => reviewed and tested
2011-01-04 15:03 Dmitry Assigned To Dmitry => !COMMUNITY
2011-01-04 15:03 Dmitry Status needs work => needs testing
2011-01-04 15:02 Dmitry File Added: Email-event-translation-Validation-CORE.patch
2010-09-28 14:04 Dmitry Assigned To => Dmitry
2010-09-28 14:04 Dmitry Status active => needs work
2010-09-28 11:48 Dmitry Target Version Icebox => 5.1.2
2010-09-28 11:44 Dmitry Developer => Dmitry
2010-08-09 08:49 alex New Issue
2010-08-09 08:49 alex Reference =>

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker