In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0001327

[In-Portal CMS] Template System

bug report

always

2012-06-19 03:53

2012-07-25 05:29

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.0

Status

closed

Product Version

5.2.0-RC1

Target Version

5.2.0

Time Estimate

No estimate

Summary

0001327: Denying e-mail event produces fatal error (only on PHP < 5.3.0)

Description

In In-Portal 5.1.2 we've introduced e-mail event syntax check before saving (see 0000822) to prevent user from getting Fatal Error due incorrect template syntax when e-mail event will be sent.

However if you'll have a project were e-mail email events have template syntax errors in them and you upgrade this project to 5.1.2 then you still get Fatal Error, when trying to send out that e-mail event (because no automatic way to fix e-mails events, that are broken).
Also when trying to enable/disable these e-mail events from e-mail event list you'll get "Query method undefined" error and selected e-mail events will still be in same status as before.

Template syntax checking code was reworked in 5.2.0-RC1 to use PHP exceptions (http://lv.php.net/manual/en/language.exceptions.php), but by mistake this code was made PHP 5.3.0+ compatible only (see http://lv.php.net/manual/en/exception.construct.php) due $previous parameter usage, that was added only in PHP 5.3.0.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/HKg_H7M90qQ/discussion

Change Log Message

Fixes fatal error on e-mail event denial (on PHP 5.2.x)

Estimate Points

1

denying_email_event_produces_fatal_error.patch [^] (471 bytes) 2012-06-19 03:53 [Show Content]

Index: nparser.php
===================================================================
--- nparser.php	(revision 15412)
+++ nparser.php	(working copy)
@@ -1194,7 +1194,7 @@
 
 class ParserException extends Exception {
 
-	public function __construct($message = null, $code = 0, Exception $previous = null, $tag = null)
+	public function __construct($message = null, $code = 0, $previous = null, $tag = null)
 	{
 		parent::__construct($message, $code, $previous);

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

closed (5.1.2)

Email event translation not being validated before saving

Notes
(0004732) alex (manager) 2012-06-19 03:55	Will test all together later.

(0004733) alex (manager) 2012-06-19 03:55	Fix committed to 5.2.x branch. Commit Message: Fixes 0001327: Denying e-mail event produces fatal error (only on PHP < 5.3.0)

(0004859) alex (manager) 2012-07-25 05:29	Since 5.2.0 version was released.

Related Changesets
In-Portal CMS: 5.2.x r15413 Timestamp: 2012-06-19 03:55:47 Author: alex [ Details ] [ Diff ]	Fixes 0001327: Denying e-mail event produces fatal error (only on PHP < 5.3.0)
	mod - /in-portal/branches/5.2.x/core/kernel/nparser/nparser.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:29	alex	Note Added: 0004859
2012-07-25 05:29	alex	Status	resolved => closed
2012-06-19 03:55	alex	Changeset attached	5.2.x r15413
2012-06-19 03:55	alex	Note Added: 0004733
2012-06-19 03:55	alex	Status	reviewed and tested => resolved
2012-06-19 03:55	alex	Fixed in Version	=> 5.2.0
2012-06-19 03:55	alex	Resolution	open => fixed
2012-06-19 03:55	alex	Assigned To	!COMMUNITY => alex
2012-06-19 03:55	alex	Note Added: 0004732
2012-06-19 03:55	alex	Status	needs testing => reviewed and tested
2012-06-19 03:55	alex	Assigned To	=> !COMMUNITY
2012-06-19 03:55	alex	Developer	=> alex
2012-06-19 03:55	alex	Status	active => needs testing
2012-06-19 03:54	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/HKg_H7M90qQ/discussion
2012-06-19 03:53	alex	Relationship added	related to 0000822
2012-06-19 03:53	alex	New Issue
2012-06-19 03:53	alex	File Added: denying_email_event_produces_fatal_error.patch
2012-06-19 03:53	alex	Change Log Message	=> Fixes fatal error on e-mail event denial (on PHP 5.2.x)
2012-06-19 03:53	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group