In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ]  Related Changesets ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000572 [In-Portal CMS] Other bug report always 2010-02-06 14:13 2012-07-25 05:32
Reporter Dmitry View Status public Project Name In-Commerce
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0-B1
Status closed Product Version 5.0.2 Target Version 5.2.0
Time EstimateNo estimate
Summary 0000572: Refactor Currency Converter Class
Description All currency converter classes are located in same file, not in separate files as they should. Base currency converter class is named "kCurrencyRates" (starting with "k"), but it is not part of In-Portal distribution, and belongs to In-Commerce module, so "k" should be removed. Also this class is registered not in unit config, but in kApplication class directly.

At the end all classes from file "\in-commerce\units\currencies\currency_rates.php" should be moved to "\in-commerce\units\helpers" folder and named properly, because they are actually helpers.
Additional Information
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/e7c1b302931fee57?hl=en
Change Log Message Refactored Currency converter class
Estimate Points 1
Attached Files patch file icon refactor_currency_converter_core_572.patch [^] (562 bytes) 2011-12-06 07:57 [Show Content]
patch file icon refactor_currency_converter_modules_572.patch [^] (23,107 bytes) 2011-12-06 07:57 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0004209)
erik (manager)
2011-12-06 07:58

Patch attached - needs testing.
User avatar (0004215)
alex (manager)
2011-12-07 09:50

Fix committed to 5.2.x branch. Commit Message:

Fixes 0000572: Refactor Currency Converter Class
Commit on behalf of Erik
User avatar (0005036)
alex (manager)
2012-07-25 05:32

Since 5.2.0 version was released.

- Related Changesets
Modules :: In-Commerce: 5.2.x r14839
Timestamp: 2011-12-07 09:50:50
Author: alex
Details ] Diff ]
Fixes 0000572: Refactor Currency Converter Class
Commit on behalf of Erik
mod - /w/in-commerce/branches/5.2.x/units/currencies/currencies_config.php Diff ] File ]
rm - /w/in-commerce/branches/5.2.x/units/currencies/currency_rates.php
mod - /w/in-commerce/branches/5.2.x/units/gateways/gw_classes/gw_base.php Diff ] File ]
add - /w/in-commerce/branches/5.2.x/units/helpers/bank_lv_currency_rates.php File ]
add - /w/in-commerce/branches/5.2.x/units/helpers/currency_rates.php File ]
add - /w/in-commerce/branches/5.2.x/units/helpers/ecb_currency_rates.php File ]
add - /w/in-commerce/branches/5.2.x/units/helpers/frny_currency_rates.php File ]
mod - /w/in-commerce/branches/5.2.x/units/helpers/helpers_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/helpers/order_helper.php Diff ] File ]
mod - /w/in-commerce/branches/5.2.x/units/pricing/pricing_tag_processor.php Diff ] File ]
In-Portal CMS: 5.2.x r14838
Timestamp: 2011-12-07 09:49:32
Author: alex
Details ] Diff ]
Bug 0000572: Refactor Currency Converter Class
Commit on behalf of Erik
mod - /in-portal/branches/5.2.x/core/kernel/db/db_tag_processor.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:32 alex Note Added: 0005036
2012-07-25 05:32 alex Status resolved => closed
2011-12-07 09:50 alex Note Added: 0004215
2011-12-07 09:50 alex Status reviewed and tested => resolved
2011-12-07 09:50 alex Fixed in Version => 5.2.0-B1
2011-12-07 09:50 alex Resolution open => fixed
2011-12-07 09:50 alex Changeset attached 5.2.x r14839
2011-12-07 09:49 alex Changeset attached 5.2.x r14838
2011-12-07 09:47 alex Status needs testing => reviewed and tested
2011-12-06 07:58 erik Time Estimate Removed 1 =>
2011-12-06 07:58 erik Note Added: 0004209
2011-12-06 07:58 erik Assigned To erik => alex
2011-12-06 07:58 erik Developer => erik
2011-12-06 07:58 erik Status needs work => needs testing
2011-12-06 07:57 erik File Added: refactor_currency_converter_modules_572.patch
2011-12-06 07:57 erik File Added: refactor_currency_converter_core_572.patch
2011-11-06 15:57 Dmitry Change Log Message refactored Currency converter class => Refactored Currency converter class
2011-11-06 15:57 Dmitry Change Log Message => refactored Currency converter class
2011-11-06 15:57 Dmitry Assigned To => erik
2011-11-06 15:57 Dmitry Status active => needs work
2011-10-22 05:37 alex Estimate Points => 1
2011-09-27 05:28 alex Time Estimate Added 1
2011-09-23 21:52 Dmitry Target Version Icebox => 5.2.0
2010-02-06 14:13 Dmitry New Issue
2010-02-06 14:13 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/e7c1b302931fee57?hl=en



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker