|
In-Portal Issue Tracker - In-Commerce
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
572 |
[In-Portal CMS] Other |
bug report |
always |
2010-02-06 14:13 |
2012-07-25 05:32 |
|
|
Reporter:
|
Dmitry |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
closed |
Product Version:
|
5.0.2 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.2.0-B1 |
|
|
Reference:
|
http://groups.google.com/group/in-portal-dev/browse_thread/thread/e7c1b302931fee57?hl=en |
|
Change Log Message:
|
Refactored Currency converter class |
|
Estimate Points:
|
1 |
|
|
Summary:
|
0000572: Refactor Currency Converter Class |
|
Description:
|
All currency converter classes are located in same file, not in separate files as they should. Base currency converter class is named "kCurrencyRates" (starting with "k"), but it is not part of In-Portal distribution, and belongs to In-Commerce module, so "k" should be removed. Also this class is registered not in unit config, but in kApplication class directly.
At the end all classes from file "\in-commerce\units\currencies\currency_rates.php" should be moved to "\in-commerce\units\helpers" folder and named properly, because they are actually helpers. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | |
|
Attached Files:
|
 refactor_currency_converter_core_572.patch (562) 2011-12-06 07:57
http://tracker.in-portal.org/file_download.php?file_id=1346&type=bug
refactor_currency_converter_modules_572.patch (23,107) 2011-12-06 07:57
http://tracker.in-portal.org/file_download.php?file_id=1347&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2012-07-25 05:32 |
alex |
Note Added: 0005036 |
|
|
2012-07-25 05:32 |
alex |
Status |
resolved => closed |
|
2011-12-07 09:50 |
alex |
Note Added: 0004215 |
|
|
2011-12-07 09:50 |
alex |
Status |
reviewed and tested => resolved |
|
2011-12-07 09:50 |
alex |
Fixed in Version |
=> 5.2.0-B1 |
|
2011-12-07 09:50 |
alex |
Resolution |
open => fixed |
|
2011-12-07 09:50 |
alex |
Changeset attached |
5.2.x r14839 |
|
2011-12-07 09:49 |
alex |
Changeset attached |
5.2.x r14838 |
|
2011-12-07 09:47 |
alex |
Status |
needs testing => reviewed and tested |
|
2011-12-06 07:58 |
erik |
Time Estimate Removed |
1 => |
|
2011-12-06 07:58 |
erik |
Note Added: 0004209 |
|
|
2011-12-06 07:58 |
erik |
Assigned To |
erik => alex |
|
2011-12-06 07:58 |
erik |
Developer |
=> erik |
|
2011-12-06 07:58 |
erik |
Status |
needs work => needs testing |
|
2011-12-06 07:57 |
erik |
File Added: refactor_currency_converter_modules_572.patch |
|
|
2011-12-06 07:57 |
erik |
File Added: refactor_currency_converter_core_572.patch |
|
|
2011-11-06 15:57 |
Dmitry |
Change Log Message |
refactored Currency converter class => Refactored Currency converter class |
|
2011-11-06 15:57 |
Dmitry |
Change Log Message |
=> refactored Currency converter class |
|
2011-11-06 15:57 |
Dmitry |
Assigned To |
=> erik |
|
2011-11-06 15:57 |
Dmitry |
Status |
active => needs work |
|
2011-10-22 05:37 |
alex |
Estimate Points |
=> 1 |
|
2011-09-27 05:28 |
alex |
Time Estimate Added |
1 |
|
2011-09-23 21:52 |
Dmitry |
Target Version |
Icebox => 5.2.0 |
|
2010-02-06 14:13 |
Dmitry |
New Issue |
|
|
2010-02-06 14:13 |
Dmitry |
Reference |
=> http://groups.google.com/group/in-portal-dev/browse_thread/thread/e7c1b302931fee57?hl=en |