In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
ID: Category: Type: Reproducibility: Date Submitted: Last Update:
255 [In-Portal CMS] Mailing System bug report always 2009-09-01 22:25 2009-10-03 07:57
Reporter: Dmitry Platform:  
Assigned To: alex OS:  
Priority: normal OS Version:  
Status: closed Product Version: 4.3.9  
Product Build: Resolution: fixed  
 
ETA: none Fixed in Version: 5.0.1  
Reference:
Change Log Message:
Estimate Points: 0
Summary: 0000255: Find and list Missing Email Events
Description: It was noticed that there might some Email Event that are missing in default installation of In-Portal. Example, TOPIC.ADD.PENDING

We need carefully review current email events so we can Find and Add missing ones to the default installation.

Make sure to list here all the Events that you'll be adding so I can work on translation straight away.
Steps To Reproduce:
Additional Information:
Relationships
Attached Files:
Issue History
Date Modified Username Field Change
2009-10-03 07:57 administrator Note Added: 0000753
2009-10-03 07:57 administrator Status resolved => closed
2009-09-08 10:14 alex Fixed in Version => 5.0.1
2009-09-08 10:14 alex Note Added: 0000415
2009-09-08 10:14 alex Status reviewed and tested => resolved
2009-09-08 10:14 alex Resolution open => fixed
2009-09-08 10:14 alex Changeset attached 5.0.x r12466
2009-09-08 10:09 alex Changeset attached 5.0.x r12465
2009-09-08 10:08 alex Changeset attached 5.0.x r12464
2009-09-08 10:08 alex Changeset attached 5.0.x r12463
2009-09-08 10:07 alex Changeset attached 5.0.x r12462
2009-09-04 17:20 Dmitry Note Added: 0000398
2009-09-04 17:20 Dmitry Assigned To Dmitry => alex
2009-09-04 17:20 Dmitry Status needs work => reviewed and tested
2009-09-04 17:19 Dmitry Status needs feedback => needs work
2009-09-03 11:53 Dmitry Note Added: 0000382
2009-09-03 11:52 Dmitry Changeset attached 5.0.x r12433
2009-09-03 11:52 Dmitry Changeset attached 5.0.x r12432
2009-09-03 11:52 Dmitry Changeset attached 5.0.x r12431
2009-09-03 11:51 Dmitry Changeset attached 5.0.x r12430
2009-09-03 01:47 alex Note Added: 0000380
2009-09-03 01:47 alex Assigned To alex => Dmitry
2009-09-03 01:47 alex Status reviewed and tested => needs feedback
2009-09-02 21:19 Dmitry Changeset attached 5.0.x r12427
2009-09-02 21:11 Dmitry Status needs work => reviewed and tested
2009-09-02 21:11 Dmitry Note Added: 0000379
2009-09-02 21:11 Dmitry Assigned To Dmitry => alex
2009-09-02 21:11 Dmitry Status needs feedback => needs work
2009-09-02 21:10 Dmitry Changeset attached 5.0.x r12426
2009-09-02 21:10 Dmitry Changeset attached 5.0.x r12425
2009-09-02 21:09 Dmitry Changeset attached 5.0.x r12424
2009-09-02 21:08 Dmitry Changeset attached 5.0.x r12423
2009-09-02 21:08 Dmitry Changeset attached 5.0.x r12422
2009-09-02 19:34 Dmitry Note Added: 0000378
2009-09-02 04:49 alex Note Added: 0000374
2009-09-02 04:49 alex Assigned To alex => Dmitry
2009-09-02 04:49 alex Status reviewed and tested => needs feedback
2009-09-01 22:25 Dmitry New Issue
2009-09-01 22:25 Dmitry Status active => reviewed and tested
2009-09-01 22:25 Dmitry Assigned To => alex

Notes
(0000374)
alex   
2009-09-02 04:49   
Missing event name phrase translation:
LINK.OWNER.MODIFY (2x)
LINK.OWNER.MODIFY.PENDING (2x)

Missing (but called) email events (Events table)
TOPIC.APPROVE (user)
TOPIC.ADD (user)
TOPIC.ADD.PENDING (admin, user)
TOPIC.MODIFY (admin, user)
TOPIC.MODIFY.PENDING (admin, user)

There are also some events, that are not used. Please delete them or tell what of them should be implemented:
USER.SUGGEST (admin)
PRODUCT.SUGGEST (admin)
CATEGORY.APPROVE (admin, user)
CATEGORY.DENY (admin, user)
CATEGORY.MODIFY (admin, user)
CATEGORY.DELETE (admin, user)
LINK.MODIFY.APPROVE (user)
LINK.MODIFY.DENY (user)
LINK.OWNER.MODIFY (admin, user) - I think, that LINK.MODIFY event will do pretty much the same
LINK.OWNER.MODIFY.PENDING (admin, user) - I think, that LINK.MODIFY.PENDING event will do pretty much the same
LINK.REVIEW.ADD (admin, user)
LINK.REVIEW.ADD.PENDING (user)
LINK.REVIEW.APPROVE (user)
LINK.REVIEW.DENY (user)
NEWS.MODIFY.APPROVE (user)
NEWS.MODIFY.DENY (user)
NEWS.REVIEW.ADD (admin, user)
NEWS.REVIEW.ADD.PENDING (user)
NEWS.REVIEW.APPROVE (user)
NEWS.REVIEW.DENY (user)
NEWS.OWNER.MODIFY (admin, user)
NEWS.OWNER.MODIFY.PENDING (admin, user)
PM.ADD (user)
POST.MODIFY (admin)
SITE.SUGGEST (admin, user) - from in-commerce

There are also some strange event in FormsEventHandler::OnFormSubmit which is not present in mapPermissions method, neither is a hook to other event, that means, that it can't be called. But this event send email event speicifed in hidden field. I you have any idea about purpose of that event, then we will keep it, but I think, that we should delete it.

Event BACKORDER.FULLFILL is marked as "user" in database, but is called via EmailEventAdmin and never gets sent.

When listing (what makes link enhanced) is deleted, then email event is sent using this line:
$email_event = $object->GetDBField('Status') ? 'LINK.ENHANCE.APPROVE' : 'LINK.ENHANCE.APPROVE';
Strange line, maybe we should send 'LINK.ENHANCE.DENY' event, when is declined status (ListingsEventHandler::OnBeforeDeleteFromLive).
(0000378)
Dmitry   
2009-09-02 19:34   
1. ADD Missing Processing (TODO)
========================
USER.SUGGEST (admin)
PRODUCT.SUGGEST (admin)
LINK.MODIFY.APPROVE (user)
LINK.MODIFY.DENY (user)

CATEGORY.APPROVE (admin, user)
CATEGORY.DENY (admin, user)

LINK.REVIEW.ADD (admin, user)
LINK.REVIEW.ADD.PENDING (user, ADMIN) -- Note that you need you need to add Admin event too - copy content from User type for now.

LINK.REVIEW.APPROVE (user)
LINK.REVIEW.DENY (user)


NEWS.MODIFY.APPROVE (user)
NEWS.MODIFY.DENY (user)

NEWS.REVIEW.ADD (admin, user)
NEWS.REVIEW.ADD.PENDING (user, ADMIN) -- Note that you need you need to add Admin event too - copy content from User type for now.

NEWS.REVIEW.APPROVE (user)
NEWS.REVIEW.DENY (user)

PM.ADD (user)
POST.MODIFY (admin)



2. Missing Events to DELETE in Lang. Packs + Events table (DONE)
=========================================================
CATEGORY.MODIFY (admin, user)
CATEGORY.DELETE (admin, user)

LINK.OWNER.MODIFY (admin, user)
LINK.OWNER.MODIFY.PENDING (admin, user)

NEWS.OWNER.MODIFY (admin, user)
NEWS.OWNER.MODIFY.PENDING (admin, user)

SITE.SUGGEST (admin, user) - from in-commerce

'la_event_category.modify', 'la_event_category_delete', 'la_event_link.owner.modify', 'la_event_link.owner.modify.pending', 'la_event_news.owner.modify', 'la_event_news.owner.modify.pending', 'la_event_user.suggest_site'



3. Missing Events to ADD to Lang. Pack + Events table (DONE)
=====================================================
TOPIC.APPROVE (user)
TOPIC.ADD (user)
TOPIC.ADD.PENDING (admin, user)
TOPIC.MODIFY (admin, user)
TOPIC.MODIFY.PENDING (admin, user)


4. Change BACKORDER.FULLFILL to Admin (install + upgrade sqls) (DONE)
============================


5. Change to LINK.ENHANCE.DENY in (DONE)
=================================
$email_event = $object->GetDBField('Status') ? 'LINK.ENHANCE.APPROVE' : 'LINK.ENHANCE.APPROVE';

for Status != 1.
(0000379)
Dmitry   
2009-09-02 21:11   
Left to do here - 1. ADD Missing Processing (TODO)
(0000380)
alex   
2009-09-03 01:47   
1. You should write upgrades.php script for other modules as well (where events are deleted).
2. There is an error in mentioned below change:
[url]http://source.in-portal.org/in-portal/branches/5.0.x/core/install/upgrades.php?r1=12421&r2=12422&pathrev=12422[url]

a. incorrect table names
b. table prefix not used in database query
c. incorrect tabulation of database queries (missing 1 tab on each line)
(0000382)
Dmitry   
2009-09-03 11:53   
All corrected now.
(0000398)
Dmitry   
2009-09-04 17:20   
1. ADD Missing Processing (TODO)
(0000415)
alex   
2009-09-08 10:14   
Fix committed to 5.0.x branch. Commit Message:

1. Fixes 0000255: Find and list Missing Email Events
2. Email event name is sent as special header in email message (while in debug mode).
(0000753)
administrator   
2009-10-03 07:57   
Closing issues from 5.0.1 version, because version was already released.