In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!
Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]  [ Related Changesets ] [ View Advanced ] [ Issue History ] [ Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000255 [In-Portal CMS] Mailing System bug report always 2009-09-01 22:25 2009-10-03 07:57
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.0.1
Status closed Product Version 4.3.9 Target Version 5.0.1
Time EstimateNo estimate
Summary 0000255: Find and list Missing Email Events
Description It was noticed that there might some Email Event that are missing in default installation of In-Portal. Example, TOPIC.ADD.PENDING

We need carefully review current email events so we can Find and Add missing ones to the default installation.

Make sure to list here all the Events that you'll be adding so I can work on translation straight away.
Additional Information
Tags No tags attached.
Reference
Change Log Message
Estimate Points 0
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
User avatar (0000374)
alex (manager)
2009-09-02 04:49

 Missing event name phrase translation:
LINK.OWNER.MODIFY (2x)
LINK.OWNER.MODIFY.PENDING (2x)

Missing (but called) email events (Events table)
TOPIC.APPROVE (user)
TOPIC.ADD (user)
TOPIC.ADD.PENDING (admin, user)
TOPIC.MODIFY (admin, user)
TOPIC.MODIFY.PENDING (admin, user)

There are also some events, that are not used. Please delete them or tell what of them should be implemented:
USER.SUGGEST (admin)
PRODUCT.SUGGEST (admin)
CATEGORY.APPROVE (admin, user)
CATEGORY.DENY (admin, user)
CATEGORY.MODIFY (admin, user)
CATEGORY.DELETE (admin, user)
LINK.MODIFY.APPROVE (user)
LINK.MODIFY.DENY (user)
LINK.OWNER.MODIFY (admin, user) - I think, that LINK.MODIFY event will do pretty much the same
LINK.OWNER.MODIFY.PENDING (admin, user) - I think, that LINK.MODIFY.PENDING event will do pretty much the same
LINK.REVIEW.ADD (admin, user)
LINK.REVIEW.ADD.PENDING (user)
LINK.REVIEW.APPROVE (user)
LINK.REVIEW.DENY (user)
NEWS.MODIFY.APPROVE (user)
NEWS.MODIFY.DENY (user)
NEWS.REVIEW.ADD (admin, user)
NEWS.REVIEW.ADD.PENDING (user)
NEWS.REVIEW.APPROVE (user)
NEWS.REVIEW.DENY (user)
NEWS.OWNER.MODIFY (admin, user)
NEWS.OWNER.MODIFY.PENDING (admin, user)
PM.ADD (user)
POST.MODIFY (admin)
SITE.SUGGEST (admin, user) - from in-commerce

There are also some strange event in FormsEventHandler::OnFormSubmit which is not present in mapPermissions method, neither is a hook to other event, that means, that it can't be called. But this event send email event speicifed in hidden field. I you have any idea about purpose of that event, then we will keep it, but I think, that we should delete it.

Event BACKORDER.FULLFILL is marked as "user" in database, but is called via EmailEventAdmin and never gets sent.

When listing (what makes link enhanced) is deleted, then email event is sent using this line:
$email_event = $object->GetDBField('Status') ? 'LINK.ENHANCE.APPROVE' : 'LINK.ENHANCE.APPROVE';
Strange line, maybe we should send 'LINK.ENHANCE.DENY' event, when is declined status (ListingsEventHandler::OnBeforeDeleteFromLive).
User avatar (0000378)
Dmitry (manager)
2009-09-02 19:34

 1. ADD Missing Processing (TODO)
========================
USER.SUGGEST (admin)
PRODUCT.SUGGEST (admin)
LINK.MODIFY.APPROVE (user)
LINK.MODIFY.DENY (user)

CATEGORY.APPROVE (admin, user)
CATEGORY.DENY (admin, user)

LINK.REVIEW.ADD (admin, user)
LINK.REVIEW.ADD.PENDING (user, ADMIN) -- Note that you need you need to add Admin event too - copy content from User type for now.

LINK.REVIEW.APPROVE (user)
LINK.REVIEW.DENY (user)


NEWS.MODIFY.APPROVE (user)
NEWS.MODIFY.DENY (user)

NEWS.REVIEW.ADD (admin, user)
NEWS.REVIEW.ADD.PENDING (user, ADMIN) -- Note that you need you need to add Admin event too - copy content from User type for now.

NEWS.REVIEW.APPROVE (user)
NEWS.REVIEW.DENY (user)

PM.ADD (user)
POST.MODIFY (admin)



2. Missing Events to DELETE in Lang. Packs + Events table (DONE)
=========================================================
CATEGORY.MODIFY (admin, user)
CATEGORY.DELETE (admin, user)

LINK.OWNER.MODIFY (admin, user)
LINK.OWNER.MODIFY.PENDING (admin, user)

NEWS.OWNER.MODIFY (admin, user)
NEWS.OWNER.MODIFY.PENDING (admin, user)

SITE.SUGGEST (admin, user) - from in-commerce

'la_event_category.modify', 'la_event_category_delete', 'la_event_link.owner.modify', 'la_event_link.owner.modify.pending', 'la_event_news.owner.modify', 'la_event_news.owner.modify.pending', 'la_event_user.suggest_site'



3. Missing Events to ADD to Lang. Pack + Events table (DONE)
=====================================================
TOPIC.APPROVE (user)
TOPIC.ADD (user)
TOPIC.ADD.PENDING (admin, user)
TOPIC.MODIFY (admin, user)
TOPIC.MODIFY.PENDING (admin, user)


4. Change BACKORDER.FULLFILL to Admin (install + upgrade sqls) (DONE)
============================


5. Change to LINK.ENHANCE.DENY in (DONE)
=================================
$email_event = $object->GetDBField('Status') ? 'LINK.ENHANCE.APPROVE' : 'LINK.ENHANCE.APPROVE';

for Status != 1.
User avatar (0000379)
Dmitry (manager)
2009-09-02 21:11

 Left to do here - 1. ADD Missing Processing (TODO)
User avatar (0000380)
alex (manager)
2009-09-03 01:47

 1. You should write upgrades.php script for other modules as well (where events are deleted).
2. There is an error in mentioned below change:
[url]http://source.in-portal.org/in-portal/branches/5.0.x/core/install/upgrades.php?r1=12421&r2=12422&pathrev=12422[url]

a. incorrect table names
b. table prefix not used in database query
c. incorrect tabulation of database queries (missing 1 tab on each line)
User avatar (0000382)
Dmitry (manager)
2009-09-03 11:53

 All corrected now.
User avatar (0000398)
Dmitry (manager)
2009-09-04 17:20

 1. ADD Missing Processing (TODO)
User avatar (0000415)
alex (manager)
2009-09-08 10:14

 Fix committed to 5.0.x branch. Commit Message:

1. Fixes 0000255: Find and list Missing Email Events
2. Email event name is sent as special header in email message (while in debug mode).
User avatar (0000753)
administrator (administrator)
2009-10-03 07:57

 Closing issues from 5.0.1 version, because version was already released.

- Related Changesets
In-Portal CMS: 5.0.x r12466
Timestamp: 2009-09-08 10:14:28
Author: alex
[ Details ] [ Diff ] 		1. Fixes 0000255: Find and list Missing Email Events
2. Email event name is sent as special header in email message (while in debug mode).
mod - /in-portal/branches/5.0.x/core/install/english.lang [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/install/install_data.sql [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/install/upgrades.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/kernel/db/cat_dbitem.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/kernel/languages/phrases_cache.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/categories/categories_event_handler.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/email_events/email_events_event_handler.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/reviews/reviews_event_handler.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/units/users/users_event_handler.php [ Diff ] [ File ]
Modules :: In-News: 5.0.x r12465
Timestamp: 2009-09-08 10:09:04
Author: alex
[ Details ] [ Diff ] 		Bug 0000255: Find and list Missing Email Events
mod - /in-news/branches/5.0.x/in-news/install/english.lang [ Diff ] [ File ]
mod - /in-news/branches/5.0.x/in-news/install/install_data.sql [ Diff ] [ File ]
mod - /in-news/branches/5.0.x/in-news/install/upgrades.sql [ Diff ] [ File ]
Modules :: In-Link: 5.0.x r12464
Timestamp: 2009-09-08 10:08:49
Author: alex
[ Details ] [ Diff ] 		Bug 0000255: Find and list Missing Email Events
mod - /in-link/branches/5.0.x/in-link/install/english.lang [ Diff ] [ File ]
mod - /in-link/branches/5.0.x/in-link/install/install_data.sql [ Diff ] [ File ]
mod - /in-link/branches/5.0.x/in-link/install/upgrades.sql [ Diff ] [ File ]
Modules :: In-Commerce: 5.0.x r12463
Timestamp: 2009-09-08 10:08:22
Author: alex
[ Details ] [ Diff ] 		Bug 0000255: Find and list Missing Email Events
mod - /in-commerce/branches/5.0.x/in-commerce/units/products/products_event_handler.php [ Diff ] [ File ]
Modules :: In-Bulletin: 5.0.x r12462
Timestamp: 2009-09-08 10:07:28
Author: alex
[ Details ] [ Diff ] 		Bug 0000255: Find and list Missing Email Events
mod - /in-bulletin/branches/5.0.x/in-bulletin/units/posts/post_eh.php [ Diff ] [ File ]
mod - /in-bulletin/branches/5.0.x/in-bulletin/units/private_messages/private_message_eh.php [ Diff ] [ File ]
Modules :: In-News: 5.0.x r12433
Timestamp: 2009-09-03 11:52:50
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Minor fixes to Events Clean up (committed earlier)
mod - /in-news/branches/5.0.x/in-news/install/upgrades.php [ Diff ] [ File ]
mod - /in-news/branches/5.0.x/in-news/install/upgrades.sql [ Diff ] [ File ]
Modules :: In-Link: 5.0.x r12432
Timestamp: 2009-09-03 11:52:40
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Minor fixes to Events Clean up (committed earlier)
mod - /in-link/branches/5.0.x/in-link/install/upgrades.php [ Diff ] [ File ]
mod - /in-link/branches/5.0.x/in-link/install/upgrades.sql [ Diff ] [ File ]
Modules :: In-Commerce: 5.0.x r12431
Timestamp: 2009-09-03 11:52:28
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Minor fixes to Events Clean up (committed earlier)
mod - /in-commerce/branches/5.0.x/in-commerce/install/upgrades.php [ Diff ] [ File ]
mod - /in-commerce/branches/5.0.x/in-commerce/install/upgrades.sql [ Diff ] [ File ]
In-Portal CMS: 5.0.x r12430
Timestamp: 2009-09-03 11:51:54
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Minor fixes to Events Clean up (committed earlier)
mod - /in-portal/branches/5.0.x/core/install/upgrades.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/install/upgrades.sql [ Diff ] [ File ]
Modules :: In-Bulletin: 5.0.x r12427
Timestamp: 2009-09-02 21:19:24
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Minor fix
mod - /in-bulletin/branches/5.0.x/in-bulletin/install/english.lang [ Diff ] [ File ]
Modules :: In-News: 5.0.x r12426
Timestamp: 2009-09-02 21:10:55
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Clean old Events
mod - /in-news/branches/5.0.x/in-news/install/english.lang [ Diff ] [ File ]
mod - /in-news/branches/5.0.x/in-news/install/install_data.sql [ Diff ] [ File ]
mod - /in-news/branches/5.0.x/in-news/install/upgrades.php [ Diff ] [ File ]
mod - /in-news/branches/5.0.x/in-news/install/upgrades.sql [ Diff ] [ File ]
Modules :: In-Link: 5.0.x r12425
Timestamp: 2009-09-02 21:10:42
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Clean old Events
3. Fix "LINK.ENHANCE.DENY" in ListingsEventHandler::OnBeforeDeleteFromLive
mod - /in-link/branches/5.0.x/in-link/install/english.lang [ Diff ] [ File ]
mod - /in-link/branches/5.0.x/in-link/install/install_data.sql [ Diff ] [ File ]
mod - /in-link/branches/5.0.x/in-link/install/upgrades.php [ Diff ] [ File ]
mod - /in-link/branches/5.0.x/in-link/install/upgrades.sql [ Diff ] [ File ]
mod - /in-link/branches/5.0.x/in-link/units/listings/listings_event_handler.php [ Diff ] [ File ]
Modules :: In-Commerce: 5.0.x r12424
Timestamp: 2009-09-02 21:09:16
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Clean old Events
mod - /in-commerce/branches/5.0.x/in-commerce/install/english.lang [ Diff ] [ File ]
mod - /in-commerce/branches/5.0.x/in-commerce/install/install_data.sql [ Diff ] [ File ]
mod - /in-commerce/branches/5.0.x/in-commerce/install/upgrades.php [ Diff ] [ File ]
mod - /in-commerce/branches/5.0.x/in-commerce/install/upgrades.sql [ Diff ] [ File ]
Modules :: In-Bulletin: 5.0.x r12423
Timestamp: 2009-09-02 21:08:55
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Add Missing Events
mod - /in-bulletin/branches/5.0.x/in-bulletin/install/english.lang [ Diff ] [ File ]
mod - /in-bulletin/branches/5.0.x/in-bulletin/install/install_data.sql [ Diff ] [ File ]
mod - /in-bulletin/branches/5.0.x/in-bulletin/install/upgrades.sql [ Diff ] [ File ]
In-Portal CMS: 5.0.x r12422
Timestamp: 2009-09-02 21:08:27
Author: Dmitry
[ Details ] [ Diff ] 		1. Bug 0000255: Find and list Missing Email Events
2. Clean old Events
mod - /in-portal/branches/5.0.x/core/install/english.lang [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/install/install_data.sql [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/install/upgrades.php [ Diff ] [ File ]
mod - /in-portal/branches/5.0.x/core/install/upgrades.sql [ Diff ] [ File ]

- Issue History
Date Modified Username Field Change
2009-10-03 07:57 administrator Note Added: 0000753
2009-10-03 07:57 administrator Status resolved => closed
2009-09-08 10:14 alex Fixed in Version => 5.0.1
2009-09-08 10:14 alex Note Added: 0000415
2009-09-08 10:14 alex Status reviewed and tested => resolved
2009-09-08 10:14 alex Resolution open => fixed
2009-09-08 10:14 alex Changeset attached 5.0.x r12466
2009-09-08 10:09 alex Changeset attached 5.0.x r12465
2009-09-08 10:08 alex Changeset attached 5.0.x r12464
2009-09-08 10:08 alex Changeset attached 5.0.x r12463
2009-09-08 10:07 alex Changeset attached 5.0.x r12462
2009-09-04 17:20 Dmitry Note Added: 0000398
2009-09-04 17:20 Dmitry Assigned To Dmitry => alex
2009-09-04 17:20 Dmitry Status needs work => reviewed and tested
2009-09-04 17:19 Dmitry Status needs feedback => needs work
2009-09-03 11:53 Dmitry Note Added: 0000382
2009-09-03 11:52 Dmitry Changeset attached 5.0.x r12433
2009-09-03 11:52 Dmitry Changeset attached 5.0.x r12432
2009-09-03 11:52 Dmitry Changeset attached 5.0.x r12431
2009-09-03 11:51 Dmitry Changeset attached 5.0.x r12430
2009-09-03 01:47 alex Note Added: 0000380
2009-09-03 01:47 alex Assigned To alex => Dmitry
2009-09-03 01:47 alex Status reviewed and tested => needs feedback
2009-09-02 21:19 Dmitry Changeset attached 5.0.x r12427
2009-09-02 21:11 Dmitry Status needs work => reviewed and tested
2009-09-02 21:11 Dmitry Note Added: 0000379
2009-09-02 21:11 Dmitry Assigned To Dmitry => alex
2009-09-02 21:11 Dmitry Status needs feedback => needs work
2009-09-02 21:10 Dmitry Changeset attached 5.0.x r12426
2009-09-02 21:10 Dmitry Changeset attached 5.0.x r12425
2009-09-02 21:09 Dmitry Changeset attached 5.0.x r12424
2009-09-02 21:08 Dmitry Changeset attached 5.0.x r12423
2009-09-02 21:08 Dmitry Changeset attached 5.0.x r12422
2009-09-02 19:34 Dmitry Note Added: 0000378
2009-09-02 04:49 alex Note Added: 0000374
2009-09-02 04:49 alex Assigned To alex => Dmitry
2009-09-02 04:49 alex Status reviewed and tested => needs feedback
2009-09-01 22:25 Dmitry New Issue
2009-09-01 22:25 Dmitry Status active => reviewed and tested
2009-09-01 22:25 Dmitry Assigned To => alex

Main | My View | View Issues | Change Log | Roadmap | Docs | Wiki | Repositories
  

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker