|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
1414 |
[In-Portal CMS] Data Management |
refactoring |
always |
2012-10-18 10:27 |
2012-10-18 10:30 |
|
|
Reporter:
|
alex |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
resolved |
Product Version:
|
5.2.0 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.2.1-B1 |
|
|
Reference:
|
https://groups.google.com/d/topic/in-portal-dev/52BfiUOrlPw/discussion |
|
Change Log Message:
|
Adds new function for centralized resource limit setting |
|
Estimate Points:
|
1 |
|
|
Summary:
|
0001414: Centralize code for resource limit setting |
|
Description:
|
Right now following code is copy-pasted in multiple places in In-Portal:
set_time_limit(0);
ini_set('memory_limit', -1);
I propose, that we can move it into a new function and use it instead in all places. Here are the benefits:
* it's auto-completed, so less chances to make typo error in setting name
* we can add parameters to it allowing setting custom memory & time limits
* we can easily track all code, that uses it to determine code, which heavily uses system resources |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | | related to | 0001362 | resolved (5.2.1) | alex | Use even more secure password hashing algorithm |
|
|
Attached Files:
|
 resource_limit_core.patch (3,899) 2012-10-18 10:27
http://tracker.in-portal.org/file_download.php?file_id=1831&type=bug
resource_limit_modules.patch (1,160) 2012-10-18 10:28
http://tracker.in-portal.org/file_download.php?file_id=1832&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2012-10-18 10:30 |
alex |
Changeset attached |
5.2.x r15588 |
|
2012-10-18 10:30 |
alex |
Note Added: 0005233 |
|
|
2012-10-18 10:30 |
alex |
Status |
reviewed and tested => resolved |
|
2012-10-18 10:30 |
alex |
Fixed in Version |
=> 5.2.1-B1 |
|
2012-10-18 10:30 |
alex |
Resolution |
open => fixed |
|
2012-10-18 10:30 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2012-10-18 10:30 |
alex |
Changeset attached |
5.2.x r15587 |
|
2012-10-18 10:29 |
alex |
Relationship added |
related to 0001362 |
|
2012-10-18 10:29 |
alex |
Note Added: 0005232 |
|
|
2012-10-18 10:29 |
alex |
Status |
needs testing => reviewed and tested |
|
2012-10-18 10:29 |
alex |
Assigned To |
=> !COMMUNITY |
|
2012-10-18 10:29 |
alex |
Developer |
=> alex |
|
2012-10-18 10:29 |
alex |
Status |
active => needs testing |
|
2012-10-18 10:29 |
alex |
Reference |
=> https://groups.google.com/d/topic/in-portal-dev/52BfiUOrlPw/discussion |
|
2012-10-18 10:28 |
alex |
File Added: resource_limit_modules.patch |
|
|
2012-10-18 10:27 |
alex |
New Issue |
|
|
2012-10-18 10:27 |
alex |
File Added: resource_limit_core.patch |
|
|
2012-10-18 10:27 |
alex |
Change Log Message |
=> Adds new function for centralized resource limit setting |
|
2012-10-18 10:27 |
alex |
Estimate Points |
=> 1 |