In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001414 [In-Portal CMS] Data Management refactoring always 2012-10-18 10:27 2012-10-18 10:30
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.1-B1
Status resolved Product Version 5.2.0 Target Version 5.2.1
Time EstimateNo estimate
Summary 0001414: Centralize code for resource limit setting
Description Right now following code is copy-pasted in multiple places in In-Portal:

set_time_limit(0);
ini_set('memory_limit', -1);

I propose, that we can move it into a new function and use it instead in all places. Here are the benefits:

* it's auto-completed, so less chances to make typo error in setting name
* we can add parameters to it allowing setting custom memory & time limits
* we can easily track all code, that uses it to determine code, which heavily uses system resources
Additional Information
Tags No tags attached.
Reference https://groups.google.com/d/topic/in-portal-dev/52BfiUOrlPw/discussion
Change Log Message Adds new function for centralized resource limit setting
Estimate Points 1
Attached Files patch file icon resource_limit_core.patch [^] (3,899 bytes) 2012-10-18 10:27 [Show Content]
patch file icon resource_limit_modules.patch [^] (1,160 bytes) 2012-10-18 10:28 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to 0001362resolved (5.2.1)alex Use even more secure password hashing algorithm 

-  Notes
User avatar (0005232)
alex (manager)
2012-10-18 10:29

Will test all together later.
User avatar (0005233)
alex (manager)
2012-10-18 10:30

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001414: Centralize code for resource limit setting

- Related Changesets
In-Portal CMS: 5.2.x r15588
Timestamp: 2012-10-18 10:30:36
Author: alex
Details ] Diff ]
Fixes 0001414: Centralize code for resource limit setting
mod - /in-portal/branches/5.2.x/core/kernel/globals.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/processors/main_processor.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/utility/debugger/debugger_responce.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/categories/categories_event_handler.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/deployment_helper.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/image_helper.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/units/helpers/language_import_helper.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-10-18 10:30 alex Changeset attached 5.2.x r15588
2012-10-18 10:30 alex Note Added: 0005233
2012-10-18 10:30 alex Status reviewed and tested => resolved
2012-10-18 10:30 alex Fixed in Version => 5.2.1-B1
2012-10-18 10:30 alex Resolution open => fixed
2012-10-18 10:30 alex Assigned To !COMMUNITY => alex
2012-10-18 10:30 alex Changeset attached 5.2.x r15587
2012-10-18 10:29 alex Relationship added related to 0001362
2012-10-18 10:29 alex Note Added: 0005232
2012-10-18 10:29 alex Status needs testing => reviewed and tested
2012-10-18 10:29 alex Assigned To => !COMMUNITY
2012-10-18 10:29 alex Developer => alex
2012-10-18 10:29 alex Status active => needs testing
2012-10-18 10:29 alex Reference => https://groups.google.com/d/topic/in-portal-dev/52BfiUOrlPw/discussion
2012-10-18 10:28 alex File Added: resource_limit_modules.patch
2012-10-18 10:27 alex New Issue
2012-10-18 10:27 alex File Added: resource_limit_core.patch
2012-10-18 10:27 alex Change Log Message => Adds new function for centralized resource limit setting
2012-10-18 10:27 alex Estimate Points => 1



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker