In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
1266 [In-Portal CMS] Admin Interfaces bug report always 2012-04-25 15:08 2012-07-25 05:30
Dmitry  
alex  
normal  
closed 5.2.0-B3  
fixed  
 
none 5.2.0-RC1  
https://groups.google.com/d/topic/in-portal-bugs/JnSLVuvkzI4/discussion
Fixed special characters in website name break Admin Menu
1
0001266: Special Characters in Website Name break Admin Menu
Looks like special special characters in Website Name break Admin Menu.
child of 0000530closed  (5.1.0)alex Improvements of "m_Get" and "m_GetConfig" tags 
png In-Portal_5.2.0-B3_--_Issue_with_Website_Name.png (95,111) 2012-04-25 15:08
http://tracker.in-portal.org/file_download.php?file_id=1633&type=bug
png

patch sitename_not_escaped_core.patch (6,033) 2012-04-26 02:42
http://tracker.in-portal.org/file_download.php?file_id=1634&type=bug
patch sitename_not_escaped_themes.patch (5,094) 2012-04-26 02:42
http://tracker.in-portal.org/file_download.php?file_id=1635&type=bug
Issue History
2012-07-25 05:30 alex Note Added: 0004919
2012-07-25 05:30 alex Status resolved => closed
2012-04-26 02:47 alex Note Added: 0004605
2012-04-26 02:47 alex Status reviewed and tested => resolved
2012-04-26 02:47 alex Fixed in Version => 5.2.0-RC1
2012-04-26 02:47 alex Resolution open => fixed
2012-04-26 02:47 alex Assigned To !COMMUNITY => alex
2012-04-26 02:47 alex Changeset attached 5.2.x r15323
2012-04-26 02:47 alex Changeset attached 1.2.x r15322
2012-04-26 02:47 alex Changeset attached 1.0.x r15321
2012-04-26 02:46 alex Changeset attached 5.2.x r15320
2012-04-26 02:46 alex Changeset attached 1.2.x r15319
2012-04-26 02:46 alex Note Added: 0004604
2012-04-26 02:46 alex Status needs testing => reviewed and tested
2012-04-26 02:45 alex Note Added: 0004603
2012-04-26 02:45 alex Assigned To => !COMMUNITY
2012-04-26 02:45 alex Developer => alex
2012-04-26 02:45 alex Status active => needs testing
2012-04-26 02:42 alex File Added: sitename_not_escaped_themes.patch
2012-04-26 02:42 alex File Added: sitename_not_escaped_core.patch
2012-04-26 02:38 alex Estimate Points 0 => 1
2012-04-26 02:37 alex Relationship added child of 0000530
2012-04-25 15:11 Dmitry Reference [/url] => [url]https://groups.google.com/d/topic/in-portal-bugs/JnSLVuvkzI4/discussion
2012-04-25 15:08 Dmitry New Issue
2012-04-25 15:08 Dmitry File Added: In-Portal_5.2.0-B3_--_Issue_with_Website_Name.png
2012-04-25 15:08 Dmitry Reference => [url][/url]
2012-04-25 15:08 Dmitry Change Log Message => Fixed special characters in website name break Admin Menu
2012-04-25 15:08 Dmitry Estimate Points => 0

Notes
(0004603)
alex   
2012-04-26 02:45   
This working in 5.1.0, but after 0000530 task was implemented, where we removed "escape" parameter from m_GetConfig tag in favor of global "js_escape" parameter it break down, because usages of removed "escape" parameter weren't replaced to "js_escape".

In attached patch I also htmlescaped site name in themes, where it was used in alt/title attributes, where extra " could break HTML result.
(0004604)
alex   
2012-04-26 02:46   
Will test all together later.
(0004605)
alex   
2012-04-26 02:47   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001266: Special Characters in Website Name break Admin Menu
(0004919)
alex   
2012-07-25 05:30   
Since 5.2.0/1.2.0 versions was released.