In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ] [ Related Changesets ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/JnSLVuvkzI4/discussion

Change Log Message

Fixed special characters in website name break Admin Menu

Estimate Points

Attached Files

In-Portal_5.2.0-B3_--_Issue_with_Website_Name.png [^] (95,111 bytes) 2012-04-25 15:08

sitename_not_escaped_core.patch [^] (6,033 bytes) 2012-04-26 02:42 [Show Content]

Index: admin_templates/browser/browser_header.tpl
===================================================================
--- admin_templates/browser/browser_header.tpl	(revision 15165)
+++ admin_templates/browser/browser_header.tpl	(working copy)
@@ -31,7 +31,7 @@
 var $use_popups = <inp2:m_if check="adm_UsePopups">true<inp2:m_else/>false</inp2:m_if>;
 var $modal_windows = <inp2:m_if check="adm_UsePopups" mode="modal">true<inp2:m_else/>false</inp2:m_if>;
 var multiple_windows = '1';
-var main_title = '<inp2:m_GetConfig var="Site_Name" escape="1"/>';
+var main_title = '<inp2:m_GetConfig var="Site_Name" js_escape="1"/>';
 var tpl_changed = 0;
 var base_url = '<inp2:m_BaseURL/>';
 var $base_path = '<inp2:m_GetConst name="BASE_PATH"/>';
Index: admin_templates/incs/header.tpl
===================================================================
--- admin_templates/incs/header.tpl	(revision 15284)
+++ admin_templates/incs/header.tpl	(working copy)
@@ -58,7 +58,7 @@
 var $use_popups = <inp2:m_if check="adm_UsePopups">true<inp2:m_else/>false</inp2:m_if>;
 var $modal_windows = <inp2:m_if check="adm_UsePopups" mode="modal">true<inp2:m_else/>false</inp2:m_if>;
 var multiple_windows = '1';
-var main_title = '<inp2:m_GetConfig var="Site_Name" escape="1"/>';
+var main_title = '<inp2:m_GetConfig var="Site_Name" js_escape="1"/>';
 var tpl_changed = 0;
 var base_url = '<inp2:m_BaseURL/>';
 var $base_path = '<inp2:m_GetConst name="BASE_PATH"/>';
Index: admin_templates/login.tpl
===================================================================
--- admin_templates/login.tpl	(revision 15247)
+++ admin_templates/login.tpl	(working copy)
@@ -103,13 +103,13 @@
 			  		<table class="head-table" style="background: none;">
 			  		<tr>
 			  			<inp2:m_if check="adm_AdminSkin" type="LogoLogin">
-			  				<td align="center"><img src="<inp2:adm_AdminSkin type='LogoLogin'/>" alt="<inp2:m_GetConfig var='Site_Name'/>"></td>
+			  				<td align="center"><img src="<inp2:adm_AdminSkin type='LogoLogin'/>" alt="<inp2:m_GetConfig var='Site_Name' html_escape='1'/>"></td>
 			  			<inp2:m_else/>
 			  				<inp2:m_if check="adm_AdminSkin" type="Logo">
 				  				<td>
-				  					<img src="<inp2:adm_AdminSkin type='Logo'/>" alt="<inp2:m_GetConfig var='Site_Name'/>"><br/>
+				  					<img src="<inp2:adm_AdminSkin type='Logo'/>" alt="<inp2:m_GetConfig var='Site_Name' html_escape='1'/>"><br/>
 				  					<inp2:m_if check="adm_AdminSkin" type="LogoBottom">
-				  						<img src="<inp2:adm_AdminSkin type='LogoBottom'/>" alt="<inp2:m_GetConfig var='Site_Name'/>">
+				  						<img src="<inp2:adm_AdminSkin type='LogoBottom'/>" alt="<inp2:m_GetConfig var='Site_Name' html_escape='1'/>">
 				  					</inp2:m_if>
 				  				</td>
 			  				</inp2:m_if>
Index: admin_templates/tree.tpl
===================================================================
--- admin_templates/tree.tpl	(revision 15173)
+++ admin_templates/tree.tpl	(working copy)
@@ -47,9 +47,9 @@
 		<td colspan="2" style="vertical-align: top; padding: 5px;">
 			<inp2:m_DefineElement name="xml_node" icon_module="">
 				<inp2:m_if check="m_ParamEquals" param="children_count" value="0">
-					<item href="<inp2:m_param name="section_url" js_escape="1"/>" priority="<inp2:m_param name="priority"/>" onclick="<inp2:m_param name="onclick" js_escape="1"/>" icon="<inp2:$SectionPrefix_ModulePath module="$icon_module"/>img/icons/icon24_<inp2:m_param name="icon"/>.png"<inp2:m_if check="m_Param" name="debug_only"> debug_only="1"</inp2:m_if>><inp2:m_phrase name="$label" escape="1"/></item>
+					<item href="<inp2:m_param name='section_url' js_escape='1'/>" priority="<inp2:m_param name='priority'/>" onclick="<inp2:m_param name='onclick' js_escape='1'/>" icon="<inp2:$SectionPrefix_ModulePath module='$icon_module'/>img/icons/icon24_<inp2:m_param name='icon'/>.png"<inp2:m_if check="m_Param" name="debug_only"> debug_only="1"</inp2:m_if>><inp2:m_phrase name="$label" escape="1"/></item>
 				<inp2:m_else/>
-					<folder href="<inp2:m_param name="section_url" js_escape="1"/>" priority="<inp2:m_param name="priority"/>" container="<inp2:m_param name="container"/>" onclick="<inp2:m_param name="onclick" js_escape="1"/>" name="<inp2:m_phrase name="$label" escape="1"/>" icon="<inp2:$SectionPrefix_ModulePath module="$icon_module"/>img/icons/icon24_<inp2:m_param name="icon"/>.png" load_url="<inp2:m_param name="late_load" js_escape="1"/>"<inp2:m_if check="m_Param" name="debug_only"> debug_only="1"</inp2:m_if>><inp2:adm_PrintSections render_as="xml_node" section_name="$section_name"/></folder>
+					<folder href="<inp2:m_param name='section_url' js_escape='1'/>" priority="<inp2:m_param name='priority'/>" container="<inp2:m_param name='container'/>" onclick="<inp2:m_param name='onclick' js_escape='1'/>" name="<inp2:m_phrase name='$label' escape='1'/>" icon="<inp2:$SectionPrefix_ModulePath module="$icon_module"/>img/icons/icon24_<inp2:m_param name='icon'/>.png" load_url="<inp2:m_param name='late_load' js_escape='1'/>"<inp2:m_if check="m_Param" name="debug_only"> debug_only="1"</inp2:m_if>><inp2:adm_PrintSections render_as="xml_node" section_name="$section_name"/></folder>
 				</inp2:m_if>
 			</inp2:m_DefineElement>
 
@@ -66,7 +66,7 @@
 				};
 
 				<inp2:m_DefineElement name="root_node">
-					var the_tree = new TreeFolder('tree', '<inp2:m_param name="label"/>', '<inp2:m_param name="section_url"/>', '<inp2:$SectionPrefix_ModulePath module="$icon_module"/>img/icons/icon24_<inp2:m_param name="icon"/>.png', null, null, '<inp2:m_param name="priority"/>', '<inp2:m_param name="container"/>');
+					var the_tree = new TreeFolder('tree', '<inp2:m_param name="label" js_escape="1"/>', '<inp2:m_param name="section_url" js_escape="1"/>', '<inp2:$SectionPrefix_ModulePath module="$icon_module"/>img/icons/icon24_<inp2:m_param name="icon"/>.png', null, null, '<inp2:m_param name="priority"/>', '<inp2:m_param name="container"/>');
 				</inp2:m_DefineElement>
 				<inp2:adm_PrintSection render_as="root_node" section_name="in-portal:root"/>

sitename_not_escaped_themes.patch [^] (5,094 bytes) 2012-04-26 02:42 [Show Content]

Index: advanced/platform/elements/header.elm.tpl
===================================================================
--- advanced/platform/elements/header.elm.tpl	(revision 15259)
+++ advanced/platform/elements/header.elm.tpl	(working copy)
@@ -1,7 +1,7 @@
 <table class="top-background fullwidth">
 	<tr>
 		<td width="240" nowrap>
-			<a href="<inp2:m_Link template="index" m_cat_id="0" m_cat_page="1"/>"><img src="<inp2:m_TemplatesBase module="In-Portal"/>img/globe.gif" alt="<inp2:m_GetConfig name="Site_Name"/>" /><img src="<inp2:m_TemplatesBase module="In-Portal"/>img/logo.gif" alt="<inp2:m_GetConfig name="Site_Name"/>" /></a><br />
+			<a href="<inp2:m_Link template='index' m_cat_id='0' m_cat_page='1'/>"><img src="<inp2:m_TemplatesBase module='In-Portal'/>img/globe.gif" alt="<inp2:m_GetConfig name='Site_Name' html_escape='1'/>" /><img src="<inp2:m_TemplatesBase module='In-Portal'/>img/logo.gif" alt="<inp2:m_GetConfig name='Site_Name' html_escape='1'/>" /></a><br />
 		</td>
 
 		<!-- TOP-BANNER -->
Index: default/elements/html_head.elm.tpl
===================================================================
--- default/elements/html_head.elm.tpl	(revision 15246)
+++ default/elements/html_head.elm.tpl	(working copy)
@@ -8,7 +8,7 @@
 <inp2:m_else/>
 	<meta name="Description" content="<inp2:m_GetConfig name='Category_MetaDesc'/>"/>
 </inp2:m_if>
-<meta name="author" content="<inp2:m_GetConfig name='Site_Name'/>"/>
+<meta name="author" content="<inp2:m_GetConfig name='Site_Name' html_escape='1'/>"/>
 <meta http-equiv="content-type" content="text/html; charset=<inp2:lang.current_Field name='Charset'/>" />
 
 <link rel="icon" href="<inp2:m_BaseURL/>favicon.ico" type="image/x-icon" />
Index: modern-store/elements/header.elm.tpl
===================================================================
--- modern-store/elements/header.elm.tpl	(revision 15246)
+++ modern-store/elements/header.elm.tpl	(working copy)
@@ -6,7 +6,7 @@
 </inp2:m_if>
 
 	<div class="logo">
-		<a href="<inp2:m_Link template='index' m_cat_id='0' />"><img src="<inp2:m_TemplatesBase/>img/logo.jpg" width="238" height="79" alt="<inp2:m_GetConfig name='Site_Name'/>" /></a>
+		<a href="<inp2:m_Link template='index' m_cat_id='0' />"><img src="<inp2:m_TemplatesBase/>img/logo.jpg" width="238" height="79" alt="<inp2:m_GetConfig name='Site_Name' html_escape='1'/>" /></a>
 		<inp2:st_ContentBlock num="100" page="index"/>
 	</div>
 	<div class="infoblock">
Index: modern-store/elements/html_head.elm.tpl
===================================================================
--- modern-store/elements/html_head.elm.tpl	(revision 15246)
+++ modern-store/elements/html_head.elm.tpl	(working copy)
@@ -8,7 +8,7 @@
 <inp2:m_else/>
 	<meta name="Description" content="<inp2:m_GetConfig name='Category_MetaDesc'/>"/>
 </inp2:m_if>
-<meta name="author" content="<inp2:m_GetConfig name='Site_Name'/>"/>
+<meta name="author" content="<inp2:m_GetConfig name='Site_Name' html_escape='1'/>"/>
 <meta http-equiv="content-type" content="text/html; charset=<inp2:lang.current_Field name='Charset'/>" />
 
 <link rel="icon" href="<inp2:m_BaseURL/>favicon.ico" type="image/x-icon" />
Index: simple/designs/default_design.des.tpl
===================================================================
--- simple/designs/default_design.des.tpl	(revision 15272)
+++ simple/designs/default_design.des.tpl	(working copy)
@@ -36,7 +36,7 @@
 
 			<!-- Branding -->
 			<h1 id="branding">
-				<a href="<inp2:m_Link t="index" />" title="<inp2:m_GetConfig name="Site_Name"/>"><inp2:m_GetConfig name="Site_Name"/></a>
+				<a href="<inp2:m_Link t='index' />" title="<inp2:m_GetConfig name='Site_Name' html_escape='1'/>"><inp2:m_GetConfig name="Site_Name"/></a>
 			</h1>
 			<!-- /Branding -->
 
Index: simple/designs/default_design_inner.des.tpl
===================================================================
--- simple/designs/default_design_inner.des.tpl	(revision 15272)
+++ simple/designs/default_design_inner.des.tpl	(working copy)
@@ -33,7 +33,7 @@
 
 			<!-- Branding -->
 			<h1 id="branding">
-				<a href="<inp2:m_Link t="index" />" title="<inp2:m_GetConfig name="Site_Name"/>"><inp2:m_GetConfig name="Site_Name"/></a>
+				<a href="<inp2:m_Link t='index' />" title="<inp2:m_GetConfig name='Site_Name' html_escape='1'/>"><inp2:m_GetConfig name="Site_Name"/></a>
 			</h1>
 			<!-- /Branding -->
 
Index: simple/elements/html_head.elm.tpl
===================================================================
--- simple/elements/html_head.elm.tpl	(revision 15246)
+++ simple/elements/html_head.elm.tpl	(working copy)
@@ -8,7 +8,7 @@
 <inp2:m_else/>
 	<meta name="Description" content="<inp2:m_GetConfig name='Category_MetaDesc'/>"/>
 </inp2:m_if>
-<meta name="author" content="<inp2:m_GetConfig name='Site_Name'/>"/>
+<meta name="author" content="<inp2:m_GetConfig name='Site_Name' html_escape='1'/>"/>
 <meta http-equiv="content-type" content="text/html; charset=<inp2:lang.current_Field name='Charset'/>" />
 
 <link rel="icon" href="<inp2:m_BaseURL/>favicon.ico" type="image/x-icon" />

Relationships [ Relation Graph ] [ Dependency Graph ]

child of

0000530

closed (5.1.0)

alex

Improvements of "m_Get" and "m_GetConfig" tags

Notes
(0004603) alex (manager) 2012-04-26 02:45	This working in 5.1.0, but after 0000530 task was implemented, where we removed "escape" parameter from m_GetConfig tag in favor of global "js_escape" parameter it break down, because usages of removed "escape" parameter weren't replaced to "js_escape". In attached patch I also htmlescaped site name in themes, where it was used in alt/title attributes, where extra " could break HTML result.

(0004604) alex (manager) 2012-04-26 02:46	Will test all together later.

(0004605) alex (manager) 2012-04-26 02:47	Fix committed to 5.2.x branch. Commit Message: Fixes 0001266: Special Characters in Website Name break Admin Menu

(0004919) alex (manager) 2012-07-25 05:30	Since 5.2.0/1.2.0 versions was released.

Related Changesets
In-Portal CMS: 5.2.x r15323 Timestamp: 2012-04-26 02:47:41 Author: alex [ Details ] [ Diff ]	Fixes 0001266: Special Characters in Website Name break Admin Menu
	mod - /in-portal/branches/5.2.x/core/admin_templates/browser/browser_header.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/admin_templates/incs/header.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/admin_templates/login.tpl	[ Diff ] [ File ]
	mod - /in-portal/branches/5.2.x/core/admin_templates/tree.tpl	[ Diff ] [ File ]

Themes :: Simple: 1.2.x r15322 Timestamp: 2012-04-26 02:47:15 Author: alex [ Details ] [ Diff ]	Bug 0001266: Special Characters in Website Name break Admin Menu
	mod - /themes/simple/branches/1.2.x/designs/default_design.des.tpl	[ Diff ] [ File ]
	mod - /themes/simple/branches/1.2.x/designs/default_design_inner.des.tpl	[ Diff ] [ File ]
	mod - /themes/simple/branches/1.2.x/elements/html_head.elm.tpl	[ Diff ] [ File ]

Themes :: Modern-Store: 1.0.x r15321 Timestamp: 2012-04-26 02:47:06 Author: alex [ Details ] [ Diff ]	Bug 0001266: Special Characters in Website Name break Admin Menu
	mod - /themes/modern-store/branches/1.0.x/elements/header.elm.tpl	[ Diff ] [ File ]
	mod - /themes/modern-store/branches/1.0.x/elements/html_head.elm.tpl	[ Diff ] [ File ]

Themes :: Default: 5.2.x r15320 Timestamp: 2012-04-26 02:46:43 Author: alex [ Details ] [ Diff ]	Bug 0001266: Special Characters in Website Name break Admin Menu
	mod - /themes/default/branches/5.2.x/elements/html_head.elm.tpl	[ Diff ] [ File ]

Themes :: Advanced: 1.2.x r15319 Timestamp: 2012-04-26 02:46:34 Author: alex [ Details ] [ Diff ]	Bug 0001266: Special Characters in Website Name break Admin Menu
	mod - /themes/advanced/branches/1.2.x/platform/elements/header.elm.tpl	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-25 05:30	alex	Note Added: 0004919
2012-07-25 05:30	alex	Status	resolved => closed
2012-04-26 02:47	alex	Note Added: 0004605
2012-04-26 02:47	alex	Status	reviewed and tested => resolved
2012-04-26 02:47	alex	Fixed in Version	=> 5.2.0-RC1
2012-04-26 02:47	alex	Resolution	open => fixed
2012-04-26 02:47	alex	Assigned To	!COMMUNITY => alex
2012-04-26 02:47	alex	Changeset attached	5.2.x r15323
2012-04-26 02:47	alex	Changeset attached	1.2.x r15322
2012-04-26 02:47	alex	Changeset attached	1.0.x r15321
2012-04-26 02:46	alex	Changeset attached	5.2.x r15320
2012-04-26 02:46	alex	Changeset attached	1.2.x r15319
2012-04-26 02:46	alex	Note Added: 0004604
2012-04-26 02:46	alex	Status	needs testing => reviewed and tested
2012-04-26 02:45	alex	Note Added: 0004603
2012-04-26 02:45	alex	Assigned To	=> !COMMUNITY
2012-04-26 02:45	alex	Developer	=> alex
2012-04-26 02:45	alex	Status	active => needs testing
2012-04-26 02:42	alex	File Added: sitename_not_escaped_themes.patch
2012-04-26 02:42	alex	File Added: sitename_not_escaped_core.patch
2012-04-26 02:38	alex	Estimate Points	0 => 1
2012-04-26 02:37	alex	Relationship added	child of 0000530
2012-04-25 15:11	Dmitry	Reference	[/url] => [url]https://groups.google.com/d/topic/in-portal-bugs/JnSLVuvkzI4/discussion
2012-04-25 15:08	Dmitry	New Issue
2012-04-25 15:08	Dmitry	File Added: In-Portal_5.2.0-B3_--_Issue_with_Website_Name.png
2012-04-25 15:08	Dmitry	Reference	=> [url][/url]
2012-04-25 15:08	Dmitry	Change Log Message	=> Fixed special characters in website name break Admin Menu
2012-04-25 15:08	Dmitry	Estimate Points	=> 0

Web Development by Intechnic

In-Portal Open Source CMS