In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Type

Reproducibility

Date Submitted

Last Update

0001447

[In-Commerce] Payment Gateways

bug report

always

2013-01-08 05:12

2013-01-08 05:14

Reporter

alex

View Status

public

Project Name

In-Commerce

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.2.1-B2

Status

resolved

Product Version

5.1.0

Target Version

5.2.1

Time Estimate

No estimate

Summary

0001447: Product price change in Catalog breaks down all associated Reoccurring Orders

Description

In-Portal has own implementation of reoccurring orders, that doesn't use one (if any), provided by payment gateway.

Each order in In-Commerce has 2 extra fields, located on "Billing" tab on order editing page, that allow to do that:
"Recurring Billing" - checkbox, that determines if next charge should happen automatically
"Next Charge Date" - date, when next change should happen if "Recurring Billing" is checked

Then cron looks for Processed/Archived orders with both fields set (and next change date in past) and does following to them:
clones them (order with same contents, but "-001" sub-number and in Incomplete status is created)
updates prices in order to match current product prices in catalog
approves order, which triggers charging
removes "Recurring Billing" checkbox from order that was cloned
sets "Recurring Billing" checkbox and "Next Charge Date" checkbox to newly created order

This all might seem right, but problem lies in 2nd step where prices in cloned order are updated from catalog. I personally think, that if customer brought a product for $10, then he should be automatically charged next time (by cron) for same $10 no matter if greedy website administrator set that product price to $15 in catalog.

Looks like 1 part of In-Commerce was thinking this way and prevented these unfair order from ever being charged and kept them in Incomplete status.

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/wLeispoJ3pA/discussion

Change Log Message

Fixes product price update in reoccurring orders

Estimate Points

Attached Files

product_price_change_breaks_reoccurring_orders.patch [^] (772 bytes) 2013-01-08 05:12 [Show Content]

Index: modules/in-commerce/units/orders/orders_event_handler.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- modules/in-commerce/units/orders/orders_event_handler.php	(revision 15637)
+++ modules/in-commerce/units/orders/orders_event_handler.php	(revision )
@@ -442,7 +442,10 @@
 	function OnCompleteOrder($event)
 	{
 		$this->LockTables($event);
-		if ( !$this->CheckQuantites($event) ) {
+		$reoccurring_order = substr($event->Special, 0, 9) == 'recurring';
+
+		if ( !$reoccurring_order && !$this->CheckQuantites($event) ) {
+			// don't check quantities (that causes recalculate) for reoccurring orders
 			return;
 		}
 
\ No newline at end of file

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0005347) alex (manager) 2013-01-08 05:14	Will test all together later.

(0005348) alex (manager) 2013-01-08 05:14	Fix committed to 5.2.x branch. Commit Message: Fixes 0001447: Product price change in Catalog breaks down all associated Reoccurring Orders

Related Changesets
Modules :: In-Commerce: 5.2.x r15663 Timestamp: 2013-01-08 05:14:46 Author: alex [ Details ] [ Diff ]	Fixes 0001447: Product price change in Catalog breaks down all associated Reoccurring Orders
	mod - /w/in-commerce/branches/5.2.x/units/orders/orders_event_handler.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2013-01-08 05:14	alex	Note Added: 0005348
2013-01-08 05:14	alex	Status	reviewed and tested => resolved
2013-01-08 05:14	alex	Fixed in Version	=> 5.2.1-B2
2013-01-08 05:14	alex	Resolution	open => fixed
2013-01-08 05:14	alex	Changeset attached	5.2.x r15663
2013-01-08 05:14	alex	Note Added: 0005347
2013-01-08 05:14	alex	Assigned To	Dmitry => alex
2013-01-08 05:14	alex	Status	needs testing => reviewed and tested
2013-01-08 05:13	alex	Assigned To	=> Dmitry
2013-01-08 05:13	alex	Developer	=> alex
2013-01-08 05:13	alex	Status	active => needs testing
2013-01-08 05:13	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/wLeispoJ3pA/discussion
2013-01-08 05:12	alex	New Issue
2013-01-08 05:12	alex	File Added: product_price_change_breaks_reoccurring_orders.patch
2013-01-08 05:12	alex	Change Log Message	=> Fixes product price update in reoccurring orders
2013-01-08 05:12	alex	Estimate Points	=> 1

Web Development by Intechnic

In-Portal Open Source CMS