In-Portal Issue Tracker - In-Commerce
Viewing Issue Advanced Details
1447 [In-Commerce] Payment Gateways bug report always 2013-01-08 05:12 2013-01-08 05:14
resolved 5.1.0  
none 5.2.1-B2
Fixes product price update in reoccurring orders
0001447: Product price change in Catalog breaks down all associated Reoccurring Orders
In-Portal has own implementation of reoccurring orders, that doesn't use one (if any), provided by payment gateway.

Each order in In-Commerce has 2 extra fields, located on "Billing" tab on order editing page, that allow to do that:
"Recurring Billing" - checkbox, that determines if next charge should happen automatically
"Next Charge Date" - date, when next change should happen if "Recurring Billing" is checked

Then cron looks for Processed/Archived orders with both fields set (and next change date in past) and does following to them:
clones them (order with same contents, but "-001" sub-number and in Incomplete status is created)
updates prices in order to match current product prices in catalog
approves order, which triggers charging
removes "Recurring Billing" checkbox from order that was cloned
sets "Recurring Billing" checkbox and "Next Charge Date" checkbox to newly created order

This all might seem right, but problem lies in 2nd step where prices in cloned order are updated from catalog. I personally think, that if customer brought a product for $10, then he should be automatically charged next time (by cron) for same $10 no matter if greedy website administrator set that product price to $15 in catalog.

Looks like 1 part of In-Commerce was thinking this way and prevented these unfair order from ever being charged and kept them in Incomplete status.
patch product_price_change_breaks_reoccurring_orders.patch (772) 2013-01-08 05:12
Issue History
2013-01-08 05:14 alex Note Added: 0005348
2013-01-08 05:14 alex Status reviewed and tested => resolved
2013-01-08 05:14 alex Fixed in Version => 5.2.1-B2
2013-01-08 05:14 alex Resolution open => fixed
2013-01-08 05:14 alex Changeset attached 5.2.x r15663
2013-01-08 05:14 alex Note Added: 0005347
2013-01-08 05:14 alex Assigned To Dmitry => alex
2013-01-08 05:14 alex Status needs testing => reviewed and tested
2013-01-08 05:13 alex Assigned To => Dmitry
2013-01-08 05:13 alex Developer => alex
2013-01-08 05:13 alex Status active => needs testing
2013-01-08 05:13 alex Reference =>
2013-01-08 05:12 alex New Issue
2013-01-08 05:12 alex File Added: product_price_change_breaks_reoccurring_orders.patch
2013-01-08 05:12 alex Change Log Message => Fixes product price update in reoccurring orders
2013-01-08 05:12 alex Estimate Points => 1

2013-01-08 05:14   
Will test all together later.
2013-01-08 05:14   
Fix committed to 5.2.x branch. Commit Message:

Fixes 0001447: Product price change in Catalog breaks down all associated Reoccurring Orders