In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details [ Jump to Notes ] [ Wiki ]

[ View Simple ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000991

[In-Portal CMS] Data Management

feature request

N/A

2011-02-05 08:12

2011-09-19 16:08

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Platform

Status

closed

OS

OS Version

ETA

none

Fixed in Version

5.1.3

Product Version

5.1.2-B1

Target Version

5.1.3

Product Build

Time Estimate

No estimate

Summary

0000991: Usability improvement to kCurlHelper class

Description

In-Portal has kCurlHelper class to automate process of retrieving data from other API's or websites, like Google Data API or RSS feeds.

All works fine, when queried website has no errors. In case if website sends 500 HTTP response code (error) or there will be a connection timeout to that site, then response from kCurlHelper::Send method will be the same: empty string.

Such result is not sufficient for web sites, where empty string means something special response. In such cases I usually check for last HTTP code to be 200 OK and no connection error has occurred.

In attached patch there is new kCurlHelper::isGoodResponce method for doing all that.

Steps To Reproduce

Additional Information

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-dev/rahm7iGsbq0/discussion

Change Log Message

Added kCurlHelper::isGoodResponce method

Estimate Points

0

curl_responce_checker.patch [^] (519 bytes) 2011-02-05 08:12 [Show Content]

Index: curl_helper.php
===================================================================
--- curl_helper.php	(revision 14184)
+++ curl_helper.php	(working copy)
@@ -289,4 +289,13 @@
 			// restore debug mode setting
 			$this->debugMode = constOn('DBG_CURL');
 		}
+		
+		function isGoodResponceCode()
+		{
+			if ($this->lastErrorCode != 0) {
+				return false;
+			}
+
+			return ($this->lastHTTPCode == 200) || ($this->lastHTTPCode >= 300 && $this->lastHTTPCode < 310);
+		}
 	}
\ No newline at end of file

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

closed (5.2.0)

New method for XML parsing error checking

Notes
(0003222) Dmitry (manager) 2011-02-05 15:55	Patch tested good.

(0003731) Dmitry (manager) 2011-09-11 22:15	Moved to 5.1.3 release since small, but useful to have.

(0003740) alex (manager) 2011-09-16 09:07	Fix committed to 5.1.x branch. Commit Message: Fixes 0000991: Usability improvement to kCurlHelper class

(0003783) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14518 Timestamp: 2011-09-16 09:07:22 Author: alex [ Details ] [ Diff ]	Fixes 0000991: Usability improvement to kCurlHelper class
	mod - /in-portal/branches/5.1.x/core/units/helpers/curl_helper.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003783
2011-09-19 16:08	alex	Status	resolved => closed
2011-09-16 09:53	alex	Relationship added	related to 0001116
2011-09-16 09:07	alex	Note Added: 0003740
2011-09-16 09:07	alex	Status	reviewed and tested => resolved
2011-09-16 09:07	alex	Fixed in Version	=> 5.1.3
2011-09-16 09:07	alex	Resolution	open => fixed
2011-09-16 09:07	alex	Assigned To	!COMMUNITY => alex
2011-09-16 09:07	alex	Changeset attached	5.1.x r14518
2011-09-11 22:15	Dmitry	Note Added: 0003731
2011-09-11 22:15	Dmitry	Target Version	Icebox => 5.1.3
2011-02-12 09:39	alex	Relationship added	related to 0001001
2011-02-05 15:55	Dmitry	Note Added: 0003222
2011-02-05 15:55	Dmitry	Status	needs testing => reviewed and tested
2011-02-05 08:13	alex	Assigned To	=> !COMMUNITY
2011-02-05 08:13	alex	Developer	=> alex
2011-02-05 08:13	alex	Status	active => needs testing
2011-02-05 08:12	alex	Reference	=> https://groups.google.com/d/topic/in-portal-dev/rahm7iGsbq0/discussion
2011-02-05 08:12	alex	New Issue
2011-02-05 08:12	alex	File Added: curl_responce_checker.patch
2011-02-05 08:12	alex	Change Log Message	=> Added kCurlHelper::isGoodResponce method

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group