In-Portal Issue Tracker - In-Portal CMS
Viewing Issue Advanced Details
991 [In-Portal CMS] Data Management feature request N/A 2011-02-05 08:12 2011-09-19 16:08
alex  
alex  
normal  
closed 5.1.2-B1  
fixed  
 
none 5.1.3  
https://groups.google.com/d/topic/in-portal-dev/rahm7iGsbq0/discussion
Added kCurlHelper::isGoodResponce method
0
0000991: Usability improvement to kCurlHelper class
In-Portal has kCurlHelper class to automate process of retrieving data from other API's or websites, like Google Data API or RSS feeds.

All works fine, when queried website has no errors. In case if website sends 500 HTTP response code (error) or there will be a connection timeout to that site, then response from kCurlHelper::Send method will be the same: empty string.

Such result is not sufficient for web sites, where empty string means something special response. In such cases I usually check for last HTTP code to be 200 OK and no connection error has occurred.

In attached patch there is new kCurlHelper::isGoodResponce method for doing all that.
related to 0001001closed  (5.2.0)alex New method for XML parsing error checking 
patch curl_responce_checker.patch (519) 2011-02-05 08:12
http://tracker.in-portal.org/file_download.php?file_id=932&type=bug
Issue History
2011-09-19 16:08 alex Note Added: 0003783
2011-09-19 16:08 alex Status resolved => closed
2011-09-16 09:53 alex Relationship added related to 0001116
2011-09-16 09:07 alex Note Added: 0003740
2011-09-16 09:07 alex Status reviewed and tested => resolved
2011-09-16 09:07 alex Fixed in Version => 5.1.3
2011-09-16 09:07 alex Resolution open => fixed
2011-09-16 09:07 alex Assigned To !COMMUNITY => alex
2011-09-16 09:07 alex Changeset attached 5.1.x r14518
2011-09-11 22:15 Dmitry Note Added: 0003731
2011-09-11 22:15 Dmitry Target Version Icebox => 5.1.3
2011-02-12 09:39 alex Relationship added related to 0001001
2011-02-05 15:55 Dmitry Note Added: 0003222
2011-02-05 15:55 Dmitry Status needs testing => reviewed and tested
2011-02-05 08:13 alex Assigned To => !COMMUNITY
2011-02-05 08:13 alex Developer => alex
2011-02-05 08:13 alex Status active => needs testing
2011-02-05 08:12 alex Reference => https://groups.google.com/d/topic/in-portal-dev/rahm7iGsbq0/discussion
2011-02-05 08:12 alex New Issue
2011-02-05 08:12 alex File Added: curl_responce_checker.patch
2011-02-05 08:12 alex Change Log Message => Added kCurlHelper::isGoodResponce method

Notes
(0003222)
Dmitry   
2011-02-05 15:55   
Patch tested good.
(0003731)
Dmitry   
2011-09-11 22:15   
Moved to 5.1.3 release since small, but useful to have.
(0003740)
alex   
2011-09-16 09:07   
Fix committed to 5.1.x branch. Commit Message:

Fixes 0000991: Usability improvement to kCurlHelper class
(0003783)
alex   
2011-09-19 16:08   
Closing, since 5.1.3 release has been released.