In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Advanced Details Jump to Notes ] Wiki ]  Related Changesets ] View Simple ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0001421 [In-Portal CMS] Data Management refactoring always 2012-10-26 10:29 2012-10-26 11:09
Reporter alex View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Platform
Status resolved   OS
  OS Version
ETA none Fixed in Version 5.2.1-B1 Product Version 5.1.0
  Target Version 5.2.1 Product Build
Time EstimateNo estimate
Summary 0001421: Don't use $_REQUEST in Debugger
Description There is $_REQUEST super-global variable in PHP, that used to contain Get/Post/Cookie variables all together. However since PHP 5.3.0 actual contents of this variable can be altered using "request_order" ini setting.
Unfortunately by default it no longer contains Cookie values. This is not big issue for In-Portal because it uses it's own $_REQUEST-alike variable maintenance system.

However it's a problem for Debugger, which thinks that there are always all variables inside a $_REQUEST and some of them are Get, some Post and some Cookies.
I'm proposing merge $_GET, $_POST, $_COOKIE arrays manually in the debugger and not rely on $_REQUEST variable's content.
Steps To Reproduce
Additional Information
Tags No tags attached.
Change Log Message Removes usage of $_REQUEST variable
Estimate Points 1
Attached Files patch file icon dont_use_request_core.patch [^] (2,074 bytes) 2012-10-26 11:08 [Show Content]
patch file icon dont_use_request_modules.patch [^] (593 bytes) 2012-10-26 11:08 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0005247)
alex (manager)
2012-10-26 11:09

Fix committed to 5.2.x branch. Commit Message:

Fixes 0001421: Don't use $_REQUEST in Debugger

- Related Changesets
In-Portal CMS: 5.2.x r15597
Timestamp: 2012-10-26 11:09:56
Author: alex
Details ] Diff ]
Fixes 0001421: Don't use $_REQUEST in Debugger
mod - /in-portal/branches/5.2.x/core/install.php Diff ] File ]
mod - /in-portal/branches/5.2.x/core/kernel/utility/debugger.php Diff ] File ]
Modules :: In-Commerce: 5.2.x r15596
Timestamp: 2012-10-26 11:09:33
Author: alex
Details ] Diff ]
Bug 0001421: Don't use $_REQUEST in Debugger
mod - /w/in-commerce/branches/5.2.x/units/gateways/gw_classes/sella_guestpay.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-10-26 11:09 alex Note Added: 0005247
2012-10-26 11:09 alex Status reviewed and tested => resolved
2012-10-26 11:09 alex Fixed in Version => 5.2.1-B1
2012-10-26 11:09 alex Resolution open => fixed
2012-10-26 11:09 alex Assigned To !COMMUNITY => alex
2012-10-26 11:09 alex Changeset attached 5.2.x r15597
2012-10-26 11:09 alex Changeset attached 5.2.x r15596
2012-10-26 11:09 alex Status needs testing => reviewed and tested
2012-10-26 11:08 alex Assigned To => !COMMUNITY
2012-10-26 11:08 alex Developer => alex
2012-10-26 11:08 alex Status active => needs testing
2012-10-26 11:08 alex File Added: dont_use_request_modules.patch
2012-10-26 11:08 alex File Added: dont_use_request_core.patch
2012-10-26 10:29 alex New Issue
2012-10-26 10:29 alex Reference =>
2012-10-26 10:29 alex Change Log Message => Removes usage of $_REQUEST variable
2012-10-26 10:29 alex Estimate Points => 1

Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker