|
In-Portal Issue Tracker - In-Portal CMS
|
|
Viewing Issue Advanced Details |
|
|
ID:
|
Category:
|
Type:
|
Reproducibility:
|
Date Submitted:
|
Last Update:
|
|
1421 |
[In-Portal CMS] Data Management |
refactoring |
always |
2012-10-26 10:29 |
2012-10-26 11:09 |
|
|
Reporter:
|
alex |
Platform:
|
|
|
|
Assigned To:
|
alex |
OS:
|
|
|
|
Priority:
|
normal |
OS Version:
|
|
|
|
Status:
|
resolved |
Product Version:
|
5.1.0 |
|
|
Product Build:
|
|
Resolution:
|
fixed |
|
| |
|
ETA:
|
none |
Fixed in Version:
|
5.2.1-B1 |
|
|
Reference:
|
https://groups.google.com/d/topic/in-portal-bugs/c0CFc4BjZQE/discussion |
|
Change Log Message:
|
Removes usage of $_REQUEST variable |
|
Estimate Points:
|
1 |
|
|
Summary:
|
0001421: Don't use $_REQUEST in Debugger |
|
Description:
|
There is $_REQUEST super-global variable in PHP, that used to contain Get/Post/Cookie variables all together. However since PHP 5.3.0 actual contents of this variable can be altered using "request_order" ini setting.
Unfortunately by default it no longer contains Cookie values. This is not big issue for In-Portal because it uses it's own $_REQUEST-alike variable maintenance system.
However it's a problem for Debugger, which thinks that there are always all variables inside a $_REQUEST and some of them are Get, some Post and some Cookies.
I'm proposing merge $_GET, $_POST, $_COOKIE arrays manually in the debugger and not rely on $_REQUEST variable's content. |
|
Steps To Reproduce:
|
|
|
Additional Information:
|
|
| Relationships | |
|
Attached Files:
|
 dont_use_request_core.patch (2,074) 2012-10-26 11:08
http://tracker.in-portal.org/file_download.php?file_id=1842&type=bug
dont_use_request_modules.patch (593) 2012-10-26 11:08
http://tracker.in-portal.org/file_download.php?file_id=1843&type=bug |
|
|
Issue History |
|
Date Modified |
Username |
Field |
Change |
|
2012-10-26 11:09 |
alex |
Note Added: 0005247 |
|
|
2012-10-26 11:09 |
alex |
Status |
reviewed and tested => resolved |
|
2012-10-26 11:09 |
alex |
Fixed in Version |
=> 5.2.1-B1 |
|
2012-10-26 11:09 |
alex |
Resolution |
open => fixed |
|
2012-10-26 11:09 |
alex |
Assigned To |
!COMMUNITY => alex |
|
2012-10-26 11:09 |
alex |
Changeset attached |
5.2.x r15597 |
|
2012-10-26 11:09 |
alex |
Changeset attached |
5.2.x r15596 |
|
2012-10-26 11:09 |
alex |
Status |
needs testing => reviewed and tested |
|
2012-10-26 11:08 |
alex |
Assigned To |
=> !COMMUNITY |
|
2012-10-26 11:08 |
alex |
Developer |
=> alex |
|
2012-10-26 11:08 |
alex |
Status |
active => needs testing |
|
2012-10-26 11:08 |
alex |
File Added: dont_use_request_modules.patch |
|
|
2012-10-26 11:08 |
alex |
File Added: dont_use_request_core.patch |
|
|
2012-10-26 10:29 |
alex |
New Issue |
|
|
2012-10-26 10:29 |
alex |
Reference |
=> https://groups.google.com/d/topic/in-portal-bugs/c0CFc4BjZQE/discussion |
|
2012-10-26 10:29 |
alex |
Change Log Message |
=> Removes usage of $_REQUEST variable |
|
2012-10-26 10:29 |
alex |
Estimate Points |
=> 1 |