In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

ID

Category

Type

Reproducibility

Date Submitted

Last Update

0000960

[In-Portal CMS] Install / Upgrages

bug report

always

2011-01-09 07:29

2011-09-19 16:08

Reporter

alex

View Status

public

Project Name

In-Portal CMS

Assigned To

alex

Developer

Priority

normal

Resolution

fixed

Fixed in Version

5.1.3-B1

Status

closed

Product Version

4.3.9

Target Version

5.1.3

Time Estimate

No estimate

Summary

0000960: Upgrade to 4.3.9 gives SQL error, when no modules were installed

Description

Upgrade to 4.3.9 gives SQL error, when no modules were installed

Additional Information

Quick note that Upgrade Test should be performed at least from 4.3.1 (no modules as noted) or earlier version.

Tags

No tags attached.

Reference

https://groups.google.com/d/topic/in-portal-bugs/GHwwFVjH8BQ/discussion

Change Log Message

Fixes SQL error during upgrade to 4.3.9 version

Estimate Points

0

upgrade_to_439_gives_error_on_no_modules_installed.patch [^] (939 bytes) 2011-01-09 07:29 [Show Content]

Index: upgrades.php
===================================================================
--- upgrades.php	(revision 14103)
+++ upgrades.php	(working copy)
@@ -227,11 +227,13 @@
 				'<inp:topic _field="link" _Template="inbulletin/post_list"' => '<inp2:bb_TopicLink template="__default__"',
 			);
 
-			foreach ($replacements as $old_tag => $new_tag) {
-				$sql = 'UPDATE '.TABLE_PREFIX.'EmailMessage
-						SET Template = REPLACE(Template, '.$this->Conn->qstr($old_tag).', '.$this->Conn->qstr($new_tag).')
-						WHERE EventId IN ('.$event_ids.')';
-				$this->Conn->Query($sql);
+			if ($event_ids) {
+				foreach ($replacements as $old_tag => $new_tag) {
+					$sql = 'UPDATE '.TABLE_PREFIX.'EmailMessage
+							SET Template = REPLACE(Template, '.$this->Conn->qstr($old_tag).', '.$this->Conn->qstr($new_tag).')
+							WHERE EventId IN ('.$event_ids.')';
+					$this->Conn->Query($sql);
+				}
 			}
 
 			if ($mode == 'after') {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003194) Dmitry (manager) 2011-01-10 12:31	Reviewed and tested good!

(0003435) alex (manager) 2011-05-20 03:14	Fix committed to 5.1.x branch. Commit Message: Fixes 0000960: Upgrade to 4.3.9 gives SQL error, when no modules were installed

(0003864) alex (manager) 2011-09-19 16:08	Closing, since 5.1.3 release has been released.

Related Changesets
In-Portal CMS: 5.1.x r14327 Timestamp: 2011-05-20 03:14:24 Author: alex [ Details ] [ Diff ]	Fixes 0000960: Upgrade to 4.3.9 gives SQL error, when no modules were installed
	mod - /in-portal/branches/5.1.x/core/install/upgrades.php		[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2011-09-19 16:08	alex	Note Added: 0003864
2011-09-19 16:08	alex	Status	resolved => closed
2011-05-20 03:14	alex	Note Added: 0003435
2011-05-20 03:14	alex	Status	reviewed and tested => resolved
2011-05-20 03:14	alex	Fixed in Version	=> 5.1.3-B1
2011-05-20 03:14	alex	Resolution	open => fixed
2011-05-20 03:14	alex	Assigned To	!COMMUNITY => alex
2011-05-20 03:14	alex	Changeset attached	5.1.x r14327
2011-04-04 11:49	Dmitry	Target Version	Icebox => 5.1.3
2011-01-10 12:31	Dmitry	Note Added: 0003194
2011-01-10 12:31	Dmitry	Status	needs testing => reviewed and tested
2011-01-09 13:56	Dmitry	Additional Information Updated	View Revisions
2011-01-09 07:30	alex	Assigned To	=> !COMMUNITY
2011-01-09 07:30	alex	Developer	=> alex
2011-01-09 07:30	alex	Status	active => needs testing
2011-01-09 07:30	alex	Reference	=> https://groups.google.com/d/topic/in-portal-bugs/GHwwFVjH8BQ/discussion
2011-01-09 07:29	alex	New Issue
2011-01-09 07:29	alex	File Added: upgrade_to_439_gives_error_on_no_modules_installed.patch
2011-01-09 07:29	alex	Change Log Message	=> Fixes SQL error during upgrade to 4.3.9 version

Web Development by Intechnic

In-Portal Open Source CMS

In-Portal Open Source CMS

Copyright © 2000 - 2009 MantisBT Group