In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details [ Jump to Notes ] [ Wiki ]

[ View Advanced ] [ Issue History ] [ Print ]

Tags

No tags attached.

Reference

http://groups.google.com/group/in-portal-dev/browse_thread/thread/3492f22f4dd92e88

Change Log Message

Corrections in PortalUser table fields

Estimate Points

Attached Files

Corrections-in-PortalUser-table-fields.patch [^] (7,318 bytes) 2010-10-29 13:29 [Show Content]

Index: install/install_schema.sql
===================================================================
--- install/install_schema.sql	(revision 14023)
+++ install/install_schema.sql	(working copy)
@@ -244,27 +244,27 @@
   Company varchar(255) NOT NULL DEFAULT '',
   Email varchar(255) NOT NULL DEFAULT '',
   CreatedOn int(11) DEFAULT NULL,
-  Phone varchar(20) DEFAULT NULL,
+  Phone varchar(255) NOT NULL DEFAULT '',
   Fax varchar(255) NOT NULL DEFAULT '',
-  Street varchar(255) DEFAULT NULL,
+  Street varchar(255) NOT NULL DEFAULT '',
   Street2 varchar(255) NOT NULL DEFAULT '',
-  City varchar(20) DEFAULT NULL,
+  City varchar(255) NOT NULL DEFAULT '',
   State varchar(20) NOT NULL DEFAULT '',
-  Zip varchar(20) DEFAULT NULL,
+  Zip varchar(20) NOT NULL DEFAULT '',
   Country varchar(20) NOT NULL DEFAULT '',
   ResourceId int(11) NOT NULL DEFAULT '0',
   `Status` tinyint(4) NOT NULL DEFAULT '1',
   Modified int(11) DEFAULT NULL,
   dob int(11) DEFAULT NULL,
   tz int(11) DEFAULT NULL,
-  ip varchar(20) DEFAULT NULL,
+  ip varchar(20) NOT NULL DEFAULT '',
   IsBanned tinyint(1) NOT NULL DEFAULT '0',
   PassResetTime int(11) unsigned DEFAULT NULL,
   PwResetConfirm varchar(255) DEFAULT NULL,
   PwRequestTime int(11) unsigned DEFAULT NULL,
   MinPwResetDelay int(11) NOT NULL DEFAULT '1800',
   AdminLanguage int(11) DEFAULT NULL,
-  DisplayToPublic text,
+  DisplayToPublic TEXT,
   PRIMARY KEY (PortalUserId),
   UNIQUE KEY ResourceId (ResourceId),
   UNIQUE KEY Login (Login),
Index: install/upgrades.sql
===================================================================
--- install/upgrades.sql	(revision 14023)
+++ install/upgrades.sql	(working copy)
@@ -1979,4 +1979,12 @@
 ALTER TABLE ItemReview CHANGE CreatedById CreatedById INT(11) NULL DEFAULT NULL;
 
 # ===== v 5.1.1-B2 =====
-UPDATE Phrase SET `Module` = 'Core' WHERE PhraseKey = 'LU_SECTION_FILES';
\ No newline at end of file
+UPDATE Phrase SET `Module` = 'Core' WHERE PhraseKey = 'LU_SECTION_FILES';
+
+# ===== v 5.1.1-RC1 =====
+ALTER TABLE PortalUser
+	CHANGE Phone Phone VARCHAR(255) NOT NULL DEFAULT '',
+	CHANGE City City VARCHAR(255) NOT NULL DEFAULT '',
+	CHANGE Street Street VARCHAR(255) NOT NULL DEFAULT '',
+	CHANGE Zip Zip VARCHAR(20) NOT NULL DEFAULT '',
+	CHANGE ip ip VARCHAR(20) NOT NULL DEFAULT '';
\ No newline at end of file
Index: units/users/users_config.php
===================================================================
--- units/users/users_config.php	(revision 14023)
+++ units/users/users_config.php	(working copy)
@@ -341,7 +341,7 @@
 							        'Password' => Array ('type' => 'string', 'formatter' => 'kPasswordFormatter', 'encryption_method' => 'md5', 'verify_field' => 'VerifyPassword', 'skip_empty' => 1, 'default' => md5('')),
 							        'FirstName' => Array ('type' => 'string', 'not_null' => 1, 'default' => ''),
 							        'LastName' => Array ('type' => 'string', 'not_null' => 1, 'default' => ''),
-							        'Company' => Array ('type' => 'string','not_null' => '1','default' => ''),
+							        'Company' => Array ('type' => 'string','not_null' => 1,'default' => ''),
 							        'Email' => Array (
 							        	'type' => 'string', 'formatter' => 'kFormatter',
 							        	'regexp'=>'/^(' . REGEX_EMAIL_USER . '@' . REGEX_EMAIL_DOMAIN . ')$/i',
@@ -353,18 +353,18 @@
 							        	),
 							        ),
 							        'CreatedOn' => Array('type'=>'int', 'formatter' => 'kDateFormatter', 'default' => '#NOW#'),
-							        'Phone' => Array('type' => 'string','default' => null),
+							        'Phone' => Array('type' => 'string', 'not_null' => 1, 'default' => ''),
 							        'Fax' => Array('type' => 'string', 'not_null' => 1, 'default' => ''),
-							        'Street' => Array('type' => 'string', 'default' => null),
-							        'Street2' => Array('type' => 'string', 'not_null' => '1', 'default' => ''),
-							        'City' => Array('type' => 'string','default' => null),
+							        'Street' => Array('type' => 'string', 'not_null' => 1, 'default' => ''),
+							        'Street2' => Array('type' => 'string', 'not_null' => 1, 'default' => ''),
+							        'City' => Array('type' => 'string', 'not_null' => 1, 'default' => ''),
 							        'State' => Array(
 							        	'type' => 'string',
 							        	'formatter' => 'kOptionsFormatter', 'options' => Array(),
 										'not_null' => 1,
-										'default' => ''
+										'default' => '',
 							        ),
-							        'Zip' => Array('type' => 'string','default' => null),
+							        'Zip' => Array('type' => 'string', 'not_null' => 1, 'default' => '',),
 							        'Country' => Array(
 							        	'type' => 'string',
 							        	'formatter' => 'kOptionsFormatter',
@@ -373,23 +373,23 @@
 															WHERE Type = ' . DESTINATION_TYPE_COUNTRY . '
 															ORDER BY Name',
 										'option_key_field' => 'IsoCode', 'option_title_field' => 'Name',
-										'not_null' => 1, 'default' => ''
+										'not_null' => 1, 'default' => '',
 							        ),
 							        'ResourceId' => Array('type' => 'int','not_null' => 1, 'default' => 0),
-							        'Status' => Array('type' => 'int', 'formatter'=>'kOptionsFormatter', 'options'=>Array(1=>'la_Enabled', 0=>'la_Disabled', 2=>'la_Pending'), 'use_phrases'=>1, 'not_null' => '1','default' => 1),
+							        'Status' => Array('type' => 'int', 'formatter'=>'kOptionsFormatter', 'options'=>Array(1=>'la_Enabled', 0=>'la_Disabled', 2=>'la_Pending'), 'use_phrases'=>1, 'not_null' => 1, 'default' => 1),
 							        'Modified' => Array('type' => 'int', 'formatter' => 'kDateFormatter', 'default' => '#NOW#'),
-							        'dob' => Array('type'=>'int', 'formatter' => 'kDateFormatter', 'default' => null),
+							        'dob' => Array('type'=>'int', 'formatter' => 'kDateFormatter', 'default' => NULL),
 							        'tz' => Array('type' => 'int', 'default' => NULL),
-							        'ip' => Array('type' => 'string','default' => null),
+							        'ip' => Array('type' => 'string', 'not_null' => 1, 'default' => ''),
 							        'IsBanned' => Array('type' => 'int','not_null' => 1, 'default' => 0),
-							        'PassResetTime' => Array('type' => 'int','default' => null),
-							        'PwResetConfirm' => Array('type' => 'string','default' => null),
-							        'PwRequestTime' => Array('type' => 'int','default' => null),
+							        'PassResetTime' => Array('type' => 'int','default' => NULL),
+							        'PwResetConfirm' => Array('type' => 'string','default' => NULL),
+							        'PwRequestTime' => Array('type' => 'int','default' => NULL),
 							        'MinPwResetDelay' => Array('type' => 'int', 'formatter' => 'kOptionsFormatter', 'options' => Array(300 => '5', 600 => '10', 900 => '15', 1800 => '30', 3600 => '60'), 'use_phrases' => 0, 'not_null' => '1',  'default' => 1800),
 									'AdminLanguage' => Array (
 										'type' => 'int',
 										'formatter' => 'kOptionsFormatter', 'options_sql' => 'SELECT %s FROM ' . TABLE_PREFIX . 'Language ORDER BY PackName', 'option_key_field' => 'LanguageId', 'option_title_field' => 'LocalName',
-										'default' => NULL
+										'default' => NULL,
 									),
 									'DisplayToPublic' => Array (
 										'type' => 'string',

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0002929) Dmitry (manager) 2010-10-29 13:29	Please review and test.

(0002931) Dmitry (manager) 2010-10-31 10:45	Reminder sent to: alex Please test when you have a chance.

(0002946) alex (manager) 2010-11-01 15:47	ok

(0002947) alex (manager) 2010-11-01 15:48	Fix committed to 5.1.x branch. Commit Message: 1. Fixes 0000909: Corrections in PortalUser table fields 2. Commit on behalf of Dmitry

(0003003) Dmitry (manager) 2010-11-30 12:48	Closing released 5.1.1 task.

Related Changesets
In-Portal CMS: 5.1.x r14029 Timestamp: 2010-11-01 15:48:14 Author: alex [ Details ] [ Diff ]	1. Fixes 0000909: Corrections in PortalUser table fields 2. Commit on behalf of Dmitry
	mod - /in-portal/branches/5.1.x/core/install/install_schema.sql	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/install/upgrades.sql	[ Diff ] [ File ]
	mod - /in-portal/branches/5.1.x/core/units/users/users_config.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2010-11-30 12:48	Dmitry	Note Added: 0003003
2010-11-30 12:48	Dmitry	Status	resolved => closed
2010-11-01 15:48	alex	Note Added: 0002947
2010-11-01 15:48	alex	Status	reviewed and tested => resolved
2010-11-01 15:48	alex	Fixed in Version	=> 5.1.1-RC1
2010-11-01 15:48	alex	Resolution	open => fixed
2010-11-01 15:48	alex	Assigned To	!COMMUNITY => alex
2010-11-01 15:48	alex	Changeset attached	5.1.x r14029
2010-11-01 15:47	alex	Note Added: 0002946
2010-11-01 15:47	alex	Assigned To	alex => !COMMUNITY
2010-11-01 15:47	alex	Status	needs testing => reviewed and tested
2010-10-31 10:45	Dmitry	Note Added: 0002931
2010-10-31 10:45	Dmitry	Assigned To	!COMMUNITY => alex
2010-10-29 13:48	Dmitry	Assigned To	Dmitry => !COMMUNITY
2010-10-29 13:47	Dmitry	Status	needs work => needs testing
2010-10-29 13:47	Dmitry	Status	needs testing => needs work
2010-10-29 13:47	Dmitry	Assigned To	!COMMUNITY => Dmitry
2010-10-29 13:29	Dmitry	Note Added: 0002929
2010-10-29 13:29	Dmitry	Assigned To	Dmitry => !COMMUNITY
2010-10-29 13:29	Dmitry	Developer	=> Dmitry
2010-10-29 13:29	Dmitry	Status	needs work => needs testing
2010-10-29 13:29	Dmitry	File Added: Corrections-in-PortalUser-table-fields.patch
2010-10-29 13:27	Dmitry	Change Log Message	Increased length of Phone and City DB fields for User prefix => Corrections in PortalUser table fields
2010-10-29 13:27	Dmitry	Assigned To	=> Dmitry
2010-10-29 13:27	Dmitry	Status	active => needs work
2010-10-29 13:27	Dmitry	Summary	Increase length of Phone and City DB fields for User prefix => Corrections in PortalUser table fields
2010-10-29 13:27	Dmitry	Description Updated	View Revisions
2010-10-29 11:22	Dmitry	New Issue
2010-10-29 11:22	Dmitry	Reference	=> http://groups.google.com/group/in-portal-dev/browse_thread/thread/3492f22f4dd92e88
2010-10-29 11:22	Dmitry	Change Log Message	=> Increased length of Phone and City DB fields for User prefix

Web Development by Intechnic

In-Portal Open Source CMS