In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000905 [In-Portal CMS] Data Management bug report always 2010-10-25 15:24 2011-03-30 09:57
Reporter alex View Status public Project Name In-Commerce
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.1.2-B1
Status closed Product Version 5.1.1-B2 Target Version 5.1.2
Time EstimateNo estimate
Summary 0000905: Coupon cloning broken
Description When I try to clone coupon (I'm logged-in by admin user, not "root"), then:

* after pressing "Clone" toolbar button I got JavaScript error, that "initCalendar" function isn't defined (that could because someone, who developed it used custom form block instead of predefined one)
* after pressing "Save" button I got PHP error: permission mapping not defined for coup:OnApplyClone event.
Additional Information
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-bugs/browse_thread/thread/9882ff9eb7b729eb
Change Log Message Fixes coupon cloning
Estimate Points 0
Attached Files patch file icon coupon_cloning_problem.patch [^] (8,444 bytes) 2011-01-05 02:14 [Show Content]
patch file icon coupon_cloning_problem_v2.patch [^] (8,603 bytes) 2011-01-05 02:25 [Show Content]
patch file icon coupon_cloning_problem-v3-Dmitry.patch [^] (12,932 bytes) 2011-01-05 12:15 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0003128)
alex (manager)
2011-01-05 02:16
edited on: 2011-01-05 02:17

Also I've found, that fixing both mentioned issues (js and permission) I've got another issue with form not being closed and error reported, but no field was highlighted.

This was happening because original coupon id (that was selected for cloning) was missing in final OnApplyClone event.

------------

Also I've noticed, that same cloning problem could be with Gift Certificates.

User avatar (0003196)
alex (manager)
2011-01-11 03:08

ok
User avatar (0003197)
alex (manager)
2011-01-11 03:09

Fix committed to 5.1.x branch. Commit Message:

1. Fixes 0000905: Coupon cloning broken
2. Commit on behalf of Dmitry
User avatar (0003376)
Dmitry (manager)
2011-03-30 09:57

Closing, since 5.1.2 release has been released.

- Related Changesets
Modules :: In-Commerce: 5.1.x r14149
Timestamp: 2011-01-11 03:09:09
Author: alex
Details ] Diff ]
1. Fixes 0000905: Coupon cloning broken
2. Commit on behalf of Dmitry
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/coupon_clone_selector.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/admin_templates/discounts/coupons_list.tpl Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/coupon_items/coupon_items_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/coupons/coupons_config.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/coupons/coupons_event_handler.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/coupons/coupons_tag_processor.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gift_certificates/gift_certificates_eh.php Diff ] File ]
mod - /w/in-commerce/branches/5.1.x/units/gift_certificates/gift_certificates_tp.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2011-03-30 09:57 Dmitry Note Added: 0003376
2011-03-30 09:57 Dmitry Status resolved => closed
2011-01-11 03:09 alex Note Added: 0003197
2011-01-11 03:09 alex Status reviewed and tested => resolved
2011-01-11 03:09 alex Fixed in Version => 5.1.2-B1
2011-01-11 03:09 alex Resolution open => fixed
2011-01-11 03:09 alex Assigned To Dmitry => alex
2011-01-11 03:09 alex Changeset attached 5.1.x r14149
2011-01-11 03:08 alex Note Added: 0003196
2011-01-11 03:08 alex Assigned To alex => Dmitry
2011-01-11 03:08 alex Status needs testing => reviewed and tested
2011-01-05 14:26 Dmitry Status needs work => needs testing
2011-01-05 14:26 Dmitry Status needs testing => needs work
2011-01-05 14:26 Dmitry Assigned To Dmitry => alex
2011-01-05 12:16 Dmitry Change Log Message => Fixes coupon cloning
2011-01-05 12:16 Dmitry Developer alex => Dmitry
2011-01-05 12:15 Dmitry File Added: coupon_cloning_problem-v3-Dmitry.patch
2011-01-05 02:25 alex File Added: coupon_cloning_problem_v2.patch
2011-01-05 02:17 alex Note Edited: 0003128 View Revisions
2011-01-05 02:16 alex Note Added: 0003128
2011-01-05 02:16 alex Assigned To => Dmitry
2011-01-05 02:16 alex Developer => alex
2011-01-05 02:16 alex Status active => needs testing
2011-01-05 02:14 alex File Added: coupon_cloning_problem.patch
2010-12-06 11:56 alex Target Version Icebox => 5.1.2
2010-10-25 15:24 alex New Issue
2010-10-25 15:24 alex Reference => http://groups.google.com/group/in-portal-bugs/browse_thread/thread/9882ff9eb7b729eb



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker