In-Portal Issue Tracker

Welcome to the In-Portal Open Source CMS Issue Tracker! This is a central management / tracking tool for all types of tasks / issues / bugs for the In-Portal Project. Before reporting any issues, please make sure to read the Guide into Issue Tracker and How to Properly Test and Report Bugs!

Viewing Issue Simple Details Jump to Notes ] Wiki ] View Advanced ] Issue History ] Print ]
ID Category Type Reproducibility Date Submitted Last Update
0000899 [In-Portal CMS] Template System feature request always 2010-10-22 18:13 2012-07-25 05:33
Reporter Dmitry View Status public Project Name In-Portal CMS
Assigned To alex Developer
Priority normal Resolution fixed Fixed in Version 5.2.0-B1
Status closed Product Version 5.1.1-B2 Target Version 5.2.0
Time EstimateNo estimate
Summary 0000899: Create new "m_CurrentPageLink" tag to return current Page URL
Description Create new <inp2:m_CurrentPageLink skip_query="1"/> tag to return current Page URL (without re-assembling it). That "skip_query" param is optional and will skip the ?QUERY part.

For speed purposes use:

1. with query: $_SERVER['REQUEST_URI']
2. without query: preg_replace('/\?' . preg_quote($_SERVER['QUERY_STRING'], '/') . '$/', '', $_SERVER['REQUEST_URI'])

Note: as you can see no domain is added for faster performance
Additional Information Can't set 0.5 as a quote (mantis problem), so I set 1 hour, but I mean 0.5 hours.
Tags No tags attached.
Reference http://groups.google.com/group/in-portal-dev/browse_thread/thread/1cad125f5aeada6f
Change Log Message Created new "CurrentPageLink" tag returning current Page URL
Estimate Points 1
Attached Files patch file icon create_currentpagelink_tag_899.patch [^] (537 bytes) 2011-09-30 08:47 [Show Content]
patch file icon create_currentpagelink_tag_899.2.patch [^] (684 bytes) 2011-10-04 10:20 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
User avatar (0003945)
erik (manager)
2011-09-30 08:47

Patch uploaded - needs testing
User avatar (0003978)
alex (manager)
2011-10-03 12:14

1. Simple boolean type parameter value checks should be performed more generally, e.g.
array_key_exists('skip_query', $params) && $params['skip_query'] == 1
is transformed to:
isset($params['skip_query']) && $params['skip_query']

Also "isset" function works faster then "array_key_exists", so it's more preferable, when NULL isn't possible as array key value.

2. There should be always an empty line before function/method return statement

3. Add scope statement in tag method declaration and appropriate PhpDoc comment (as for all methods, created in 5.2.0 release). This can be done typing "/**" and then ENTER above function definition.
User avatar (0004005)
erik (manager)
2011-10-04 10:20

create_currentpagelink_tag_899.2.patch attached - needs testing
User avatar (0004014)
alex (manager)
2011-10-05 07:20

Fix committed to 5.2.x branch. Commit Message:

Fixes 0000899: Create new "m_CurrentPageLink" tag to return current Page URL
Commit on behalf of Erik
User avatar (0005101)
alex (manager)
2012-07-25 05:33

Since 5.2.0 version was released.

- Related Changesets
In-Portal CMS: 5.2.x r14634
Timestamp: 2011-10-05 07:20:20
Author: alex
Details ] Diff ]
Fixes 0000899: Create new "m_CurrentPageLink" tag to return current Page URL
Commit on behalf of Erik
mod - /in-portal/branches/5.2.x/core/kernel/processors/main_processor.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2012-07-25 05:33 alex Note Added: 0005101
2012-07-25 05:33 alex Status resolved => closed
2011-10-22 05:31 alex Estimate Points => 1
2011-10-05 07:20 alex Note Added: 0004014
2011-10-05 07:20 alex Status reviewed and tested => resolved
2011-10-05 07:20 alex Fixed in Version => 5.2.0-B1
2011-10-05 07:20 alex Resolution open => fixed
2011-10-05 07:20 alex Assigned To !COMMUNITY => alex
2011-10-05 07:20 alex Changeset attached 5.2.x r14634
2011-10-05 07:19 alex Assigned To alex => !COMMUNITY
2011-10-05 07:19 alex Status needs testing => reviewed and tested
2011-10-04 10:20 erik Note Added: 0004005
2011-10-04 10:20 erik Assigned To erik => alex
2011-10-04 10:20 erik Status needs work => needs testing
2011-10-04 10:20 erik File Added: create_currentpagelink_tag_899.2.patch
2011-10-04 10:02 erik File Deleted: create_currentpagelink_tag_899.2.patch
2011-10-04 09:59 erik File Added: create_currentpagelink_tag_899.2.patch
2011-10-03 12:14 alex Note Added: 0003978
2011-10-03 12:14 alex Assigned To alex => erik
2011-10-03 12:14 alex Status needs testing => needs work
2011-09-30 08:47 erik Time Estimate Removed 1 =>
2011-09-30 08:47 erik Note Added: 0003945
2011-09-30 08:47 erik Assigned To erik => alex
2011-09-30 08:47 erik Developer => erik
2011-09-30 08:47 erik Status needs work => needs testing
2011-09-30 08:47 erik File Added: create_currentpagelink_tag_899.patch
2011-09-26 04:02 alex Time Estimate Added 1
2011-09-26 04:02 alex Description Updated View Revisions
2011-09-26 04:02 alex Additional Information Updated View Revisions
2011-09-24 22:42 Dmitry Assigned To => erik
2011-09-24 22:42 Dmitry Status active => needs work
2011-09-24 22:42 Dmitry Target Version Icebox => 5.2.0
2010-10-22 18:13 Dmitry New Issue
2010-10-22 18:13 Dmitry Reference => http://groups.google.com/group/in-portal-dev/browse_thread/thread/1cad125f5aeada6f
2010-10-22 18:13 Dmitry Change Log Message => Created new "CurrentPageLink" tag returning current Page URL



Web Development by Intechnic
In-Portal Open Source CMS
In-Portal Open Source CMS
Copyright © 2000 - 2009 MantisBT Group

Powered by Mantis Bugtracker